From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7184BC433E1 for ; Thu, 9 Jul 2020 12:10:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51C4C2077D for ; Thu, 9 Jul 2020 12:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594296656; bh=B9DiarjoS7dtdUdozXYKFnMARuvylV0tyZzffRUfgh0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=aRtpkWlTSxBDdjdCk05uz9xx09WKrFz254maAckZZQncNC26VfGcllrbeQq96uNlN 55CEfJxbsC3d7Ea2VBVEsiS3yWyqbsDah4dCZ/TGEqfmQ1iOmu/5fdmUobWZo8zpGP EvZ4z5C1cjgbeoLPmeZeIN9tSV27pl8Vgz8wCKQw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726881AbgGIMKz (ORCPT ); Thu, 9 Jul 2020 08:10:55 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:43453 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726599AbgGIMKz (ORCPT ); Thu, 9 Jul 2020 08:10:55 -0400 Received: by mail-ot1-f67.google.com with SMTP id 95so1497874otw.10; Thu, 09 Jul 2020 05:10:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YOjL0UML2dSKlLSP/sqPvKmua2zfxEU3z20Tax7E+dU=; b=Ycmt5KN1TlQ92MyNOHAfWi9PllW2dIhKvgxhzggdU4bznyc5v+Z3rY0RcnxCC4gS/p X2MTr/juJKDsz9P3DNEaZhNfsxazLxGSadLX1NlnyuP4yjYG3fTm9MoxYxFrV9yVy8hK x3g7pEAPMHoQc/tK+AAWPBpKOIAzJZ1AIDAmXvCBmb4g243I3FJJBTEriZreS/NFHqdS jryxS07CEXF9hFr8oWBLAefKwXPAZy+SrvVTa4kP38p8T9ujNzH/yyHl9HzOhMJp7Xlp WTAkJ5TTeqeT8VPqiBf+P5lu9c3JRxBrNBniFxsGNDZ0+uxllQtlFE23JVWwYaQrWo9t zffw== X-Gm-Message-State: AOAM5329nuxqcoMscbRHC8oC2v4QQ/jeSOAA/3ixqjiMIL4uQnG7tjOh 42MfTpxeBtF8PAfuGIXBzPDB3XU4w/Qc4wUWkD8= X-Google-Smtp-Source: ABdhPJzrdCIXJtWpQ57B//JafGA2Ik24qTnJZ4xpWpyPvoIKWIHmwlPcOqcrf6uegkz7DGv/y4jHGoguZ6n44qDt5Cw= X-Received: by 2002:a9d:590a:: with SMTP id t10mr17147901oth.262.1594296653915; Thu, 09 Jul 2020 05:10:53 -0700 (PDT) MIME-Version: 1.0 References: <20200707200937.GA5056@embeddedor> In-Reply-To: <20200707200937.GA5056@embeddedor> From: "Rafael J. Wysocki" Date: Thu, 9 Jul 2020 14:10:41 +0200 Message-ID: Subject: Re: [PATCH] ACPI: Use fallthrough pseudo-keyword To: "Gustavo A. R. Silva" Cc: "Rafael J. Wysocki" , Len Brown , Bjorn Helgaas , ACPI Devel Maling List , Linux Kernel Mailing List , Linux PCI Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jul 7, 2020 at 10:04 PM Gustavo A. R. Silva wrote: > > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by: Gustavo A. R. Silva Applied as 5.9 material, thanks! > --- > drivers/acpi/ac.c | 2 +- > drivers/acpi/acpi_processor.c | 2 +- > drivers/acpi/button.c | 2 +- > drivers/acpi/dock.c | 2 +- > drivers/acpi/evged.c | 2 +- > drivers/acpi/processor_idle.c | 3 +-- > drivers/acpi/resource.c | 2 +- > drivers/acpi/spcr.c | 4 ++-- > drivers/pci/pci-acpi.c | 6 +++--- > 9 files changed, 12 insertions(+), 13 deletions(-) > > diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c > index 69d2db13886b..2dfa08f939c6 100644 > --- a/drivers/acpi/ac.c > +++ b/drivers/acpi/ac.c > @@ -236,7 +236,7 @@ static void acpi_ac_notify(struct acpi_device *device, u32 event) > default: > ACPI_DEBUG_PRINT((ACPI_DB_INFO, > "Unsupported event [0x%x]\n", event)); > - /* fall through */ > + fallthrough; > case ACPI_AC_NOTIFY_STATUS: > case ACPI_NOTIFY_BUS_CHECK: > case ACPI_NOTIFY_DEVICE_CHECK: > diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c > index 5379bc3f275d..b51ddf3bb616 100644 > --- a/drivers/acpi/acpi_processor.c > +++ b/drivers/acpi/acpi_processor.c > @@ -79,7 +79,7 @@ static int acpi_processor_errata_piix4(struct pci_dev *dev) > * PIIX4 models. > */ > errata.piix4.throttle = 1; > - /* fall through*/ > + fallthrough; > > case 2: /* PIIX4E */ > case 3: /* PIIX4M */ > diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c > index 3c35e57dd854..a4eda7fe50d3 100644 > --- a/drivers/acpi/button.c > +++ b/drivers/acpi/button.c > @@ -405,7 +405,7 @@ static void acpi_button_notify(struct acpi_device *device, u32 event) > switch (event) { > case ACPI_FIXED_HARDWARE_EVENT: > event = ACPI_BUTTON_NOTIFY_STATUS; > - /* fall through */ > + fallthrough; > case ACPI_BUTTON_NOTIFY_STATUS: > input = button->input; > if (button->type == ACPI_BUTTON_TYPE_LID) { > diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c > index e3414131bfca..9bd72c26ef46 100644 > --- a/drivers/acpi/dock.c > +++ b/drivers/acpi/dock.c > @@ -469,7 +469,7 @@ int dock_notify(struct acpi_device *adev, u32 event) > surprise_removal = 1; > event = ACPI_NOTIFY_EJECT_REQUEST; > /* Fall back */ > - /* fall through */ > + fallthrough; > case ACPI_NOTIFY_EJECT_REQUEST: > begin_undock(ds); > if ((immediate_undock && !(ds->flags & DOCK_IS_ATA)) > diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c > index ccd900690b6f..b1a7f8d6965e 100644 > --- a/drivers/acpi/evged.c > +++ b/drivers/acpi/evged.c > @@ -106,7 +106,7 @@ static acpi_status acpi_ged_request_interrupt(struct acpi_resource *ares, > > if (ACPI_SUCCESS(acpi_get_handle(handle, ev_name, &evt_handle))) > break; > - /* fall through */ > + fallthrough; > default: > if (ACPI_SUCCESS(acpi_get_handle(handle, "_EVT", &evt_handle))) > break; > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > index 75534c5b5433..9325feaac5f8 100644 > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -203,8 +203,7 @@ static void tsc_check_state(int state) > */ > if (boot_cpu_has(X86_FEATURE_NONSTOP_TSC)) > return; > - > - /*FALL THROUGH*/ > + fallthrough; > default: > /* TSC could halt in idle, so notify users */ > if (state > ACPI_STATE_C1) > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c > index 3b4448972374..ad04824ca3ba 100644 > --- a/drivers/acpi/resource.c > +++ b/drivers/acpi/resource.c > @@ -373,7 +373,7 @@ unsigned int acpi_dev_get_irq_type(int triggering, int polarity) > case ACPI_ACTIVE_BOTH: > if (triggering == ACPI_EDGE_SENSITIVE) > return IRQ_TYPE_EDGE_BOTH; > - /* fall through */ > + fallthrough; > default: > return IRQ_TYPE_NONE; > } > diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c > index d73b4535e79d..88460bacd5ae 100644 > --- a/drivers/acpi/spcr.c > +++ b/drivers/acpi/spcr.c > @@ -111,7 +111,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console) > table->serial_port.access_width))) { > default: > pr_err("Unexpected SPCR Access Width. Defaulting to byte size\n"); > - /* fall through */ > + fallthrough; > case 8: > iotype = "mmio"; > break; > @@ -128,7 +128,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console) > switch (table->interface_type) { > case ACPI_DBG2_ARM_SBSA_32BIT: > iotype = "mmio32"; > - /* fall through */ > + fallthrough; > case ACPI_DBG2_ARM_PL011: > case ACPI_DBG2_ARM_SBSA_GENERIC: > case ACPI_DBG2_BCM2835: > diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c > index 7224b1e5f2a8..0d85025c55fd 100644 > --- a/drivers/pci/pci-acpi.c > +++ b/drivers/pci/pci-acpi.c > @@ -527,8 +527,8 @@ static void program_hpx_type3_register(struct pci_dev *dev, > return; > > break; > - case HPX_CFG_VEND_CAP: /* Fall through */ > - case HPX_CFG_DVSEC: /* Fall through */ > + case HPX_CFG_VEND_CAP: > + case HPX_CFG_DVSEC: > default: > pci_warn(dev, "Encountered _HPX type 3 with unsupported config space location"); > return; > @@ -1001,7 +1001,7 @@ static int acpi_pci_set_power_state(struct pci_dev *dev, pci_power_t state) > error = -EBUSY; > break; > } > - /* Fall through */ > + fallthrough; > case PCI_D0: > case PCI_D1: > case PCI_D2: >