From: Arnd Bergmann <arnd@arndb.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci <linux-pci@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Tom Joseph" <tjoseph@cadence.com>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Rahul Tanwar" <rtanwar@maxlinear.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Pali Rohár" <pali@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: Convert to new *_PM_OPS macros
Date: Thu, 21 Jul 2022 09:08:35 +0200 [thread overview]
Message-ID: <CAK8P3a0pbA7hSNgKw+yjBmXHGuwc_Y1tNJ7=vD5wiPn+rE1a8w@mail.gmail.com> (raw)
In-Reply-To: <20220719215108.1583108-1-helgaas@kernel.org>
On Tue, Jul 19, 2022 at 11:51 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Replace SET_*_PM_OPS with *_PM_OPS, which which have the advantage that the
> compiler always sees the PM callbacks as referenced, so they don't need to
> be wrapped with "#ifdef CONFIG_PM_SLEEP" or tagged with "__maybe_unused" to
> avoid "defined but not used" warnings.
>
> See 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones").
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
I did some additional testing, using an arm allmodconfig kernel with CONFIG_PM
and/or CONFIG_PM_SLEEP disabled to ensure this does not cause any
unexpected regressions. Everything seems to work as intended.
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2022-07-21 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 21:51 [PATCH] PCI: Convert to new *_PM_OPS macros Bjorn Helgaas
2022-07-19 22:00 ` Pali Rohár
2022-07-20 22:48 ` Bjorn Helgaas
2022-07-21 7:08 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0pbA7hSNgKw+yjBmXHGuwc_Y1tNJ7=vD5wiPn+rE1a8w@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=rtanwar@maxlinear.com \
--cc=ryder.lee@mediatek.com \
--cc=shawn.lin@rock-chips.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tjoseph@cadence.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).