linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Murray <amurray@thegoodpenguin.co.uk>,
	Dilip Kota <eswara.kota@linux.intel.com>,
	Vidya Sagar <vidyas@nvidia.com>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Alex Dewar <alex.dewar90@gmail.com>,
	PCI <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: dwc: exynos: add back MSI dependency
Date: Mon, 7 Dec 2020 15:48:54 +0100	[thread overview]
Message-ID: <CAK8P3a1UH1O2kWOkHGAmFQ4Ys7MKBiC2OoDs96Ba4yWSf7vyTg@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqLCWK99AXzCWXpPsRxA+X5OKsHEGZtBhAsaVFhXoeRb9g@mail.gmail.com>

On Mon, Dec 7, 2020 at 3:23 PM Rob Herring <robh@kernel.org> wrote:
> On Fri, Dec 4, 2020 at 10:58 AM Arnd Bergmann <arnd@kernel.org> wrote:
> > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> > index 020101b58155..e403bb2eeb4c 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP
> >  config PCI_EXYNOS
> >         tristate "Samsung Exynos PCIe controller"
> >         depends on ARCH_EXYNOS || COMPILE_TEST
> > +       depends on PCI && PCI_MSI_IRQ_DOMAIN
>
> PCI isn't needed here.

Ah right. I had copied this from PCIE_DW_PLAT_HOST, and
I'm fairly sure it used to be needed at some point in the past,
but the Kconfig file has been changed enough over time that
it clearly is not needed any more, as the entire menu depends on
PCI nowadays, i.e. you can no longer have an endpoint-only
configuration.

      Arnd

      reply	other threads:[~2020-12-07 14:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 16:58 [PATCH] PCI: dwc: exynos: add back MSI dependency Arnd Bergmann
2020-12-07 14:23 ` Rob Herring
2020-12-07 14:48   ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a1UH1O2kWOkHGAmFQ4Ys7MKBiC2OoDs96Ba4yWSf7vyTg@mail.gmail.com \
    --to=arnd@kernel.org \
    --cc=alex.dewar90@gmail.com \
    --cc=amurray@thegoodpenguin.co.uk \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=eswara.kota@linux.intel.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=jh80.chung@samsung.com \
    --cc=jingoohan1@gmail.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh@kernel.org \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).