From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B550CC0018C for ; Mon, 7 Dec 2020 14:49:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 819D02337F for ; Mon, 7 Dec 2020 14:49:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbgLGOtw (ORCPT ); Mon, 7 Dec 2020 09:49:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:49544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbgLGOtw (ORCPT ); Mon, 7 Dec 2020 09:49:52 -0500 X-Gm-Message-State: AOAM530ecnSqT59fZ5m+k4Nm9KsR+ZG0Jrj5+auErwkbhba9ZRhjgFct akDK6gXzTTv2g6JqEaXMOuaOMXnxIZ9YSDVVuxg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607352551; bh=/7uV17ZjcWZRBQZBsaxXCvaCcx8EDJrzmSGwZfIHZBI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Z3B5NqZCUFukUOspe1ucdNJwSWpbKS1a3OEv7qGiI+AY5ORP39F5PVuoye/LBPICS teTcw177mtPE15AMkM0+fPHaQLBOVJONa6TkjWV9JSWYjPPTGZyrbSrNUT0vbDWHjH akxCIblLuwb9qhcZ4zQ7Mz2EUB2+k8sJC3rMQynkNKZbWuCzHaizMsWPnK5SmJBAZl 9E27x6WEF90tFbsTXEncNltMefT5e5QWoRS766VlwIvl6THvmMjVoaS+4npaAnAU7s 0bHD4Ce1PZYmbhxZTCdWu+Su3tIQK/g+j8icvylhE4CHe5wZhz3vSCFA+2Pt/kCgYK bDfcHgHznI9qQ== X-Google-Smtp-Source: ABdhPJzazfYYPi5tQ9qZHGKKTiqRYg1UwkAMXPK70lDr0uNGzI5KsYWNMuHafXqRdFME11jw4UVOwQTvauB6kYEvQ1s= X-Received: by 2002:a9d:7a4b:: with SMTP id z11mr9525803otm.305.1607352550928; Mon, 07 Dec 2020 06:49:10 -0800 (PST) MIME-Version: 1.0 References: <20201204165841.3845589-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 7 Dec 2020 15:48:54 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: dwc: exynos: add back MSI dependency To: Rob Herring Cc: Lorenzo Pieralisi , Bjorn Helgaas , Jaehoon Chung , Jingoo Han , Krzysztof Kozlowski , Arnd Bergmann , Andrew Murray , Dilip Kota , Vidya Sagar , Kunihiko Hayashi , Alex Dewar , PCI , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Dec 7, 2020 at 3:23 PM Rob Herring wrote: > On Fri, Dec 4, 2020 at 10:58 AM Arnd Bergmann wrote: > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > > index 020101b58155..e403bb2eeb4c 100644 > > --- a/drivers/pci/controller/dwc/Kconfig > > +++ b/drivers/pci/controller/dwc/Kconfig > > @@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP > > config PCI_EXYNOS > > tristate "Samsung Exynos PCIe controller" > > depends on ARCH_EXYNOS || COMPILE_TEST > > + depends on PCI && PCI_MSI_IRQ_DOMAIN > > PCI isn't needed here. Ah right. I had copied this from PCIE_DW_PLAT_HOST, and I'm fairly sure it used to be needed at some point in the past, but the Kconfig file has been changed enough over time that it clearly is not needed any more, as the entire menu depends on PCI nowadays, i.e. you can no longer have an endpoint-only configuration. Arnd