From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B2CC4167D for ; Sat, 26 Mar 2022 19:24:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234465AbiCZTZk convert rfc822-to-8bit (ORCPT ); Sat, 26 Mar 2022 15:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233620AbiCZTZi (ORCPT ); Sat, 26 Mar 2022 15:25:38 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C45D43207F; Sat, 26 Mar 2022 12:24:00 -0700 (PDT) Received: from mail-lf1-f49.google.com ([209.85.167.49]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MrhLu-1ntDVC3m0C-00nf9d; Sat, 26 Mar 2022 20:23:59 +0100 Received: by mail-lf1-f49.google.com with SMTP id p10so12670836lfa.12; Sat, 26 Mar 2022 12:23:58 -0700 (PDT) X-Gm-Message-State: AOAM533bmgyf9gtICHhD4uX3bpHPI/aYdc1Wjn6Ki5JXbMOATEGat/Y+ Gy1rG/hWj2yhVg3daMun/t2j8RkW6hPx3SLZkuY= X-Google-Smtp-Source: ABdhPJxx8NCR/u6qmXzG17FP9feBwegQPJsf9Aqi/l68ye4U4vfPlOZSED7ECKkFvKmT885cCFviGMxdRBsqoooKkLU= X-Received: by 2002:a5d:6505:0:b0:205:9a98:e184 with SMTP id x5-20020a5d6505000000b002059a98e184mr11258676wru.317.1648322627645; Sat, 26 Mar 2022 12:23:47 -0700 (PDT) MIME-Version: 1.0 References: <20220326165909.506926-1-benni@stuerz.xyz> In-Reply-To: <20220326165909.506926-1-benni@stuerz.xyz> From: Arnd Bergmann Date: Sat, 26 Mar 2022 20:23:31 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers To: =?UTF-8?Q?Benjamin_St=C3=BCrz?= Cc: Andrew Lunn , Sebastian Hesselbarth , Gregory CLEMENT , Russell King - ARM Linux , Simtec Linux Team , Krzysztof Kozlowski , Alim Akhtar , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Robert Moore , "Rafael J. Wysocki" , Len Brown , Chas Williams <3chas3@gmail.com>, Harald Welte , Arnd Bergmann , gregkh , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Linus Walleij , Bartosz Golaszewski , mike.marciniszyn@cornelisnetworks.com, dennis.dalessandro@cornelisnetworks.com, Jason Gunthorpe , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Dmitry Torokhov , Karsten Keil , Benjamin Herrenschmidt , Frederic Barrat , Andrew Donnellan , David Miller , Jakub Kicinski , pabeni@redhat.com, Nicolas Pitre , loic.poulain@linaro.org, kvalo@kernel.org, Pkshih , Bjorn Helgaas , Linux ARM , Linux Kernel Mailing List , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , linux-ia64@vger.kernel.org, ACPI Devel Maling List , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , linux-atm-general@lists.sourceforge.net, Networking , linux-edac@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-rdma , "open list:HID CORE LAYER" , linuxppc-dev , Linux Media Mailing List , wcn36xx@lists.infradead.org, linux-wireless , linux-pci Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:9figIUnCgtvaf/cKMq2S8Mrl7ngptWVGWjzOtUo3hOJ8JuZUqXf uGJHsYnWe/msKkwufx5cx8GjLMtmeUa4P0UGqi2U5Ehg8teMr5a6CVVLi/oFydUeqagKVDu 3Vvsy5IH4R2SidR4u3VseNYZpAa9Csqs9tqhrAAeU9/eoVB7bNuRhKsZXmCiVLDG5heinbb Fo2pPNQpCoAlPoGAryzUw== X-UI-Out-Filterresults: notjunk:1;V03:K0:RlqtZ8kYXZg=:weygU+7tyLUDVksTpjS8e5 HMK6a3RwJ4pP/DourG9N6pv/FKqMEGI+hY/rz9ZEkyBfPdVkwMhwkf75UAwHmKUqLiIJ4X16S fERCRgYWtzpSZo5S/1ir1vo+pLydwh5/vJoO4jjki7XDP0mVHb7VcMLUH2KMcATjZEQpBxP5/ Le8AXBRQbX0WX4mu1jAQQRUngcl6lVuJ1N0hdMcMMHSV1FjZjnUpBcy6TF8sTFzV/Ku2/DO86 XJGfxC0muugsEI3U+JUJGN+eBjFzkg6xS1u57ZMaauo4ALrhTdEi+PO7YxjVvscnqa1Pkx3bI 16XQ0Vt5urqXFfb7WPiNmvS0VF9EYpjL/2Xbi4Ygx4oMcluDFY7y/lgjRWqamPp5v6/mV5Joi hMFe6szOl0BsDPOXMuLdYmXUlkAnsFzL3m/3DhYUko5pP9kD4lRW6ea769aI3pTKOhWQ1/WhZ 2sBRqCre4vFTPxO7FLmbuDIDrgW8YS7mJfyh2dBxfL5qfG0KLCKLLuhoxy2PF86/ZpkzKkSSY TnWCjOoGCAe/Tp+NXlEZ0HKO2mTfVq/vc26d/9rCKENTUPCDGml73zyXYdOoOeXYI97YXlrHH 1/yZ+w9fQMQ4GVXmNtdmjsQTA6+8u8Mfj/oAsvjhc/7Du7Kx+nKd+VVT5m3SLPrK1qC+Oo9ns WO5HxobIpnBO2OVQOgap63NODBQtF5TxKHN5sX6NRJBG24d7dV5t3kW93fmrf+2QNq3W8hLTs xyTuMkuS7qKlerszk+X0tFneKJO4KuUui7P+wsIrahl5OwoahacsFleLfRqSV3i5DFizM/1rv k1jFyA4vTU3aAlFBb3cj/2kYzyHcjB0KWr8wUwgz2924c1/53s= Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz wrote: > > This replaces comments with C99's designated > initializers because the kernel supports them now. The change looks fine, but the comment looks misplaced, as enum initializers are not c99 feature. Also, the named array and struct intializers have been supported by gnu89 for a long time and widely used in the kernel, so it's not a recent change even for the others. Also, Arnd