From: Arnd Bergmann <arnd@arndb.de>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Christoph Hellwig <hch@lst.de>,
Alex Williamson <alex.williamson@redhat.com>,
Arnd Bergmann <arnd@arndb.de>, Yishai Hadas <yishaih@nvidia.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Corbet <corbet@lwn.net>,
diana.craciun@oss.nxp.com, kwankhede@nvidia.com,
Eric Auger <eric.auger@redhat.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
linux-pci <linux-pci@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
kvm list <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
mgurtovoy@nvidia.com, maorg@nvidia.com, leonro@nvidia.com
Subject: Re: [PATCH 12/12] vfio/pci: Introduce vfio_pci_core.ko
Date: Wed, 28 Jul 2021 15:08:08 +0200 [thread overview]
Message-ID: <CAK8P3a21ah=+x29jycWZBoTGA1RzfYz4qar9usvCa_hU85k=7g@mail.gmail.com> (raw)
In-Reply-To: <20210728124755.GR1721383@nvidia.com>
On Wed, Jul 28, 2021 at 2:47 PM Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> On Wed, Jul 28, 2021 at 02:29:56PM +0200, Christoph Hellwig wrote:
>
> > So not really an issue here. VFIO_PCI_CORE really is underlying
> > infrastructure a user should not care about.
>
> So then we can write it like below? Unfortunately it deletes the nice
> menu structure that groups all the PCI drivers together like platform
> (and mdev in future). Not sure this loss is worth the backwards compat
I think you can get back some structure by adding a 'menu "VFIO PCI drivers"'
and 'endmenu' around it.
> @@ -17,6 +15,7 @@ config VFIO_PCI_INTX
>
> config VFIO_PCI
> tristate "Generic VFIO support for any PCI device"
> + select VFIO_PCI_CORE
> help
> Support for the generic PCI VFIO bus driver which can connect any
> PCI device to the VFIO framework.
> @@ -50,6 +49,7 @@ endif
> config MLX5_VFIO_PCI
> tristate "VFIO support for MLX5 PCI devices"
> depends on MLX5_CORE
> + select VFIO_PCI_CORE
> help
These two now have to get a 'depends on MMU' if they don't already inherit
that from elsewhere.
Arnd
next prev parent reply other threads:[~2021-07-28 13:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 16:15 [PATCH 00/12] Introduce vfio_pci_core subsystem Yishai Hadas
2021-07-21 16:15 ` [PATCH 01/12] vfio/pci: Rename vfio_pci.c to vfio_pci_core.c Yishai Hadas
2021-07-21 16:15 ` [PATCH 02/12] vfio/pci: Rename vfio_pci_private.h to vfio_pci_core.h Yishai Hadas
2021-07-21 16:16 ` [PATCH 03/12] vfio/pci: Rename vfio_pci_device to vfio_pci_core_device Yishai Hadas
2021-07-21 16:16 ` [PATCH 04/12] vfio/pci: Rename ops functions to fit core namings Yishai Hadas
2021-07-21 16:16 ` [PATCH 05/12] vfio/pci: Include vfio header in vfio_pci_core.h Yishai Hadas
2021-07-21 16:16 ` [PATCH 06/12] vfio/pci: Split the pci_driver code out of vfio_pci_core.c Yishai Hadas
2021-07-21 16:16 ` [PATCH 07/12] vfio/pci: Move igd initialization to vfio_pci.c Yishai Hadas
2021-07-21 16:16 ` [PATCH 08/12] vfio/pci: Move module parameters " Yishai Hadas
2021-07-21 16:16 ` [PATCH 09/12] PCI: Add a PCI_ID_F_VFIO_DRIVER_OVERRIDE flag to struct pci_device_id Yishai Hadas
2021-07-27 16:34 ` Alex Williamson
2021-07-27 17:14 ` Jason Gunthorpe
2021-07-27 23:02 ` Alex Williamson
2021-07-27 23:42 ` Jason Gunthorpe
2021-08-04 20:34 ` Bjorn Helgaas
2021-08-05 16:47 ` Max Gurtovoy
2021-08-06 0:23 ` Jason Gunthorpe
2021-08-11 12:22 ` Max Gurtovoy
2021-08-11 19:07 ` Bjorn Helgaas
2021-08-12 13:27 ` Jason Gunthorpe
2021-08-12 15:57 ` Bjorn Helgaas
2021-08-12 19:51 ` Jason Gunthorpe
2021-08-12 20:26 ` Bjorn Helgaas
2021-08-12 23:21 ` Max Gurtovoy
2021-08-13 17:44 ` Bjorn Helgaas
2021-08-14 23:27 ` Max Gurtovoy
2021-08-16 17:21 ` Bjorn Helgaas
2021-08-17 13:01 ` Max Gurtovoy
2021-08-17 14:13 ` Bjorn Helgaas
2021-08-17 14:44 ` Max Gurtovoy
2021-08-12 15:42 ` Bjorn Helgaas
2021-07-21 16:16 ` [PATCH 10/12] vfio: Use select for eventfd Yishai Hadas
2021-07-21 16:16 ` [PATCH 11/12] vfio: Use kconfig if XX/endif blocks instead of repeating 'depends on' Yishai Hadas
2021-07-21 16:16 ` [PATCH 12/12] vfio/pci: Introduce vfio_pci_core.ko Yishai Hadas
2021-07-21 17:39 ` Leon Romanovsky
2021-07-22 9:06 ` Yishai Hadas
2021-07-22 9:22 ` Max Gurtovoy
2021-07-23 14:13 ` Leon Romanovsky
2021-07-25 10:45 ` Max Gurtovoy
2021-07-27 21:54 ` Alex Williamson
2021-07-27 23:09 ` Jason Gunthorpe
2021-07-28 4:56 ` Leon Romanovsky
2021-07-28 5:43 ` Christoph Hellwig
2021-07-28 7:04 ` Arnd Bergmann
2021-07-28 7:17 ` Leon Romanovsky
2021-07-28 12:03 ` Jason Gunthorpe
2021-07-28 12:12 ` Arnd Bergmann
2021-07-28 12:29 ` Christoph Hellwig
2021-07-28 12:47 ` Jason Gunthorpe
2021-07-28 12:55 ` Christoph Hellwig
2021-07-28 13:31 ` Jason Gunthorpe
2021-07-28 13:08 ` Arnd Bergmann [this message]
2021-07-28 17:26 ` Jason Gunthorpe
2021-08-04 13:41 ` [PATCH 00/12] Introduce vfio_pci_core subsystem Yishai Hadas
2021-08-04 15:27 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a21ah=+x29jycWZBoTGA1RzfYz4qar9usvCa_hU85k=7g@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=diana.craciun@oss.nxp.com \
--cc=eric.auger@redhat.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=masahiroy@kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=michal.lkml@markovi.net \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).