From: Sinan Kaya <Okaya@kernel.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] drm: Require PCI for selecting VGA_ARB.
Date: Tue, 8 Jan 2019 11:07:00 -0500 [thread overview]
Message-ID: <CAK9iUCMNC2SdEwmQjqmzKD5d3ats9ZcW4wqbi6jHb6U=aExu4w@mail.gmail.com> (raw)
In-Reply-To: <9af7993d-9d61-6488-3c97-a4126ffed07c@molgen.mpg.de>
On 1/8/19, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> Dear Maarten,
>
>
> Thank you very much for the quick response.
>
> On 01/08/19 16:37, Maarten Lankhorst wrote:
>> Op 08-01-2019 om 16:07 schreef Paul Menzel:
>
>>> Building Linux 5.0-rc1 fails with the errors below. Please find the
>>> configuration file attached.
>>>
>>> ```
>>> $ make -j120
>>> […]
>>> drivers/gpu/vga/vgaarb.c: In function ‘__vga_tryget’:
>>> drivers/gpu/vga/vgaarb.c:286:14: error: ‘PCI_VGA_STATE_CHANGE_DECODES’
>>> undeclared (first use in this function); did you mean
>>> ‘PCI_SUBTRACTIVE_DECODE’?
>>> flags |= PCI_VGA_STATE_CHANGE_DECODES;
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> PCI_SUBTRACTIVE_DECODE
>>> drivers/gpu/vga/vgaarb.c:286:14: note: each undeclared identifier is
>>> reported only once for each function it appears in
>>> CC [M] net/netfilter/xt_realm.o
>>> CC drivers/hid/hid-cherry.o
>>> drivers/gpu/vga/vga_switcheroo.c: In function
>>> ‘vga_switcheroo_runtime_suspend’:
>>> drivers/gpu/vga/vga_switcheroo.c:1053:2: error: implicit declaration of
>>> function ‘pci_bus_set_current_state’; did you mean ‘__set_current_state’?
>>> [-Werror=implicit-function-declaration]
>>> pci_bus_set_current_state(pdev->bus, PCI_D3cold);
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~
>>> __set_current_state
>>> drivers/gpu/vga/vgaarb.c:291:13: error: ‘PCI_VGA_STATE_CHANGE_BRIDGE’
>>> undeclared (first use in this function); did you mean
>>> ‘PCI_VGA_STATE_CHANGE_DECODES’?
>>> flags |= PCI_VGA_STATE_CHANGE_BRIDGE;
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> PCI_VGA_STATE_CHANGE_DECODES
>>> CC fs/reiserfs/dir.o
>>> LD [M] net/tipc/tipc.o
>>> drivers/gpu/vga/vga_switcheroo.c: In function
>>> ‘vga_switcheroo_runtime_resume’:
>>> drivers/gpu/vga/vga_switcheroo.c:1067:2: error: implicit declaration of
>>> function ‘pci_wakeup_bus’; did you mean ‘__wake_up_bit’?
>>> [-Werror=implicit-function-declaration]
>>> pci_wakeup_bus(pdev->bus);
>>> ^~~~~~~~~~~~~~
>>> __wake_up_bit
>>> drivers/gpu/vga/vgaarb.c:293:3: error: implicit declaration of function
>>> ‘pci_set_vga_state’; did you mean ‘pci_set_power_state’?
>>> [-Werror=implicit-function-declaration]
>>> pci_set_vga_state(conflict->pdev, false, pci_bits, flags);
>>> ^~~~~~~~~~~~~~~~~
>>> pci_set_power_state
>>> CC fs/read_write.o
>>> CC drivers/hid/hid-chicony.o
>>> CC drivers/hid/hid-cypress.o
>>> drivers/gpu/vga/vgaarb.c: In function ‘vga_arb_device_init’:
>>> drivers/gpu/vga/vgaarb.c:1495:25: error: ‘pci_bus_type’ undeclared (first
>>> use in this function); did you mean ‘pci_pcie_type’?
>>> bus_register_notifier(&pci_bus_type, &pci_notifier);
>>> ^~~~~~~~~~~~
>>> pci_pcie_type
>>> cc1: some warnings being treated as errors
>>> make[3]: *** [scripts/Makefile.build:277: drivers/gpu/vga/vgaarb.o] Error
>>> 1
>>> make[3]: *** Waiting for unfinished jobs....
>>> […]
>>> ```
>
>> WARNING: unmet direct dependencies detected for VGA_ARB
>> Depends on [n]: HAS_IOMEM [=y] && PCI [=n] && !S390
>> Selected by [y]:
>> - VGA_SWITCHEROO [=y] && HAS_IOMEM [=y] && X86 [=y] && ACPI [=y]
>>
>> So I guess you need to enable PCI, probably not a common config you're
>> using. :)
>>
>> Especially since you selected EXPERT.
>
> We have the attached defconfig, which is then integrated using
> `make olddefconfig`.
>
>> Oh well, apply this with git am --scissors?
>> -----8<----
>> When configuring the kernel without PCI we can still enable VGA
>> switcheroo,
>> which is not possible because VGA_ARB cannot be selected.
>>
>> Remove this by depending on PCI for !S390.
>>
>> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
>> index b677e5d524e6..ef5671475870 100644
>> --- a/drivers/gpu/vga/Kconfig
>> +++ b/drivers/gpu/vga/Kconfig
>> @@ -21,6 +21,7 @@ config VGA_SWITCHEROO
>> bool "Laptop Hybrid Graphics - GPU switching support"
>> depends on X86
>> depends on ACPI
>> + depends on (PCI && !S390) # For VGA_ARB
>> select VGA_ARB
>> help
>> Many laptops released in 2008/9/10 have two GPUs with a multiplexer
>
> Is this an effect of commit eb01d42a (PCI: consolidate PCI config entry in
> drivers/pci) as the `default y` is missing now?
>
See this :
https://patchwork.kernel.org/patch/10749209/
This change is about to go in.
>
> Kind regards,
>
> Paul
>
prev parent reply other threads:[~2019-01-08 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3a1c95bb-9986-663d-09a1-8c7e84d0a7a7@molgen.mpg.de>
[not found] ` <6ba074cd-bd1b-3844-8a3b-b0cfb34e24bc@linux.intel.com>
2019-01-08 15:56 ` [PATCH] drm: Require PCI for selecting VGA_ARB Paul Menzel
2019-01-08 16:07 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK9iUCMNC2SdEwmQjqmzKD5d3ats9ZcW4wqbi6jHb6U=aExu4w@mail.gmail.com' \
--to=okaya@kernel.org \
--cc=airlied@linux.ie \
--cc=bhelgaas@google.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=pmenzel@molgen.mpg.de \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).