Mobiveil legacy IRQ binding erroneous interrupt-map

Mobiveil legacy IRQ binding erroneous interrupt-map

[Lorenzo Pieralisi]

Hi Hou, Karthikeyan,

I have just noticed the mobiveil interrupt-map DT bindings example
is wrong:

This:

interrupt-map = <0 0 0 0 &pci_express 0>,
		<0 0 0 1 &pci_express 1>,
		<0 0 0 2 &pci_express 2>,
		<0 0 0 3 &pci_express 3>;

should be:

interrupt-map = <0 0 0 1 &pci_express 0>,
		<0 0 0 2 &pci_express 1>,
		<0 0 0 3 &pci_express 2>,
		<0 0 0 4 &pci_express 3>;

Legacy IRQs Interrupt pins map this way:

{{1, INTA}, {2, INTB}, {3,INTC}, {4,INTD}}

(as read from Interrupt pin register in the config space header) (ie
refer to PCI local bus specification 3.0), please fix it as soon as
possible.

Lorenzo

RE: Mobiveil legacy IRQ binding erroneous interrupt-map

[Z.q. Hou]

Hi Lorenzo,

The Mobiveil INTx controller is not used on NXP's platform, so I cannot verify this feature. 

Karthikeyan, please have a look on this issue.

Thanks,
Zhiqiang

> -----Original Message-----
> From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Sent: 2019年10月16日 18:32
> To: Z.q. Hou <zhiqiang.hou@nxp.com>; Karthikeyan Mitran
> <m.karthikeyan@mobiveil.co.in>
> Cc: linux-pci@vger.kernel.org
> Subject: Mobiveil legacy IRQ binding erroneous interrupt-map
> 
> Hi Hou, Karthikeyan,
> 
> I have just noticed the mobiveil interrupt-map DT bindings example is wrong:
> 
> This:
> 
> interrupt-map = <0 0 0 0 &pci_express 0>,
> 		<0 0 0 1 &pci_express 1>,
> 		<0 0 0 2 &pci_express 2>,
> 		<0 0 0 3 &pci_express 3>;
> 
> should be:
> 
> interrupt-map = <0 0 0 1 &pci_express 0>,
> 		<0 0 0 2 &pci_express 1>,
> 		<0 0 0 3 &pci_express 2>,
> 		<0 0 0 4 &pci_express 3>;
> 
> Legacy IRQs Interrupt pins map this way:
> 
> {{1, INTA}, {2, INTB}, {3,INTC}, {4,INTD}}
> 
> (as read from Interrupt pin register in the config space header) (ie refer to
> PCI local bus specification 3.0), please fix it as soon as possible.
> 
> Lorenzo

Re: Mobiveil legacy IRQ binding erroneous interrupt-map

[Karthikeyan Mitran]

Hi  Lorenzo, Zhiqiang,
        Thanks, will check and fix.

On Tue, Oct 29, 2019 at 5:08 PM Z.q. Hou <zhiqiang.hou@nxp.com> wrote:
>
> Hi Lorenzo,
>
> The Mobiveil INTx controller is not used on NXP's platform, so I cannot verify this feature.
>
> Karthikeyan, please have a look on this issue.
>
> Thanks,
> Zhiqiang
>
> > -----Original Message-----
> > From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > Sent: 2019年10月16日 18:32
> > To: Z.q. Hou <zhiqiang.hou@nxp.com>; Karthikeyan Mitran
> > <m.karthikeyan@mobiveil.co.in>
> > Cc: linux-pci@vger.kernel.org
> > Subject: Mobiveil legacy IRQ binding erroneous interrupt-map
> >
> > Hi Hou, Karthikeyan,
> >
> > I have just noticed the mobiveil interrupt-map DT bindings example is wrong:
> >
> > This:
> >
> > interrupt-map = <0 0 0 0 &pci_express 0>,
> >               <0 0 0 1 &pci_express 1>,
> >               <0 0 0 2 &pci_express 2>,
> >               <0 0 0 3 &pci_express 3>;
> >
> > should be:
> >
> > interrupt-map = <0 0 0 1 &pci_express 0>,
> >               <0 0 0 2 &pci_express 1>,
> >               <0 0 0 3 &pci_express 2>,
> >               <0 0 0 4 &pci_express 3>;
> >
> > Legacy IRQs Interrupt pins map this way:
> >
> > {{1, INTA}, {2, INTB}, {3,INTC}, {4,INTD}}
> >
> > (as read from Interrupt pin register in the config space header) (ie refer to
> > PCI local bus specification 3.0), please fix it as soon as possible.
> >
> > Lorenzo



-- 
Thanks,
Regards,
Karthikeyan Mitran

-- 
Mobiveil INC., CONFIDENTIALITY NOTICE: This e-mail message, including any 
attachments, is for the sole use of the intended recipient(s) and may 
contain proprietary confidential or privileged information or otherwise be 
protected by law. Any unauthorized review, use, disclosure or distribution 
is prohibited. If you are not the intended recipient, please notify the 
sender and destroy all copies and the original message.