linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [pci:pci/edr 4/10] drivers/pci/pcie/err.c:168:28: error: use of undeclared identifier 'service'
@ 2020-03-28 18:09 kbuild test robot
  2020-03-28 18:23 ` Bjorn Helgaas
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2020-03-28 18:09 UTC (permalink / raw)
  To: Kuppuswamy Sathyanarayanan
  Cc: kbuild-all, clang-built-linux, linux-pci, Bjorn Helgaas

[-- Attachment #1: Type: text/plain, Size: 3460 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/edr
head:   3a4c9f97543f0dbf580dd3646164e829ba08e600
commit: d9dbf5828770b236fcae3cc866d844fe360174d0 [4/10] PCI/ERR: Remove service dependency in pcie_do_recovery()
config: x86_64-defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 0fca766458da04bbc6d33b3f9ecd57e615c556c1)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout d9dbf5828770b236fcae3cc866d844fe360174d0
        # save the attached .config to linux build tree
        COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/pci/pcie/err.c:168:28: error: use of undeclared identifier 'service'
                   status = reset_link(dev, service);
                                            ^
   1 error generated.

vim +/service +168 drivers/pci/pcie/err.c

2e28bc84cf6eec Oza Pawandeep              2018-05-17  148  
d9dbf5828770b2 Kuppuswamy Sathyanarayanan 2020-03-23  149  void pcie_do_recovery(struct pci_dev *dev,
d9dbf5828770b2 Kuppuswamy Sathyanarayanan 2020-03-23  150  		      enum pci_channel_state state,
d9dbf5828770b2 Kuppuswamy Sathyanarayanan 2020-03-23  151  		      pci_ers_result_t (*reset_link)(struct pci_dev *pdev))
2e28bc84cf6eec Oza Pawandeep              2018-05-17  152  {
542aeb9c8f930e Keith Busch                2018-09-20  153  	pci_ers_result_t status = PCI_ERS_RESULT_CAN_RECOVER;
542aeb9c8f930e Keith Busch                2018-09-20  154  	struct pci_bus *bus;
2e28bc84cf6eec Oza Pawandeep              2018-05-17  155  
bfcb79fca19d26 Keith Busch                2018-09-20  156  	/*
bfcb79fca19d26 Keith Busch                2018-09-20  157  	 * Error recovery runs on all subordinates of the first downstream port.
bfcb79fca19d26 Keith Busch                2018-09-20  158  	 * If the downstream port detected the error, it is cleared at the end.
bfcb79fca19d26 Keith Busch                2018-09-20  159  	 */
bfcb79fca19d26 Keith Busch                2018-09-20  160  	if (!(pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT ||
bfcb79fca19d26 Keith Busch                2018-09-20  161  	      pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM))
bfcb79fca19d26 Keith Busch                2018-09-20  162  		dev = dev->bus->self;
542aeb9c8f930e Keith Busch                2018-09-20  163  	bus = dev->subordinate;
bfcb79fca19d26 Keith Busch                2018-09-20  164  
542aeb9c8f930e Keith Busch                2018-09-20  165  	pci_dbg(dev, "broadcast error_detected message\n");
b5dfbeacf74865 Kuppuswamy Sathyanarayanan 2020-03-27  166  	if (state == pci_channel_io_frozen) {
542aeb9c8f930e Keith Busch                2018-09-20  167  		pci_walk_bus(bus, report_frozen_detected, &status);
6d2c89441571ea Kuppuswamy Sathyanarayanan 2020-03-23 @168  		status = reset_link(dev, service);

:::::: The code at line 168 was first introduced by commit
:::::: 6d2c89441571ea534d6240f7724f518936c44f8d PCI/ERR: Update error status after reset_link()

:::::: TO: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
:::::: CC: Bjorn Helgaas <bhelgaas@google.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29218 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [pci:pci/edr 4/10] drivers/pci/pcie/err.c:168:28: error: use of undeclared identifier 'service'
  2020-03-28 18:09 [pci:pci/edr 4/10] drivers/pci/pcie/err.c:168:28: error: use of undeclared identifier 'service' kbuild test robot
@ 2020-03-28 18:23 ` Bjorn Helgaas
  2020-03-30 16:51   ` Nick Desaulniers
  0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2020-03-28 18:23 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Kuppuswamy Sathyanarayanan, kbuild-all, clang-built-linux, linux-pci

On Sun, Mar 29, 2020 at 02:09:30AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/edr
> head:   3a4c9f97543f0dbf580dd3646164e829ba08e600
> commit: d9dbf5828770b236fcae3cc866d844fe360174d0 [4/10] PCI/ERR: Remove service dependency in pcie_do_recovery()
> config: x86_64-defconfig (attached as .config)
> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 0fca766458da04bbc6d33b3f9ecd57e615c556c1)
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout d9dbf5828770b236fcae3cc866d844fe360174d0
>         # save the attached .config to linux build tree
>         COMPILER=clang make.cross ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/pci/pcie/err.c:168:28: error: use of undeclared identifier 'service'
>                    status = reset_link(dev, service);

My merge error, sorry.  This is on a test branch (pci/edr), not in my
-next branch yet.

>                                             ^
>    1 error generated.
> 
> vim +/service +168 drivers/pci/pcie/err.c
> 
> 2e28bc84cf6eec Oza Pawandeep              2018-05-17  148  
> d9dbf5828770b2 Kuppuswamy Sathyanarayanan 2020-03-23  149  void pcie_do_recovery(struct pci_dev *dev,
> d9dbf5828770b2 Kuppuswamy Sathyanarayanan 2020-03-23  150  		      enum pci_channel_state state,
> d9dbf5828770b2 Kuppuswamy Sathyanarayanan 2020-03-23  151  		      pci_ers_result_t (*reset_link)(struct pci_dev *pdev))
> 2e28bc84cf6eec Oza Pawandeep              2018-05-17  152  {
> 542aeb9c8f930e Keith Busch                2018-09-20  153  	pci_ers_result_t status = PCI_ERS_RESULT_CAN_RECOVER;
> 542aeb9c8f930e Keith Busch                2018-09-20  154  	struct pci_bus *bus;
> 2e28bc84cf6eec Oza Pawandeep              2018-05-17  155  
> bfcb79fca19d26 Keith Busch                2018-09-20  156  	/*
> bfcb79fca19d26 Keith Busch                2018-09-20  157  	 * Error recovery runs on all subordinates of the first downstream port.
> bfcb79fca19d26 Keith Busch                2018-09-20  158  	 * If the downstream port detected the error, it is cleared at the end.
> bfcb79fca19d26 Keith Busch                2018-09-20  159  	 */
> bfcb79fca19d26 Keith Busch                2018-09-20  160  	if (!(pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT ||
> bfcb79fca19d26 Keith Busch                2018-09-20  161  	      pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM))
> bfcb79fca19d26 Keith Busch                2018-09-20  162  		dev = dev->bus->self;
> 542aeb9c8f930e Keith Busch                2018-09-20  163  	bus = dev->subordinate;
> bfcb79fca19d26 Keith Busch                2018-09-20  164  
> 542aeb9c8f930e Keith Busch                2018-09-20  165  	pci_dbg(dev, "broadcast error_detected message\n");
> b5dfbeacf74865 Kuppuswamy Sathyanarayanan 2020-03-27  166  	if (state == pci_channel_io_frozen) {
> 542aeb9c8f930e Keith Busch                2018-09-20  167  		pci_walk_bus(bus, report_frozen_detected, &status);
> 6d2c89441571ea Kuppuswamy Sathyanarayanan 2020-03-23 @168  		status = reset_link(dev, service);
> 
> :::::: The code at line 168 was first introduced by commit
> :::::: 6d2c89441571ea534d6240f7724f518936c44f8d PCI/ERR: Update error status after reset_link()
> 
> :::::: TO: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> :::::: CC: Bjorn Helgaas <bhelgaas@google.com>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org



^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [pci:pci/edr 4/10] drivers/pci/pcie/err.c:168:28: error: use of undeclared identifier 'service'
  2020-03-28 18:23 ` Bjorn Helgaas
@ 2020-03-30 16:51   ` Nick Desaulniers
  0 siblings, 0 replies; 3+ messages in thread
From: Nick Desaulniers @ 2020-03-30 16:51 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: kbuild test robot, Kuppuswamy Sathyanarayanan, kbuild-all,
	clang-built-linux, linux-pci

On Sat, Mar 28, 2020 at 11:23 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Sun, Mar 29, 2020 at 02:09:30AM +0800, kbuild test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/edr
> > head:   3a4c9f97543f0dbf580dd3646164e829ba08e600
> > commit: d9dbf5828770b236fcae3cc866d844fe360174d0 [4/10] PCI/ERR: Remove service dependency in pcie_do_recovery()
> > config: x86_64-defconfig (attached as .config)
> > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 0fca766458da04bbc6d33b3f9ecd57e615c556c1)
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout d9dbf5828770b236fcae3cc866d844fe360174d0
> >         # save the attached .config to linux build tree
> >         COMPILER=clang make.cross ARCH=x86_64
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > >> drivers/pci/pcie/err.c:168:28: error: use of undeclared identifier 'service'
> >                    status = reset_link(dev, service);
>
> My merge error, sorry.  This is on a test branch (pci/edr), not in my
> -next branch yet.

FWIW: https://github.com/intel/lkp-tests/wiki/LKP-FAQ#is-there-a-way-not-to-trigger-kbuild-tests-on-a-specific-branch

>
> >                                             ^
> >    1 error generated.
> >
> > vim +/service +168 drivers/pci/pcie/err.c
> >
> > 2e28bc84cf6eec Oza Pawandeep              2018-05-17  148
> > d9dbf5828770b2 Kuppuswamy Sathyanarayanan 2020-03-23  149  void pcie_do_recovery(struct pci_dev *dev,
> > d9dbf5828770b2 Kuppuswamy Sathyanarayanan 2020-03-23  150                   enum pci_channel_state state,
> > d9dbf5828770b2 Kuppuswamy Sathyanarayanan 2020-03-23  151                   pci_ers_result_t (*reset_link)(struct pci_dev *pdev))
> > 2e28bc84cf6eec Oza Pawandeep              2018-05-17  152  {
> > 542aeb9c8f930e Keith Busch                2018-09-20  153     pci_ers_result_t status = PCI_ERS_RESULT_CAN_RECOVER;
> > 542aeb9c8f930e Keith Busch                2018-09-20  154     struct pci_bus *bus;
> > 2e28bc84cf6eec Oza Pawandeep              2018-05-17  155
> > bfcb79fca19d26 Keith Busch                2018-09-20  156     /*
> > bfcb79fca19d26 Keith Busch                2018-09-20  157      * Error recovery runs on all subordinates of the first downstream port.
> > bfcb79fca19d26 Keith Busch                2018-09-20  158      * If the downstream port detected the error, it is cleared at the end.
> > bfcb79fca19d26 Keith Busch                2018-09-20  159      */
> > bfcb79fca19d26 Keith Busch                2018-09-20  160     if (!(pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT ||
> > bfcb79fca19d26 Keith Busch                2018-09-20  161           pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM))
> > bfcb79fca19d26 Keith Busch                2018-09-20  162             dev = dev->bus->self;
> > 542aeb9c8f930e Keith Busch                2018-09-20  163     bus = dev->subordinate;
> > bfcb79fca19d26 Keith Busch                2018-09-20  164
> > 542aeb9c8f930e Keith Busch                2018-09-20  165     pci_dbg(dev, "broadcast error_detected message\n");
> > b5dfbeacf74865 Kuppuswamy Sathyanarayanan 2020-03-27  166     if (state == pci_channel_io_frozen) {
> > 542aeb9c8f930e Keith Busch                2018-09-20  167             pci_walk_bus(bus, report_frozen_detected, &status);
> > 6d2c89441571ea Kuppuswamy Sathyanarayanan 2020-03-23 @168             status = reset_link(dev, service);
> >
> > :::::: The code at line 168 was first introduced by commit
> > :::::: 6d2c89441571ea534d6240f7724f518936c44f8d PCI/ERR: Update error status after reset_link()
> >
> > :::::: TO: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> > :::::: CC: Bjorn Helgaas <bhelgaas@google.com>
> >
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200328182304.GA70832%40google.com.



-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-30 16:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-28 18:09 [pci:pci/edr 4/10] drivers/pci/pcie/err.c:168:28: error: use of undeclared identifier 'service' kbuild test robot
2020-03-28 18:23 ` Bjorn Helgaas
2020-03-30 16:51   ` Nick Desaulniers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).