Re: [PATCH V2] PCI: dwc: Add support to configure for ECRC

From: Rob Herring <robh@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Vidya Sagar <vidyas@nvidia.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"amurray@thegoodpenguin.co.uk" <amurray@thegoodpenguin.co.uk>,
	"treding@nvidia.com" <treding@nvidia.com>,
	"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kthota@nvidia.com" <kthota@nvidia.com>,
	"mmaddireddy@nvidia.com" <mmaddireddy@nvidia.com>,
	"sagar.tv@gmail.com" <sagar.tv@gmail.com>
Subject: Re: [PATCH V2] PCI: dwc: Add support to configure for ECRC
Date: Fri, 11 Dec 2020 11:17:53 -0600	[thread overview]
Message-ID: <CAL_Jsq+W9sgwAveYso=50UqdLevO=E=5ihi+7kAEjYMtq=Y7kQ@mail.gmail.com> (raw)
In-Reply-To: <20201211165440.GA80431@bjorn-Precision-5520>

On Fri, Dec 11, 2020 at 10:54 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Fri, Dec 11, 2020 at 08:49:16AM -0600, Rob Herring wrote:
> > On Fri, Dec 11, 2020 at 7:58 AM Vidya Sagar <vidyas@nvidia.com> wrote:
> > >
> > > Hi Lorenzo,
> > > Apologies to bug you, but wondering if you have any further comments on
> > > this patch that I need to take care of?
> >
> > You can check the status of your patches in Patchwork:
> >
> > https://patchwork.kernel.org/project/linux-pci/patch/20201111121145.7015-1-vidyas@nvidia.com/
> >
> > If it's in 'New' state and delegated to Lorenzo or Bjorn, it's in
> > their queue. You can shorten the queue by reviewing stuff in front of
> > you. :)
>
> Thanks for pointing this out, this is exactly right.  I *love* it when
> people help review things.  Obviously it saves me time, and often it
> raises questions I would have missed.

I can't take credit, this was actually someone's strategy for getting
their patches reviewed I heard about one time.

> Even "trivial" things like spelling, grammar, whitespace, subject line
> formats, etc. help because they are distractions to me and I will
> comment on them or spend time fixing them myself.  That doesn't mean
> "repost immediately after somebody points out a typo"; it means
> "collect feedback for a week or so, fix everything, *then* repost."
>
> This is an old but still relevant list of some of my OCD tendencies
> that take no special expertise to review for:
> https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/

It's been on my wish list for checkpatch.pl do something like: "Commit
subject should begin $(git log --oneline $files | cut -d':' -f-3 |
sort | uniq -c | sort -nr | head -1)". Or maybe a git commit template
to fill in subject prefix and Cc list. The hard part is of course all
the corner cases such as touching multiple directories/files.

Rob