linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout
@ 2020-09-21  7:49 Neil Armstrong
  2020-09-21 15:05 ` Kevin Hilman
  2020-09-22 17:30 ` Rob Herring
  0 siblings, 2 replies; 5+ messages in thread
From: Neil Armstrong @ 2020-09-21  7:49 UTC (permalink / raw)
  To: lorenzo.pieralisi, yue.wang, robh
  Cc: linux-pci, linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong

When establish link timeouts, probe fails but the error is unrelated since
the PCIe controller has been probed succesfully.

Align with most of the other dw-pcie drivers and ignore return of
dw_pcie_wait_for_link() in the host_init callback.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/pci/controller/dwc/pci-meson.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
index 33deb290c4e7..846275e68fbc 100644
--- a/drivers/pci/controller/dwc/pci-meson.c
+++ b/drivers/pci/controller/dwc/pci-meson.c
@@ -383,10 +383,7 @@ static int meson_pcie_host_init(struct pcie_port *pp)
 
 	pp->bridge->ops = &meson_pci_ops;
 
-	ret = meson_pcie_establish_link(mp);
-	if (ret)
-		return ret;
-
+	meson_pcie_establish_link(mp);
 	dw_pcie_msi_init(pp);
 
 	return 0;
-- 
2.22.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout
  2020-09-21  7:49 [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout Neil Armstrong
@ 2020-09-21 15:05 ` Kevin Hilman
  2020-09-22 17:30 ` Rob Herring
  1 sibling, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2020-09-21 15:05 UTC (permalink / raw)
  To: Neil Armstrong, lorenzo.pieralisi, yue.wang, robh
  Cc: linux-pci, linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong

Neil Armstrong <narmstrong@baylibre.com> writes:

> When establish link timeouts, probe fails but the error is unrelated since
> the PCIe controller has been probed succesfully.
>
> Align with most of the other dw-pcie drivers and ignore return of
> dw_pcie_wait_for_link() in the host_init callback.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Tested-by: Kevin Hilman <khilman@baylibre.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout
  2020-09-21  7:49 [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout Neil Armstrong
  2020-09-21 15:05 ` Kevin Hilman
@ 2020-09-22 17:30 ` Rob Herring
  2020-11-19 11:12   ` Lorenzo Pieralisi
  1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2020-09-22 17:30 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Lorenzo Pieralisi, Yue Wang, PCI, open list:ARM/Amlogic Meson...,
	linux-arm-kernel, linux-kernel

On Mon, Sep 21, 2020 at 1:50 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> When establish link timeouts, probe fails but the error is unrelated since
> the PCIe controller has been probed succesfully.
>
> Align with most of the other dw-pcie drivers and ignore return of
> dw_pcie_wait_for_link() in the host_init callback.

I think all, not most DWC drivers should be aligned. Plus the code
here is pretty much the same, so I'm working on moving all this to the
common DWC code. Drivers that need to bring up the link will need to
implement .start_link() (currently only used for EP mode). Most of the
time that is just setting the LTSSM bit which Synopsys thought letting
every vendor do their own register for was a good idea. Sigh.

Rob

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout
  2020-09-22 17:30 ` Rob Herring
@ 2020-11-19 11:12   ` Lorenzo Pieralisi
  2020-11-19 14:17     ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Lorenzo Pieralisi @ 2020-11-19 11:12 UTC (permalink / raw)
  To: Rob Herring
  Cc: Neil Armstrong, Yue Wang, PCI, open list:ARM/Amlogic Meson...,
	linux-arm-kernel, linux-kernel

On Tue, Sep 22, 2020 at 11:30:30AM -0600, Rob Herring wrote:
> On Mon, Sep 21, 2020 at 1:50 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >
> > When establish link timeouts, probe fails but the error is unrelated since
> > the PCIe controller has been probed succesfully.
> >
> > Align with most of the other dw-pcie drivers and ignore return of
> > dw_pcie_wait_for_link() in the host_init callback.
> 
> I think all, not most DWC drivers should be aligned. Plus the code
> here is pretty much the same, so I'm working on moving all this to the
> common DWC code. Drivers that need to bring up the link will need to
> implement .start_link() (currently only used for EP mode). Most of the
> time that is just setting the LTSSM bit which Synopsys thought letting
> every vendor do their own register for was a good idea. Sigh.

Should I drop this patch then ?

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout
  2020-11-19 11:12   ` Lorenzo Pieralisi
@ 2020-11-19 14:17     ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-11-19 14:17 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: Neil Armstrong, Yue Wang, PCI, open list:ARM/Amlogic Meson...,
	linux-arm-kernel, linux-kernel

On Thu, Nov 19, 2020 at 5:12 AM Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Tue, Sep 22, 2020 at 11:30:30AM -0600, Rob Herring wrote:
> > On Mon, Sep 21, 2020 at 1:50 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
> > >
> > > When establish link timeouts, probe fails but the error is unrelated since
> > > the PCIe controller has been probed succesfully.
> > >
> > > Align with most of the other dw-pcie drivers and ignore return of
> > > dw_pcie_wait_for_link() in the host_init callback.
> >
> > I think all, not most DWC drivers should be aligned. Plus the code
> > here is pretty much the same, so I'm working on moving all this to the
> > common DWC code. Drivers that need to bring up the link will need to
> > implement .start_link() (currently only used for EP mode). Most of the
> > time that is just setting the LTSSM bit which Synopsys thought letting
> > every vendor do their own register for was a good idea. Sigh.
>
> Should I drop this patch then ?

Yes, this is done by my series.

Rob

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-19 14:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21  7:49 [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout Neil Armstrong
2020-09-21 15:05 ` Kevin Hilman
2020-09-22 17:30 ` Rob Herring
2020-11-19 11:12   ` Lorenzo Pieralisi
2020-11-19 14:17     ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).