From: Rob Herring <robh@kernel.org>
To: Will McVicker <willmcvicker@google.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
kernel-team@android.com, "Vidya Sagar" <vidyas@nvidia.com>,
"Christoph Hellwig" <hch@infradead.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Isaac J . Manjarres" <isaacmanjarres@google.com>
Subject: Re: [PATCH v4 1/2] PCI: dwc: Drop dependency on ZONE_DMA32
Date: Fri, 12 Aug 2022 12:21:05 -0600 [thread overview]
Message-ID: <CAL_JsqLAP1kh7Hv6G08PuvpW8oRkXYasT=+6-VXAYg=fXfBvSA@mail.gmail.com> (raw)
In-Reply-To: <20220812000327.3154251-2-willmcvicker@google.com>
On Thu, Aug 11, 2022 at 6:03 PM Will McVicker <willmcvicker@google.com> wrote:
>
> Re-work the msi_msg DMA allocation logic to use dmam_alloc_coherent() which
> uses the coherent DMA mask to try to return an allocation within the DMA
> mask limits. With that, we now can drop the msi_page parameter in struct
> dw_pcie_rp. This allows kernel configurations that disable ZONE_DMA32 to
> continue supporting a 32-bit DMA mask. Without this patch, the PCIe host
> device will fail to probe when ZONE_DMA32 is disabled.
>
> Fixes: 35797e672ff0 ("PCI: dwc: Fix MSI msi_msg DMA mapping")
> Reported-by: Isaac J. Manjarres <isaacmanjarres@google.com>
> Signed-off-by: Will McVicker <willmcvicker@google.com>
> ---
> .../pci/controller/dwc/pcie-designware-host.c | 28 +++++--------------
> drivers/pci/controller/dwc/pcie-designware.h | 1 -
> 2 files changed, 7 insertions(+), 22 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-08-12 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 0:03 [PATCH v4 0/2] PCI: dwc: Add support for 64-bit MSI target addresses Will McVicker
2022-08-12 0:03 ` [PATCH v4 1/2] PCI: dwc: Drop dependency on ZONE_DMA32 Will McVicker
2022-08-12 2:47 ` Han Jingoo
2022-08-12 18:21 ` Rob Herring [this message]
2022-08-12 0:03 ` [PATCH v4 2/2] PCI: dwc: Add support for 64-bit MSI target address Will McVicker
2022-08-12 2:46 ` Han Jingoo
2022-08-23 11:27 ` Robin Murphy
2022-08-25 18:39 ` William McVicker
2022-08-23 10:01 ` [PATCH v4 0/2] PCI: dwc: Add support for 64-bit MSI target addresses Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLAP1kh7Hv6G08PuvpW8oRkXYasT=+6-VXAYg=fXfBvSA@mail.gmail.com' \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hch@infradead.org \
--cc=isaacmanjarres@google.com \
--cc=jingoohan1@gmail.com \
--cc=kernel-team@android.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=vidyas@nvidia.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).