linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Murray <amurray@thegoodpenguin.co.uk>,
	Dilip Kota <eswara.kota@linux.intel.com>,
	Vidya Sagar <vidyas@nvidia.com>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Alex Dewar <alex.dewar90@gmail.com>,
	PCI <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: dwc: exynos: add back MSI dependency
Date: Mon, 7 Dec 2020 08:23:46 -0600	[thread overview]
Message-ID: <CAL_JsqLCWK99AXzCWXpPsRxA+X5OKsHEGZtBhAsaVFhXoeRb9g@mail.gmail.com> (raw)
In-Reply-To: <20201204165841.3845589-1-arnd@kernel.org>

On Fri, Dec 4, 2020 at 10:58 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> While the exynos driver does not always need MSI, the generic
> deisgnware host code it uses fails to build without it:
>
> WARNING: unmet direct dependencies detected for PCIE_DW_HOST
>   Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
>   Selected by [y]:
>   - PCI_EXYNOS [=y] && PCI [=y] && (ARCH_EXYNOS [=n] || COMPILE_TEST [=y])
> drivers/pci/controller/dwc/pcie-designware-host.c:247:19: error: implicit declaration of function 'pci_msi_create_irq_domain' [-Werror,-Wimplicit-function-declaration]
>         pp->msi_domain = pci_msi_create_irq_domain(fwnode,
>                          ^
>
> Add back the dependency that all other designware controllers have.
>
> Fixes: f0a6743028f9 ("PCI: dwc: exynos: Rework the driver to support Exynos5433 variant")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/pci/controller/dwc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Seems like we should rework this to avoid select on options with
depends, but that's a separate change.

> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 020101b58155..e403bb2eeb4c 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP
>  config PCI_EXYNOS
>         tristate "Samsung Exynos PCIe controller"
>         depends on ARCH_EXYNOS || COMPILE_TEST
> +       depends on PCI && PCI_MSI_IRQ_DOMAIN

PCI isn't needed here.

>         select PCIE_DW_HOST
>         help
>           Enables support for the PCIe controller in the Samsung Exynos SoCs
> --
> 2.27.0
>

  reply	other threads:[~2020-12-07 14:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 16:58 [PATCH] PCI: dwc: exynos: add back MSI dependency Arnd Bergmann
2020-12-07 14:23 ` Rob Herring [this message]
2020-12-07 14:48   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqLCWK99AXzCWXpPsRxA+X5OKsHEGZtBhAsaVFhXoeRb9g@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=alex.dewar90@gmail.com \
    --cc=amurray@thegoodpenguin.co.uk \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=eswara.kota@linux.intel.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=jh80.chung@samsung.com \
    --cc=jingoohan1@gmail.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).