From: Julia Suvorova <jusual@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
kvm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] x86/PCI: Use MMCONFIG by default for KVM guests
Date: Sun, 26 Jul 2020 20:35:47 +0200 [thread overview]
Message-ID: <CAMDeoFX0oF3TSfzY8Yifd+9hBhdpKL40t8KFseBj2TsQYRYS8w@mail.gmail.com> (raw)
In-Reply-To: <87d04nq40h.fsf@vitty.brq.redhat.com>
On Wed, Jul 22, 2020 at 11:43 AM Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
> Julia Suvorova <jusual@redhat.com> writes:
>
> > Scanning for PCI devices at boot takes a long time for KVM guests. It
> > can be reduced if KVM will handle all configuration space accesses for
> > non-existent devices without going to userspace [1]. But for this to
> > work, all accesses must go through MMCONFIG.
> > This change allows to use pci_mmcfg as raw_pci_ops for 64-bit KVM
> > guests making MMCONFIG the default access method.
> >
> > [1] https://lkml.org/lkml/2020/5/14/936
> >
> > Signed-off-by: Julia Suvorova <jusual@redhat.com>
> > ---
> > arch/x86/pci/direct.c | 5 +++++
> > arch/x86/pci/mmconfig_64.c | 3 +++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/arch/x86/pci/direct.c b/arch/x86/pci/direct.c
> > index a51074c55982..8ff6b65d8f48 100644
> > --- a/arch/x86/pci/direct.c
> > +++ b/arch/x86/pci/direct.c
> > @@ -6,6 +6,7 @@
> > #include <linux/pci.h>
> > #include <linux/init.h>
> > #include <linux/dmi.h>
> > +#include <linux/kvm_para.h>
> > #include <asm/pci_x86.h>
> >
> > /*
> > @@ -264,6 +265,10 @@ void __init pci_direct_init(int type)
> > {
> > if (type == 0)
> > return;
> > +
> > + if (raw_pci_ext_ops && kvm_para_available())
> > + return;
> > +
> > printk(KERN_INFO "PCI: Using configuration type %d for base access\n",
> > type);
> > if (type == 1) {
> > diff --git a/arch/x86/pci/mmconfig_64.c b/arch/x86/pci/mmconfig_64.c
> > index 0c7b6e66c644..9eb772821766 100644
> > --- a/arch/x86/pci/mmconfig_64.c
> > +++ b/arch/x86/pci/mmconfig_64.c
> > @@ -10,6 +10,7 @@
> > #include <linux/init.h>
> > #include <linux/acpi.h>
> > #include <linux/bitmap.h>
> > +#include <linux/kvm_para.h>
> > #include <linux/rcupdate.h>
> > #include <asm/e820/api.h>
> > #include <asm/pci_x86.h>
> > @@ -122,6 +123,8 @@ int __init pci_mmcfg_arch_init(void)
> > }
> >
> > raw_pci_ext_ops = &pci_mmcfg;
> > + if (kvm_para_available())
> > + raw_pci_ops = &pci_mmcfg;
> >
> > return 1;
> > }
>
> This implies mmconfig access method is always functional (when present)
> for all KVM guests, regardless of hypervisor version/which KVM userspace
> is is use/... In case the assumption is true the patch looks good (to
> me) but in case it isn't or if we think that more control over this
> is needed we may want to introduce a PV feature bit for KVM.
Ok, I'll introduce a feature bit and turn it on in QEMU.
> Also, I'm thinking about moving this to arch/x86/kernel/kvm.c: we can
> override x86_init.pci.arch_init and reassign raw_pci_ops after doing
> pci_arch_init().
This might be a good idea.
Best regards, Julia Suvorova.
next prev parent reply other threads:[~2020-07-26 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 0:15 [PATCH] x86/PCI: Use MMCONFIG by default for KVM guests Julia Suvorova
2020-07-22 2:59 ` Matthew Wilcox
2020-07-22 9:43 ` Vitaly Kuznetsov
2020-07-26 18:35 ` Julia Suvorova [this message]
2020-07-27 14:04 ` Andy Shevchenko
2020-07-27 15:55 ` Vitaly Kuznetsov
2020-07-22 10:59 ` Michael S. Tsirkin
2020-07-22 23:19 ` Bjorn Helgaas
2020-07-26 18:58 ` Julia Suvorova
2020-07-29 14:43 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMDeoFX0oF3TSfzY8Yifd+9hBhdpKL40t8KFseBj2TsQYRYS8w@mail.gmail.com \
--to=jusual@redhat.com \
--cc=bhelgaas@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
--cc=vkuznets@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).