From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0967C2B9F8 for ; Tue, 25 May 2021 15:34:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9753160FDA for ; Tue, 25 May 2021 15:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233088AbhEYPf6 (ORCPT ); Tue, 25 May 2021 11:35:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231685AbhEYPf5 (ORCPT ); Tue, 25 May 2021 11:35:57 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01D9EC061574; Tue, 25 May 2021 08:34:27 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id w1so32306760ybt.1; Tue, 25 May 2021 08:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aODKBE+Cq4Ej3+lFHiAOTGTOnmOnlJy4H40XMHpugWc=; b=g9Bm3ook4Am07wM+5x6CmI0daxzMT/woBN4vcpUDAmqSP6LsPvE5/9O02BczC1IysZ RYXE/K11j4lvagxtyZTo3OTFpNpOYMzV7clFeUtBNzipon3gI0h4+ZfFkAjwzZKP8Qxy fLjSRv/Hhu5Grtb8zoubZ3r/P174D3ezE4eQmK5NZetxmAJV4zR01YhKYpPY6MMfhbat BtSM2DmhelQoWQ0Wp7rutBGTjSMrB97KotDLDaXgfDgT1hPvzIV+DL/qeH89H2JDbDz/ ZV1+q1TmuvuPkZzSgoVqNpMu31fZXkekfOl9C/Q7tvyqEWzt32MENkJ7mvLCMZnSKYyv 91KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aODKBE+Cq4Ej3+lFHiAOTGTOnmOnlJy4H40XMHpugWc=; b=JiJ9iMJBhrQX0rQavmoB6t3mu8eJy1Y4O9Pr85aIf9r6DRkUdxEh3M6b9AEVRbeHgb ikaQCe4G0QKN+AsaOErJsaO1bTaYRKb3yenIclWJoYz0ia9c+FZfCqqTRTN3MOW7o9rq 5r3VUP2ITEceYFYYmazrhE/8Sx6WjaHtJ6gLtU+IMUxhrYxTjqfZqlUd3SDThs2EBrLr gkwKujb7xSSsKlTJPTnNYysOMWMjDhQ8L5AVfRxRyTUAVwGSt0FtnlGxXilR816lQlNn Uuvo+s5Vy4h5XeP0tnxds0oGqvJnsmtw1JAAWaOJzk1dFxatWNKVtKZB4ZjcI+3UX53/ /yUA== X-Gm-Message-State: AOAM531vG731w4iSym4/4DvenlkF3ASwAu2EFpBTRdiVsCrb7Q05stpj 79TGkAavvxHApNWBhylib03qSO4kpNjzbgpQAKSjLlz4QpvPutRk X-Google-Smtp-Source: ABdhPJxfULOngYA5w9GOEBkQYhlCFvmVYdQDG19noJbb13IlslssEdudnTR9blksqrM+zSQBD5JSJrY88oC3awQAR0g= X-Received: by 2002:a25:cd85:: with SMTP id d127mr43499273ybf.259.1621956865471; Tue, 25 May 2021 08:34:25 -0700 (PDT) MIME-Version: 1.0 References: <7a1e2ebc-f7d8-8431-d844-41a9c36a8911@arm.com> <01efd004-1c50-25ca-05e4-7e4ef96232e2@arm.com> <87eedxbtkn.fsf@stealth> <877djnaq11.fsf@stealth> In-Reply-To: From: Peter Geis Date: Tue, 25 May 2021 11:34:14 -0400 Message-ID: Subject: Re: [BUG] rockpro64: PCI BAR reassignment broken by commit 9d57e61bf723 ("of/pci: Add IORESOURCE_MEM_64 to resource flags for 64-bit memory addresses") To: Ard Biesheuvel Cc: Punit Agrawal , Robin Murphy , Alexandru Elisei , Linux Kernel Mailing List , "open list:ARM/Rockchip SoC..." , arm-mail-list , Heiko Stuebner , Leonardo Bras , Rob Herring , PCI , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, May 25, 2021 at 9:57 AM Ard Biesheuvel wrote: > > On Tue, 25 May 2021 at 15:42, Punit Agrawal wrot= e: > > > > Hi Ard, > > > > Ard Biesheuvel writes: > > > > > On Sun, 23 May 2021 at 13:06, Punit Agrawal = wrote: > > >> > > >> Robin Murphy writes: > > >> > > >> > [ +linux-pci for visibility ] > > >> > > > >> > On 2021-05-18 10:09, Alexandru Elisei wrote: > > >> >> After doing a git bisect I was able to trace the following error = when booting my > > >> >> rockpro64 v2 (rk3399 SoC) with a PCIE NVME expansion card: > > >> >> [..] > > >> >> [ 0.305183] rockchip-pcie f8000000.pcie: host bridge /pcie@f80= 00000 ranges: > > >> >> [ 0.305248] rockchip-pcie f8000000.pcie: MEM 0x00fa000000= ..0x00fbdfffff -> > > >> >> 0x00fa000000 > > >> >> [ 0.305285] rockchip-pcie f8000000.pcie: IO 0x00fbe00000= ..0x00fbefffff -> > > >> >> 0x00fbe00000 > > >> >> [ 0.306201] rockchip-pcie f8000000.pcie: supply vpcie1v8 not f= ound, using dummy > > >> >> regulator > > >> >> [ 0.306334] rockchip-pcie f8000000.pcie: supply vpcie0v9 not f= ound, using dummy > > >> >> regulator > > >> >> [ 0.373705] rockchip-pcie f8000000.pcie: PCI host bridge to bu= s 0000:00 > > >> >> [ 0.373730] pci_bus 0000:00: root bus resource [bus 00-1f] > > >> >> [ 0.373751] pci_bus 0000:00: root bus resource [mem 0xfa000000= -0xfbdfffff 64bit] > > >> >> [ 0.373777] pci_bus 0000:00: root bus resource [io 0x0000-0xf= ffff] (bus > > >> >> address [0xfbe00000-0xfbefffff]) > > >> >> [ 0.373839] pci 0000:00:00.0: [1d87:0100] type 01 class 0x0604= 00 > > >> >> [ 0.373973] pci 0000:00:00.0: supports D1 > > >> >> [ 0.373992] pci 0000:00:00.0: PME# supported from D0 D1 D3hot > > >> >> [ 0.378518] pci 0000:00:00.0: bridge configuration invalid ([b= us 00-00]), > > >> >> reconfiguring > > >> >> [ 0.378765] pci 0000:01:00.0: [144d:a808] type 00 class 0x0108= 02 > > >> >> [ 0.378869] pci 0000:01:00.0: reg 0x10: [mem 0x00000000-0x0000= 3fff 64bit] > > >> >> [ 0.379051] pci 0000:01:00.0: Max Payload Size set to 256 (was= 128, max 256) > > >> >> [ 0.379661] pci 0000:01:00.0: 8.000 Gb/s available PCIe bandwi= dth, limited by > > >> >> 2.5 GT/s PCIe x4 link at 0000:00:00.0 (capable of 31.504 Gb/s wit= h 8.0 GT/s PCIe > > >> >> x4 link) > > >> >> [ 0.393269] pci_bus 0000:01: busn_res: [bus 01-1f] end is upda= ted to 01 > > >> >> [ 0.393311] pci 0000:00:00.0: BAR 14: no space for [mem size 0= x00100000] > > >> >> [ 0.393333] pci 0000:00:00.0: BAR 14: failed to assign [mem si= ze 0x00100000] > > >> >> [ 0.393356] pci 0000:01:00.0: BAR 0: no space for [mem size 0x= 00004000 64bit] > > >> >> [ 0.393375] pci 0000:01:00.0: BAR 0: failed to assign [mem siz= e 0x00004000 64bit] > > >> >> [ 0.393397] pci 0000:00:00.0: PCI bridge to [bus 01] > > >> >> [ 0.393839] pcieport 0000:00:00.0: PME: Signaling with IRQ 78 > > >> >> [ 0.394165] pcieport 0000:00:00.0: AER: enabled with IRQ 78 > > >> >> [..] > > >> >> to the commit 9d57e61bf723 ("of/pci: Add IORESOURCE_MEM_64 to > > >> >> resource flags for > > >> >> 64-bit memory addresses"). > > >> > > > >> > FWFW, my hunch is that the host bridge advertising no 32-bit memor= y > > >> > resource, only only a single 64-bit non-prefetchable one (even tho= ugh > > >> > it's entirely below 4GB) might be a bit weird and tripping somethi= ng > > >> > up in the resource assignment code. It certainly seems like the th= ing > > >> > most directly related to the offending commit. > > >> > > > >> > I'd be tempted to try fiddling with that in the DT (i.e. changing > > >> > 0x83000000 to 0x82000000 in the PCIe node's "ranges" property) to = see > > >> > if it makes any difference. Note that even if it helps, though, I > > >> > don't know whether that's the correct fix or just a bodge around a > > >> > corner-case bug somewhere in the resource code. > > >> > > >> From digging into this further the failure seems to be due to a mism= atch > > >> of flags when allocating resources in pci_bus_alloc_from_region() - > > >> > > >> if ((res->flags ^ r->flags) & type_mask) > > >> continue; > > >> > > >> Though I am also not sure why the failure is only being reported on > > >> RK3399 - does a single 64-bit window have anything to do with it? > > >> > > > > > > The NVMe in the example exposes a single 64-bit non-prefetchable BAR. > > > Such BARs can not be allocated in a prefetchable host bridge window > > > (unlike the converse, i.e., allocating a prefetchable BAR in a > > > non-prefetchable host bridge window is fine) > > > > > > 64-bit non-prefetchable host bridge windows cannot be forwarded by PC= I > > > to PCI bridges, they simply lack the BAR registers to describe them. > > > Therefore, non-prefetchable endpoint BARs (even 64-bit ones) need to > > > be carved out of a host bridge's non-prefetchable 32-bit window if > > > they need to pass through a bridge. > > > > Thank you for the explanation. I also looked at the PCI-to-PCI Bridge > > spec to understand where some of the limitations are coming from. > > > > > So the error seems to be here that the host bridge's 32-bit > > > non-prefetchable window has the 64-bit attribute set, even though it > > > resides below 4 GB entirely. I suppose that the resource allocation > > > could be made more forgiving (and it was in the past, before commit > > > 9d57e61bf723 was applied). However, I would strongly recommend not > > > deviating from common practice, and just describe the 32-bit > > > addressable non-prefetchable resource window as such. > > > > IIUC, the host bridge's configuration (64-bit on non-prefetchable > > window) is based on what the hardware advertises. > > > > What do you mean by 'what the hardware advertises'? The host bridge is > apparently configured to decode a 32-bit addressable window as MMIO, > and the question is why this window has the 64-bit attribute set in > the DT description. > > > Can you elaborate on what you have in mind to correct the > > non-prefetchable resource window? Are you thinking of adding a quirk > > somewhere to address this? > > > > No. Just fix the DT. Good Morning, I believe Robin is correct that there is more to this. While attempting to work out why dGPUs won't work with the rk356x series PCIe controllers, Christian K=C3=B6nig from the amd-gpu driver mailing list noticed the gpu was incorrectly allocated a 64bit non-prefetchable BAR which should instead be a 32 non-prefetchable BAR. The ranges currently set are: ranges =3D <0x81000000 0x0 0x00800000 0x3 0x00800000 0x0 0x00100000 0x82000000 0x0 0x00900000 0x3 0x00900000 0x0 0x3f700000>; but the final allocation was: lspci -v 00:00.0 PCI bridge: Fuzhou Rockchip Electronics Co., Ltd Device 3566 (rev 01) (prog-if 00 [Normal decode]) Flags: bus master, fast devsel, latency 0, IRQ 96 Bus: primary=3D00, secondary=3D01, subordinate=3Dff, sec-latency=3D= 0 I/O behind bridge: 00001000-00001fff [size=3D4K] Memory behind bridge: 00900000-009fffff [size=3D1M] Prefetchable memory behind bridge: 0000000010000000-000000001fffffff [size=3D256M] Expansion ROM at 300a00000 [virtual] [disabled] [size=3D64K] Capabilities: [40] Power Management version 3 Capabilities: [50] MSI: Enable+ Count=3D1/32 Maskable- 64bit+ Capabilities: [70] Express Root Port (Slot-), MSI 00 Capabilities: [b0] MSI-X: Enable- Count=3D1 Masked- Capabilities: [100] Advanced Error Reporting Capabilities: [148] Secondary PCI Express Capabilities: [160] L1 PM Substates Capabilities: [170] Vendor Specific Information: ID=3D0002 Rev=3D4 Len=3D100 Kernel driver in use: pcieport 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Turks PRO [Radeon HD 7570] (prog-if 00 [VGA controller]) Subsystem: Dell Turks PRO [Radeon HD 7570] Flags: bus master, fast devsel, latency 0, IRQ 95 Memory at 310000000 (64-bit, prefetchable) [size=3D256M] Memory at 300900000 (64-bit, non-prefetchable) [size=3D128K] I/O ports at 1000 [size=3D256] Expansion ROM at 300920000 [disabled] [size=3D128K] Capabilities: [50] Power Management version 3 Capabilities: [58] Express Legacy Endpoint, MSI 00 Capabilities: [a0] MSI: Enable- Count=3D1/1 Maskable- 64bit+ Capabilities: [100] Vendor Specific Information: ID=3D0001 Rev=3D1 Len=3D010 Capabilities: [150] Advanced Error Reporting Kernel driver in use: radeon 01:00.1 Audio device: Advanced Micro Devices, Inc. [AMD/ATI] Turks HDMI Audio [Radeon HD 6500/6600 / 6700M Series] Subsystem: Dell Turks HDMI Audio [Radeon HD 6500/6600 / 6700M Serie= s] Flags: bus master, fast devsel, latency 0, IRQ 98 Memory at 300940000 (64-bit, non-prefetchable) [size=3D16K] Capabilities: [50] Power Management version 3 Capabilities: [58] Express Legacy Endpoint, MSI 00 Capabilities: [a0] MSI: Enable+ Count=3D1/1 Maskable- 64bit+ Capabilities: [100] Vendor Specific Information: ID=3D0001 Rev=3D1 Len=3D010 Capabilities: [150] Advanced Error Reporting Kernel driver in use: snd_hda_intel This will obviously clobber registers during writes. Also, if <0x82000000> (32 bit) is changed to <0x83000000> (64 bit), most of the allocations for the dGPU fail due to no valid regions available. > > > I am happy to put something together once I understand the preferred wa= y > > to go about it. > > > > Thanks, > > Punit > > > > [...] > > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip