From: Peter Geis <pgwipeout@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Shawn Lin <shawn.lin@rock-chips.com>,
Simon Xue <xxm@rock-chips.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
PCI <linux-pci@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: pci: remove fallback from Rockchip DesignWare binding
Date: Fri, 15 Apr 2022 16:14:43 -0400 [thread overview]
Message-ID: <CAMdYzYpwKE3cCPZfDehnN0Lv1k7DstUh2y4PoEv6=6e6ejAtSQ@mail.gmail.com> (raw)
In-Reply-To: <Ylhfr51RME+YAjOG@robh.at.kernel.org>
On Thu, Apr 14, 2022 at 1:53 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Apr 13, 2022 at 09:37:28AM -0400, Peter Geis wrote:
> > The snps,dw-pcie binds to a standalone driver.
> > It is not fully compatible with the Rockchip implementation and causes a
> > hang if it binds to the device.
> >
> > Remove this binding as a valid fallback.
> >
> > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > ---
> > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> > index 142bbe577763..8dc11fed8a3c 100644
> > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> > @@ -32,7 +32,6 @@ properties:
> > compatible:
> > items:
> > - const: rockchip,rk3568-pcie
> > - - const: snps,dw-pcie
>
> With this, you no longer need 'select' so please drop it too.
Thanks! Will do.
>
> >
> > reg:
> > items:
> > @@ -110,7 +109,7 @@ examples:
> > #size-cells = <2>;
> >
> > pcie3x2: pcie@fe280000 {
> > - compatible = "rockchip,rk3568-pcie", "snps,dw-pcie";
> > + compatible = "rockchip,rk3568-pcie";
> > reg = <0x3 0xc0800000 0x0 0x390000>,
> > <0x0 0xfe280000 0x0 0x10000>,
> > <0x3 0x80000000 0x0 0x100000>;
> > --
> > 2.25.1
> >
> >
next prev parent reply other threads:[~2022-04-15 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 13:37 [PATCH v2 0/4] Enable rk356x PCIe controller Peter Geis
2022-04-13 13:37 ` [PATCH v2 1/4] dt-bindings: pci: remove fallback from Rockchip DesignWare binding Peter Geis
2022-04-14 17:53 ` Rob Herring
2022-04-15 20:14 ` Peter Geis [this message]
2022-04-13 13:37 ` [PATCH v2 2/4] PCI: dwc: rockchip: add legacy interrupt support Peter Geis
2022-04-14 20:36 ` Marc Zyngier
2022-04-15 20:07 ` Peter Geis
2022-04-13 13:37 ` [PATCH v2 3/4] arm64: dts: rockchip: add rk3568 pcie2x1 controller Peter Geis
2022-04-13 13:37 ` [PATCH v2 4/4] arm64: dts: rockchip: enable pcie controller on quartz64-a Peter Geis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMdYzYpwKE3cCPZfDehnN0Lv1k7DstUh2y4PoEv6=6e6ejAtSQ@mail.gmail.com' \
--to=pgwipeout@gmail.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).