From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Jianjun Wang <jianjun.wang@mediatek.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Abraham I <kishon@ti.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: PCI: Fix 'unevaluatedProperties' warnings
Date: Mon, 6 Dec 2021 20:52:42 +0100 [thread overview]
Message-ID: <CAMhs-H888q9FihfXkn=wdV8j2iRTnaXiXf=9onRxab8qHvFwcQ@mail.gmail.com> (raw)
In-Reply-To: <20211206194406.2469361-1-robh@kernel.org>
On Mon, Dec 6, 2021 at 8:44 PM Rob Herring <robh@kernel.org> wrote:
>
> With 'unevaluatedProperties' support implemented, there's several
> warnings due to undocumented properties:
>
> Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dt.yaml: pcie@1e140000: pcie@0,0: Unevaluated properties are not allowed ('phy-names' was unexpected)
> Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dt.yaml: pcie@1e140000: pcie@1,0: Unevaluated properties are not allowed ('phy-names' was unexpected)
> Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dt.yaml: pcie@1e140000: pcie@2,0: Unevaluated properties are not allowed ('phy-names' was unexpected)
> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.example.dt.yaml: pcie@11230000: Unevaluated properties are not allowed ('phy-names' was unexpected)
> Documentation/devicetree/bindings/pci/microchip,pcie-host.example.dt.yaml: pcie@2030000000: Unevaluated properties are not allowed ('interrupt-controller' was unexpected)
> Documentation/devicetree/bindings/pci/ti,am65-pci-ep.example.dt.yaml: pcie-ep@5500000: Unevaluated properties are not allowed ('num-ib-windows', 'num-ob-windows' were unexpected)
> Documentation/devicetree/bindings/pci/ti,am65-pci-host.example.dt.yaml: pcie@5500000: Unevaluated properties are not allowed ('num-viewport', 'interrupts' were unexpected)
> Documentation/devicetree/bindings/pci/ti,j721e-pci-host.example.dt.yaml: pcie@2900000: Unevaluated properties are not allowed ('dma-coherent' was unexpected)
>
> Add the necessary property definitions or remove the properties from the
> examples to fix these warnings.
>
> Cc: Ryder Lee <ryder.lee@mediatek.com>
> Cc: Jianjun Wang <jianjun.wang@mediatek.com>
> Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: Daire McNamara <daire.mcnamara@microchip.com>
> Cc: Abraham I <kishon@ti.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/pci/mediatek,mt7621-pcie.yaml | 3 +++
Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Thanks,
Sergio Paracuellos
> .../bindings/pci/mediatek-pcie-gen3.yaml | 4 ++++
> .../bindings/pci/microchip,pcie-host.yaml | 18 ++++++++++++++++++
> .../bindings/pci/ti,am65-pci-ep.yaml | 2 --
> .../bindings/pci/ti,am65-pci-host.yaml | 4 +++-
> .../bindings/pci/ti,j721e-pci-host.yaml | 2 ++
> 6 files changed, 30 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> index 044fa967bc8b..d60f43fd9c5a 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> @@ -45,6 +45,9 @@ patternProperties:
> phys:
> maxItems: 1
>
> + phy-names:
> + pattern: '^pcie-phy[0-2]$'
> +
> required:
> - "#interrupt-cells"
> - interrupt-map-mask
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 742206dbd965..0499b94627ae 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -95,6 +95,10 @@ properties:
> phys:
> maxItems: 1
>
> + phy-names:
> + items:
> + - const: pcie-phy
> +
> '#interrupt-cells':
> const: 1
>
> diff --git a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
> index 7b0776457178..edb4f81253c8 100644
> --- a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
> @@ -46,6 +46,24 @@ properties:
> msi-parent:
> description: MSI controller the device is capable of using.
>
> + interrupt-controller:
> + type: object
> + properties:
> + '#address-cells':
> + const: 0
> +
> + '#interrupt-cells':
> + const: 1
> +
> + interrupt-controller: true
> +
> + required:
> + - '#address-cells'
> + - '#interrupt-cells'
> + - interrupt-controller
> +
> + additionalProperties: false
> +
> required:
> - reg
> - reg-names
> diff --git a/Documentation/devicetree/bindings/pci/ti,am65-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,am65-pci-ep.yaml
> index 78c217d362a7..a6896cb40e83 100644
> --- a/Documentation/devicetree/bindings/pci/ti,am65-pci-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,am65-pci-ep.yaml
> @@ -66,8 +66,6 @@ examples:
> reg-names = "app", "dbics", "addr_space", "atu";
> power-domains = <&k3_pds 120 TI_SCI_PD_EXCLUSIVE>;
> ti,syscon-pcie-mode = <&pcie0_mode>;
> - num-ib-windows = <16>;
> - num-ob-windows = <16>;
> max-link-speed = <2>;
> dma-coherent;
> interrupts = <GIC_SPI 340 IRQ_TYPE_EDGE_RISING>;
> diff --git a/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
> index 834dc1c1743c..eabe1635e336 100644
> --- a/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
> @@ -29,6 +29,9 @@ properties:
> - const: config
> - const: atu
>
> + interrupts:
> + maxItems: 1
> +
> power-domains:
> maxItems: 1
>
> @@ -87,7 +90,6 @@ examples:
> ti,syscon-pcie-id = <&pcie_devid>;
> ti,syscon-pcie-mode = <&pcie0_mode>;
> bus-range = <0x0 0xff>;
> - num-viewport = <16>;
> max-link-speed = <2>;
> dma-coherent;
> interrupts = <GIC_SPI 340 IRQ_TYPE_EDGE_RISING>;
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index cc900202df29..2115d5a3f0e1 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -60,6 +60,8 @@ properties:
> - const: fck
> - const: pcie_refclk
>
> + dma-coherent: true
> +
> vendor-id:
> const: 0x104c
>
> --
> 2.32.0
>
next prev parent reply other threads:[~2021-12-06 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 19:44 [PATCH] dt-bindings: PCI: Fix 'unevaluatedProperties' warnings Rob Herring
2021-12-06 19:52 ` Sergio Paracuellos [this message]
2021-12-14 22:16 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMhs-H888q9FihfXkn=wdV8j2iRTnaXiXf=9onRxab8qHvFwcQ@mail.gmail.com' \
--to=sergio.paracuellos@gmail.com \
--cc=bhelgaas@google.com \
--cc=daire.mcnamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).