From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Yanteng Si <siyanteng01@gmail.com>
Cc: Yanteng Si <siyanteng@loongson.cn>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
kw@linux.com, Bjorn Helgaas <bhelgaas@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-pci <linux-pci@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"open list:MIPS" <linux-mips@vger.kernel.org>,
chenhuacai@kernel.org, sterlingteng@gmail.com
Subject: Re: [PATCH 1/2] PCI: mt7621: Add MODULE_* macros to MT7621 PCIe host controller driver
Date: Wed, 27 Oct 2021 13:59:58 +0200 [thread overview]
Message-ID: <CAMhs-H9MANfLThCC-m9Q5whAgRAbnzXjUpipQdnwRf0iqPwJuw@mail.gmail.com> (raw)
In-Reply-To: <50f5f509c15251fb10b0c87304d272e2c89841f0.1635333327.git.siyanteng@loongson.cn>
Hi,
On Wed, Oct 27, 2021 at 1:32 PM Yanteng Si <siyanteng01@gmail.com> wrote:
>
> Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver")
> the MT7621 PCIe host controller driver is built as a module but no MODULE_*() attributes
> were specified, causing a build error due to missing license information.
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o
>
> Fix this by adding MODULE attributes to the driver.
>
> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>
> ---
> drivers/pci/controller/pcie-mt7621.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
> index b60dfb45ef7b..668b737f86fb 100644
> --- a/drivers/pci/controller/pcie-mt7621.c
> +++ b/drivers/pci/controller/pcie-mt7621.c
> @@ -598,3 +598,5 @@ static struct platform_driver mt7621_pci_driver = {
> },
> };
> builtin_platform_driver(mt7621_pci_driver);
> +
> +MODULE_LICENSE("GPL v2");
I guess this is needed for COMPILE_TEST scenarios?
Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Thanks,
Sergio Paracuellos
> \ No newline at end of file
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-10-27 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 11:31 [PATCH 0/2] drivers/mt7621: Fix build error ERROR: modpost: Yanteng Si
2021-10-27 11:31 ` [PATCH 1/2] PCI: mt7621: Add MODULE_* macros to MT7621 PCIe host controller driver Yanteng Si
2021-10-27 11:59 ` Sergio Paracuellos [this message]
2021-10-28 1:45 ` yanteng si
2021-10-27 11:31 ` [PATCH 2/2] PCI: mt7621: Export mips_cm/cpc/gcr_* to modules Yanteng Si
2021-10-27 11:45 ` Sergio Paracuellos
2021-10-28 1:58 ` yanteng si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMhs-H9MANfLThCC-m9Q5whAgRAbnzXjUpipQdnwRf0iqPwJuw@mail.gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=bhelgaas@google.com \
--cc=chenhuacai@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=siyanteng01@gmail.com \
--cc=siyanteng@loongson.cn \
--cc=sterlingteng@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).