From: Geert Uytterhoeven <firstname.lastname@example.org>
To: Lorenzo Pieralisi <email@example.com>
Cc: Bjorn Helgaas <firstname.lastname@example.org>,
Marek Vasut <email@example.com>,
Kazufumi Ikeda <firstname.lastname@example.org>,
Gaku Inami <email@example.com>,
Marek Vasut <firstname.lastname@example.org>,
Geert Uytterhoeven <email@example.com>,
Phil Edworthy <firstname.lastname@example.org>,
Simon Horman <email@example.com>,
Wolfram Sang <firstname.lastname@example.org>,
Vaibhav Gupta <email@example.com>
Subject: Re: [PATCH V3] PCI: rcar: Add the suspend/resume for pcie-rcar driver
Date: Tue, 28 Apr 2020 10:33:24 +0200 [thread overview]
Message-ID: <CAMuHMdUAuCM55CwMEeycCjyMy0i=USUyQFyPKDsQgHiR-cRcJA@mail.gmail.com> (raw)
On Tue, Apr 28, 2020 at 10:26 AM Lorenzo Pieralisi
> On Mon, Apr 27, 2020 at 10:08:52PM +0200, Geert Uytterhoeven wrote:
> > On Mon, Apr 27, 2020 at 7:41 PM Bjorn Helgaas <firstname.lastname@example.org> wrote:
> > > On Sat, Apr 25, 2020 at 10:55:21AM +0200, Geert Uytterhoeven wrote:
> > > > On Fri, Apr 24, 2020 at 9:57 PM Bjorn Helgaas <email@example.com> wrote:
> > > > > [+cc Vaibhav]
> > > > >
> > > > > Alternate less redundant subject:
> > > > >
> > > > > PCI: rcar: Add suspend/resume support
> > > >
> > > > Note that there's both pcie-rcar.c (this driver, for R-Car Gen2 and Gen3
> > > > PCIe) and pci-rcar-gen2.c (for R-Car Gen2 PCI).
> > > > People tend to use the prefix "PCI: rcar: " for both :-(
> > >
> > > Yeah, that's pretty broken, thanks for pointing this out!
> > >
> > > For most drivers we use a chipset name ("keystone", "imx6", "tegra",
> > > etc) as the changlog tag. That's nice because it gives space for
> > > multiple drivers from the same vendor, but I don't know anything
> > > similarly specific for the R-Car drivers.
> > >
> > > pci-rcar-gen2.c seems to be for some sort of internal Conventional PCI
> > AFAIUI it's some internal PCI glue to the *HCI USB controller.
> > > bus? The "gen2" is confusing because "Gen 2" is more commonly used
> > > for PCIe than for Conventional PCI.
> > The "Gen2" applies to "R-Car", not to "PCI".
> Wicked :) !
pcie-rcar.c supports R-Car Gen1, Gen2, and Gen3.
> > > I would propose keeping "rcar" for the PCIe driver and using
> > > "rcar-pci" for the Conventional PCI one, but the Conventional PCI one
> > (/me resists against bike-shedding)
> I'd agree with Bjorn - I don't know, internal vs external seems
> artificial. Certainly gen2 is misleading, it does not take much
> to improve it.
We have lots of drivers in other subsystems with "rcar-gen2" or
"rcar-gen3" as part of their names.
> > > (pci-rcar-gen2.c) seems pretty inactive. The most recent commits are
> > > from 2018, and they're trivial cleanups. So I'm doubtful that anybody
> > > will remember when the next change comes in.
> > I guess pci-rcar-gen2.c is simpler and more mature ;-)
> > R-Car Gen2 SoCs have both (internal) PCI and PCIe, so the two drivers
> > can be used together on the same hardware.
> I'd remove gen2 to start with, you are better placed to know the
> internals to come up with something significant.
So we're back at "PCI: rcar: ...", for both ;-)
I'd say the main difference between the two drivers is PCI vs. PCIe.
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- firstname.lastname@example.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-04-28 8:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 19:12 [PATCH V3] PCI: rcar: Add the suspend/resume for pcie-rcar driver marek.vasut
2020-03-20 10:12 ` Lorenzo Pieralisi
2020-04-26 12:33 ` Marek Vasut
2020-04-24 11:54 ` Lorenzo Pieralisi
2020-04-24 19:57 ` Bjorn Helgaas
2020-04-25 8:55 ` Geert Uytterhoeven
2020-04-27 17:41 ` Bjorn Helgaas
2020-04-27 20:08 ` Geert Uytterhoeven
2020-04-28 8:26 ` Lorenzo Pieralisi
2020-04-28 8:33 ` Geert Uytterhoeven [this message]
2020-04-26 12:32 ` Marek Vasut
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).