From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Phil Edworthy <phil.edworthy@renesas.com>
Subject: Re: [PATCH] PCI: rcar: don't shadow the 'irq' variable
Date: Mon, 18 Mar 2019 11:16:16 +0100 [thread overview]
Message-ID: <CAMuHMdUwH1kLr_n1fCDwAQdP+yBqH++LOasx6FxOr_Z+CDNfNg@mail.gmail.com> (raw)
In-Reply-To: <20190317093445.7746-1-wsa+renesas@sang-engineering.com>
On Sun, Mar 17, 2019 at 10:35 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> sparse rightfully says:
> drivers/pci/controller/pcie-rcar.c:741:30: warning: symbol 'irq' shadows an earlier one
>
> It doesn't affect the current code. But fix it now to avoid future
> surprises and for good coding style.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-03-18 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 9:34 [PATCH] PCI: rcar: don't shadow the 'irq' variable Wolfram Sang
2019-03-18 10:16 ` Geert Uytterhoeven [this message]
2019-03-18 10:36 ` Simon Horman
2019-03-29 16:23 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUwH1kLr_n1fCDwAQdP+yBqH++LOasx6FxOr_Z+CDNfNg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=phil.edworthy@renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).