linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Herve Codina <herve.codina@bootlin.com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Marek Vasut" <marek.vasut+renesas@gmail.com>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Sergey Shtylyov" <s.shtylyov@omp.ru>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Clement Leger" <clement.leger@bootlin.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032
Date: Fri, 20 May 2022 10:29:28 +0200	[thread overview]
Message-ID: <CAMuHMdX6zXbFXo-tojpvrbobkWBe0MsjONEgZJismwFvhZ7SKA@mail.gmail.com> (raw)
In-Reply-To: <20220520102329.6b0a58d0@bootlin.com>

Hi Hervé,

On Fri, May 20, 2022 at 10:23 AM Herve Codina <herve.codina@bootlin.com> wrote:

> On Sun, 1 May 2022 10:51:43 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
> [...]
> > >    resets:
> > >      maxItems: 1
> > > @@ -106,13 +106,45 @@ required:
> > >    - interrupt-map
> > >    - interrupt-map-mask
> > >    - clocks
> > > -  - resets
> > >    - power-domains
> > >    - bus-range
> > >    - "#address-cells"
> > >    - "#size-cells"
> > >    - "#interrupt-cells"
> > >
> > > +if:
> >
> > allOf.
> >
> > > +  properties:
> > > +    compatible:
> > > +      contains:
> > > +        enum:
>
> I Have an issue with this allOf.
>
> The yaml has the following structure and so has 2 AllOf:
>   ...
>   allOf:
>   - $ref: /schemas/pci/pci-bus.yaml#
>
>   properties:
>     compatible:
>   ...
>   allOf:
>   - if:
>       properties:
>         compatible:
>           contains:
>   ...
> Is having a 'allOf' for schemas inclusion and a 'allOf' for conditionnal
> parts allowed ?

Just combine them into a single "allOf".
See e.g. Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml.

{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2022-05-20  8:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 13:41 [PATCH v5 0/6] RZN1 USB Host support Herve Codina
2022-04-29 13:41 ` [PATCH v4 " Herve Codina
2022-04-29 13:41 ` [PATCH v5 1/6] dt-bindings: PCI: pci-rcar-gen2: Convert bindings to json-schema Herve Codina
2022-04-29 13:41 ` [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032 Herve Codina
2022-05-01  8:51   ` Krzysztof Kozlowski
2022-05-02  9:19     ` Geert Uytterhoeven
2022-05-02 19:44       ` Rob Herring
2022-05-03  6:51         ` Geert Uytterhoeven
2022-05-03  9:29           ` Krzysztof Kozlowski
2022-05-03  9:37             ` Geert Uytterhoeven
2022-05-06 12:35               ` Herve Codina
2022-05-04 13:53             ` Rob Herring
2022-05-20  8:23     ` Herve Codina
2022-05-20  8:29       ` Geert Uytterhoeven [this message]
2022-05-20  8:31       ` Krzysztof Kozlowski
2022-04-29 13:41 ` [PATCH v5 3/6] PCI: rcar-gen2: Add RZ/N1 SOCs family compatible string Herve Codina
2022-05-11  9:42   ` Lorenzo Pieralisi
2022-05-11 12:05     ` Geert Uytterhoeven
2022-04-29 13:41 ` [PATCH v5 4/6] ARM: dts: r9a06g032: Add internal PCI bridge node Herve Codina
2022-04-29 13:41 ` [PATCH v5 5/6] ARM: dts: r9a06g032: Add USB PHY DT support Herve Codina
2022-04-29 13:41 ` [PATCH v5 6/6] ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY Herve Codina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdX6zXbFXo-tojpvrbobkWBe0MsjONEgZJismwFvhZ7SKA@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=bhelgaas@google.com \
    --cc=clement.leger@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=herve.codina@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=magnus.damm@gmail.com \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=s.shtylyov@omp.ru \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).