From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13814C47423 for ; Tue, 6 Oct 2020 07:38:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF3D42080A for ; Tue, 6 Oct 2020 07:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbgJFHh7 (ORCPT ); Tue, 6 Oct 2020 03:37:59 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:36572 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbgJFHh6 (ORCPT ); Tue, 6 Oct 2020 03:37:58 -0400 Received: by mail-ot1-f65.google.com with SMTP id 60so11408196otw.3; Tue, 06 Oct 2020 00:37:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8+YGZEZXCDlVSYcoSNcJ9v6pHT8JdkLtCN5s+E2ToaQ=; b=L3b/PWChkoqoS3sM68KkIks1b0cT9jMiy6dEJ9WER5VSr4OUBijAy2r0ZZDu964yjz VfYs+kttlFUUP4B0e2mPea0gSV3iwIyp/iscNyRT6mHVtn8iPaLkWHSACJPMMBwj+eSl utbFbKULMEnBeRrgiJxKhsqHpC0l88y4yzNFHScB/x1qHcvrT7e4I0yjt3x/Sann2q4h y6EQVsfVkoKicpJiyuAJVQuixqzSrEfdShe63f3CfTQY76y4JWp4uaRykmsJ7mzqt11b pwyHr5l4guJHbdpXDUG3lkH7L8LwjJrWNf7+Z0I8N80RMqyHFPxvrMulIJw3KWT1NFHX 8Wcw== X-Gm-Message-State: AOAM530TkVNGXR8CUhM7L2hbvAP7zPSf1zQWRsPH5X4MYux3okdjemRq M09bV9zRdfkzREB3AYB0zIRmbB0IPlE+jS+LjT4= X-Google-Smtp-Source: ABdhPJz2bCZlgB6we6A9AWlaXsOI2O+CwxUcnmKhPrIVPza5tGmo+mK6C98Ugzjy2W9HQnh3L0gpSmpM+xs5ujOFQMY= X-Received: by 2002:a05:6830:210a:: with SMTP id i10mr2082078otc.145.1601969875043; Tue, 06 Oct 2020 00:37:55 -0700 (PDT) MIME-Version: 1.0 References: <20201005183830.486085-1-robh@kernel.org> <20201005183830.486085-2-robh@kernel.org> In-Reply-To: <20201005183830.486085-2-robh@kernel.org> From: Geert Uytterhoeven Date: Tue, 6 Oct 2020 09:37:43 +0200 Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties' To: Rob Herring Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Andrew Lunn , Ulf Hansson , USB list , Peter Meerwald-Stadler , Sam Ravnborg , Linux PWM List , linux-iio@vger.kernel.org, Viresh Kumar , Linus Walleij , linux-pci , DRI Development , Sebastian Reichel , linux-ide@vger.kernel.org, Thierry Reding , Srinivas Kandagatla , Laurent Pinchart , Pavel Machek , Miquel Raynal , linux-riscv , Lee Jones , linux-clk , linux-leds@vger.kernel.org, Vignesh Raghavendra , linux-rtc@vger.kernel.org, Lars-Peter Clausen , Marc Zyngier , Daniel Lezcano , Krzysztof Kozlowski , Chanwoo Choi , MyungJoo Ham , "open list:SERIAL DRIVERS" , linux-input@vger.kernel.org, Jakub Kicinski , Zhang Rui , "open list:BROADCOM NVRAM DRIVER" , Vivien Didelot , Wolfgang Grandegger , Linux Media Mailing List , linux-hwmon@vger.kernel.org, Albert Ou , Jason Cooper , Linux PM list , linux-can@vger.kernel.org, "open list:GPIO SUBSYSTEM" , Mark Brown , Marc Kleine-Budde , Paul Walmsley , Bjorn Helgaas , Thomas Gleixner , Mauro Carvalho Chehab , Linux ARM , Jens Axboe , Alessandro Zummo , Linux Watchdog Mailing List , Thomas Bogendoerfer , Mathieu Poirier , Stephen Boyd , Greg Kroah-Hartman , Dmitry Torokhov , Linux MMC List , Liam Girdwood , linux-spi , Linux I2C , Vinod Koul , Palmer Dabbelt , Wim Van Sebroeck , Richard Weinberger , dmaengine , MTD Maling List , "David S. Miller" , Jonathan Cameron , Heiner Kallweit Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Rob, On Mon, Oct 5, 2020 at 8:39 PM Rob Herring wrote: > This doesn't yet do anything in the tools, but make it explicit so we can > check either 'unevaluatedProperties' or 'additionalProperties' is present > in schemas. > > 'unevaluatedProperties' is appropriate when including another schema (via > '$ref') and all possible properties and/or child nodes are not > explicitly listed in the schema with the '$ref'. > > This is in preparation to add a meta-schema to check for missing > 'unevaluatedProperties' or 'additionalProperties'. This has been a > constant source of review issues. > > Signed-off-by: Rob Herring Thanks for your patch! > Documentation/devicetree/bindings/bus/renesas,bsc.yaml | 2 ++ > .../bindings/memory-controllers/renesas,rpc-if.yaml | 2 ++ > Documentation/devicetree/bindings/net/renesas,ether.yaml | 2 ++ > Documentation/devicetree/bindings/serial/renesas,hscif.yaml | 2 ++ > Documentation/devicetree/bindings/serial/renesas,sci.yaml | 2 ++ > Documentation/devicetree/bindings/serial/renesas,scif.yaml | 2 ++ > Documentation/devicetree/bindings/serial/renesas,scifa.yaml | 2 ++ > Documentation/devicetree/bindings/serial/renesas,scifb.yaml | 2 ++ > Documentation/devicetree/bindings/spi/renesas,hspi.yaml | 2 ++ > Documentation/devicetree/bindings/spi/renesas,rspi.yaml | 2 ++ > Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 2 ++ Acked-by: Geert Uytterhoeven > --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml > +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml > @@ -85,6 +85,8 @@ required: > - clocks > - pinctrl-0 > > +unevaluatedProperties: false This one has received an "additionalProperties: false" in commit 41506bff84f1563e ("dt-bindings: net: renesas, ether: Improve schema validation") in net-next, which you probably want to remove. > + > examples: > # Lager board > - | Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds