From: Shunsuke Mie <mie@igel.co.jp>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Jon Mason" <jdmason@kudzu.us>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Ren Zhijie" <renzhijie2@huawei.com>,
linux-pci@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: endpoint: fix Kconfig indent style
Date: Fri, 16 Sep 2022 12:13:00 +0900 [thread overview]
Message-ID: <CANXvt5pYHDx=eneaRxZ0K=psQXsaLyp5dGA7OgoKYJaJ543mqQ@mail.gmail.com> (raw)
In-Reply-To: <20220815184142.GA1960338@bhelgaas>
Hi Lorenzo,
2022年8月16日(火) 3:41 Bjorn Helgaas <helgaas@kernel.org>:
>
> On Mon, Aug 15, 2022 at 11:50:06AM +0900, Shunsuke Mie wrote:
> > Change to follow the Kconfig style guide. This patch fixes to use tab
> > rather than space to indent, while help text is indented an additional
> > two spaces.
> >
> > Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
> > Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
>
> Thanks for doing this. In the future make the subject line match the
> history, e.g.,
>
> $ git log --oneline drivers/pci/endpoint/functions/Kconfig
> 556a2c7dca33 ("PCI: endpoint: Fix Kconfig dependency")
> e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
> 8b821cf76150 ("PCI: endpoint: Add EP function driver to provide NTB functionality")
> 98dbf5af4fdd ("PCI: endpoint: Select CRC32 to fix test build error")
> 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI")
>
> Note that these are all capitalized ("Fix Kconfig indent style").
>
> Lorenzo will likely fix this up when applying, so no need to repost
> for this.
This is a gentle ping.
>
> > ---
> > drivers/pci/endpoint/functions/Kconfig | 18 +++++++++---------
> > 1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpoint/functions/Kconfig
> > index 295a033ee9a2..9fd560886871 100644
> > --- a/drivers/pci/endpoint/functions/Kconfig
> > +++ b/drivers/pci/endpoint/functions/Kconfig
> > @@ -27,13 +27,13 @@ config PCI_EPF_NTB
> > If in doubt, say "N" to disable Endpoint NTB driver.
> >
> > config PCI_EPF_VNTB
> > - tristate "PCI Endpoint NTB driver"
> > - depends on PCI_ENDPOINT
> > - depends on NTB
> > - select CONFIGFS_FS
> > - help
> > - Select this configuration option to enable the Non-Transparent
> > - Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
> > - between PCI Root Port and PCIe Endpoint.
> > + tristate "PCI Endpoint NTB driver"
> > + depends on PCI_ENDPOINT
> > + depends on NTB
> > + select CONFIGFS_FS
> > + help
> > + Select this configuration option to enable the Non-Transparent
> > + Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
> > + between PCI Root Port and PCIe Endpoint.
> >
> > - If in doubt, say "N" to disable Endpoint NTB driver.
> > + If in doubt, say "N" to disable Endpoint NTB driver.
> > --
> > 2.17.1
> >
thanks,
Shunsuke
next prev parent reply other threads:[~2022-09-16 3:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 2:50 [PATCH] PCI: endpoint: fix Kconfig indent style Shunsuke Mie
2022-08-15 3:00 ` Shunsuke Mie
2022-08-15 18:39 ` Bjorn Helgaas
2022-08-16 1:31 ` Shunsuke Mie
2022-08-15 18:41 ` Bjorn Helgaas
2022-09-16 3:13 ` Shunsuke Mie [this message]
2022-11-11 14:11 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANXvt5pYHDx=eneaRxZ0K=psQXsaLyp5dGA7OgoKYJaJ543mqQ@mail.gmail.com' \
--to=mie@igel.co.jp \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jdmason@kudzu.us \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=rdunlap@infradead.org \
--cc=renzhijie2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).