From: Keith Busch <keith.busch@gmail.com>
To: Daniel Drake <drake@endlessm.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bjorn Helgaas <bhelgaas@google.com>, Jens Axboe <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
linux-ide@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme <linux-nvme@lists.infradead.org>,
Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: [PATCH] PCI: Add Intel remapped NVMe device support
Date: Fri, 14 Jun 2019 13:36:07 -0600 [thread overview]
Message-ID: <CAOSXXT4Ba_6xRUyaQBxpq+zdG9_itXDhFJ5EFZPv3CQuJZKHzg@mail.gmail.com> (raw)
In-Reply-To: <CAD8Lp47Vu=w+Lj77_vL05JYV1WMog9WX3FHGE+TseFrhcLoTuA@mail.gmail.com>
On Thu, Jun 13, 2019 at 8:26 PM Daniel Drake <drake@endlessm.com> wrote:
> On Thu, Jun 13, 2019 at 4:54 PM Christoph Hellwig <hch@lst.de> wrote:
> > b) reset handling, including the PCI device removal as the last
> > escalation step
>
> Apparently can't be supported, but it's not clear that this actually
> matters for a home PC...
>
> https://marc.info/?l=linux-ide&m=147733119300691&w=2
> "The driver seems to already comprehend instances where the
> device does not support nvme_reset_subsystem() requests."
>
> https://marc.info/?l=linux-ide&m=147734288604783&w=2
> "Talking with Keith, subsystem-resets are a feature of enterprise-class
> NVMe devices. I think those features are out of scope for the class
> of devices that will find themselves in a platform with this
> configuration, same for hot-plug."
NVMe Subsystem resets are not the same thing as conventional PCI
resets. We still have use for the latter in client space.
Even if you wish to forgo the standard features and management
capabilities, you're still having to deal with legacy IRQ, which has
IOPs at a fraction of the hardware's true capabilities when using MSI.
I do not believe that is what users want out of their purchased
hardware, so your best option is still to set to AHCI mode for Linux
for this reason alone, and vendors should be providing this option in
BIOS.
next prev parent reply other threads:[~2019-06-14 19:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 7:44 [PATCH] PCI: Add Intel remapped NVMe device support Daniel Drake
2019-06-10 16:00 ` Keith Busch
2019-06-11 2:46 ` Daniel Drake
2019-06-12 14:32 ` Keith Busch
2019-06-13 8:54 ` Christoph Hellwig
2019-06-14 2:26 ` Daniel Drake
2019-06-14 19:36 ` Keith Busch [this message]
2019-06-14 20:05 ` Bjorn Helgaas
2019-06-14 21:05 ` Keith Busch
2019-06-18 7:48 ` Hannes Reinecke
2019-06-18 7:46 ` Hannes Reinecke
2019-06-18 8:06 ` Daniel Drake
2019-06-18 15:15 ` Hannes Reinecke
2019-06-19 13:52 ` Bjorn Helgaas
2019-06-10 21:16 ` Bjorn Helgaas
2019-06-11 3:25 ` Daniel Drake
2019-06-11 19:52 ` Bjorn Helgaas
2019-06-12 3:16 ` Daniel Drake
2019-06-12 13:49 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOSXXT4Ba_6xRUyaQBxpq+zdG9_itXDhFJ5EFZPv3CQuJZKHzg@mail.gmail.com \
--to=keith.busch@gmail.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=drake@endlessm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).