From: "Oliver O'Halloran" <oohall@gmail.com>
To: "Kuppuswamy,
Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Yicong Yang <yangyicong@hisilicon.com>,
Bjorn Helgaas <bhelgaas@google.com>,
jay.vosburgh@canonical.com, linux-pci@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ashok.raj@intel.com, Sam Bobroff <sbobroff@linux.ibm.com>
Subject: Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices
Date: Wed, 27 May 2020 13:35:06 +1000 [thread overview]
Message-ID: <CAOSf1CE00f_3KxWAPvWngsW8z_frw6=qB70H+VmdSULaspHWhQ@mail.gmail.com> (raw)
In-Reply-To: <55b3a469-c306-acf1-f97e-f07f40054974@linux.intel.com>
On Wed, May 27, 2020 at 1:06 PM Kuppuswamy, Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
>
> Yes, in case of DPC (Fatal errors) link is already reset. So we
> don't need any special handling. This reset logic is mainly for
> non-fatal errors.
Why? In our experience most fatal errors aren't all that fatal and can
be recovered by resetting the device. The base spec backs that up (see
gen5 base, sec 6.2) too saying the main point of distinction between
fatal and non-fatal errors is whether handling the error requires a
reset or not. For EEH we always try to recover the device and only
mark it as permanently failed once the devices goes over the max error
threshold (5 errors per hour, by default). Doing something similar for
(native) DPC would make sense IMO.
next prev parent reply other threads:[~2020-05-27 3:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200506203249.GA453633@bjorn-Precision-5520>
2020-05-07 0:56 ` [PATCH] PCI/ERR: Resolve regression in pcie_do_recovery Jay Vosburgh
2020-05-07 3:32 ` [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices sathyanarayanan.kuppuswamy
2020-05-12 19:20 ` Jay Vosburgh
2020-05-13 1:50 ` Yicong Yang
2020-05-13 22:44 ` Bjorn Helgaas
2020-05-14 20:36 ` Kuppuswamy, Sathyanarayanan
2020-05-20 8:28 ` Yicong Yang
2020-05-20 17:04 ` Kuppuswamy, Sathyanarayanan
2020-05-21 10:58 ` Yicong Yang
2020-05-21 19:31 ` Kuppuswamy, Sathyanarayanan
2020-05-22 2:56 ` Yicong Yang
2020-05-27 1:31 ` Kuppuswamy, Sathyanarayanan
2020-05-27 3:00 ` Oliver O'Halloran
2020-05-27 3:06 ` Kuppuswamy, Sathyanarayanan
2020-05-27 3:35 ` Oliver O'Halloran [this message]
2020-05-27 3:50 ` Yicong Yang
2020-05-27 4:04 ` Kuppuswamy, Sathyanarayanan
2020-05-27 6:41 ` Yicong Yang
2020-05-28 3:57 ` Kuppuswamy, Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOSf1CE00f_3KxWAPvWngsW8z_frw6=qB70H+VmdSULaspHWhQ@mail.gmail.com' \
--to=oohall@gmail.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=jay.vosburgh@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sbobroff@linux.ibm.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).