From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f182.google.com ([209.85.214.182]:61059 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbaDVDe2 (ORCPT ); Mon, 21 Apr 2014 23:34:28 -0400 Received: by mail-ob0-f182.google.com with SMTP id uy5so3887436obc.13 for ; Mon, 21 Apr 2014 20:34:27 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1E05E2AB-198E-473A-8AA5-87DA2E9910B8@gmail.com> References: <1397000541-1085-1-git-send-email-keith.busch@intel.com> <1397000541-1085-2-git-send-email-keith.busch@intel.com> <1E05E2AB-198E-473A-8AA5-87DA2E9910B8@gmail.com> From: Learner Study Date: Mon, 21 Apr 2014 20:34:07 -0700 Message-ID: Subject: Re: [PATCH 2/2] NVMe: Implement PCI-e reset notification callback To: Keith Busch Cc: "linux-pci@vger.kernel.org" , linux-nvme , "bhelgaas@google.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-pci-owner@vger.kernel.org List-ID: Per the spec, "When an NVM Subsystem Reset occurs, the entire NVM subsystem is reset"....so all VFs would get impacted, if a VF does a Reset. So, I think Reset kind of control should be in PF mode only. On Mon, Apr 21, 2014 at 7:45 PM, Learner wrote: > But Won't resetting from a VF impact functionality of other VFs? > > On Apr 21, 2014, at 6:57 PM, Keith Busch wrote: > >> On Mon, 21 Apr 2014, Learner Study wrote: >>> Hi Keith, >>> >>> I think NVMe Reset should apply to PF mode driver only, and not to VF >>> mode driver. >>> Is that understanding correct? Does the NVMe driver know which mode >>> its running in? >> >> Oh, this driver doesn't enable SR-IOV and has no PF/VF awareness. Shame >> on us, I'll add it to my list unless someone beats me to it. >> >> Still, I think we'd like to be able to reset a VF if only because it >> gets the queues back to a pristine state. A VF reset should not affect >> any of the other functions.