From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, TVD_SUBJ_WIPE_DEBT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72AA7C83000 for ; Wed, 29 Apr 2020 14:42:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5201421D7F for ; Wed, 29 Apr 2020 14:42:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s5fCj4BQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbgD2Omt (ORCPT ); Wed, 29 Apr 2020 10:42:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726780AbgD2Omt (ORCPT ); Wed, 29 Apr 2020 10:42:49 -0400 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13542C03C1AD; Wed, 29 Apr 2020 07:42:49 -0700 (PDT) Received: by mail-il1-x144.google.com with SMTP id c18so2646272ile.5; Wed, 29 Apr 2020 07:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xqWtuuKGyccZnCAMErVogWBfiRD+U5fCxE5xiaJTzfo=; b=s5fCj4BQKrHN0Zovvg3Dr25wInQgTYs0QpmECbgHHuMzwOfZPpWBo5kbvDtkQXXTSO iXDdXHTqmTd7tdHb5K3vCr+nZ6G7qiXnMz078lmJjWeTAqZF5MjEb44MxQVO0aX+ljfQ /0c6q3bgMT7t0XSvGyJsfR0dnidb17q2HiJ7X5F/WbSn6W3ukIcAoSbUaOZYtqlc3dQH YmlE4eHfQ9RXtB4WmPRDsuiST3FZ4SuBpxQiy5IQK+wmr2PaJGMR1X1a2Nw1TqTFZmGH pHRm1Xf+CnOprzL8LoiY181dWiUMUTOuUF3P3A/0xGL0kIAw9FnTMlbxZxtEGza3Eq18 Dh4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xqWtuuKGyccZnCAMErVogWBfiRD+U5fCxE5xiaJTzfo=; b=bBd5WPe/QloBcvOE6tHaZ6MOKoJ9kz/p/y40hmGGnGmXbW1VsWiq/3BIU2I7/VnU3h SpYMRlFW4+VCtcLQYOaC7BwdkXbpNBAgdtEDysrUdfw5bqZMH0kkni9rz3L868G37U3s jSDPMiDOLX7VKDvCd/AVeSrfiJTTcepuGwixHXld4ME63v60jNnoLj43RcYBEzaYTtgf Y8APIYJkyink4crTME5s41roKuTrqGG0sxTgX96W7HdZltjhDgShBVpLKe36rbXDB3Q5 fDPoYyrukoLDHWq9xeKZPuceOQzy4oE5nwLUGTntXKto2ZI4lPXX8xvVRLgr6STDtUhA r03w== X-Gm-Message-State: AGi0PuZWpI6COLbL+JwjXnpb6DlJw9mDTzkEfO9cvs6pEkxzKbVx6xSY C0wZ+9QyVPOuvWPaXFxjcImYpHlUkJN09PhE0RU= X-Google-Smtp-Source: APiQypJ7U9Prko6Vi5K48lXkGdf0yeTY8OK5a8KU1GkGRlP47cvtBGWMdJwRF+dEj65ASvEvOa24knaqwchBPTLuB7o= X-Received: by 2002:a92:cac7:: with SMTP id m7mr32641141ilq.6.1588171368312; Wed, 29 Apr 2020 07:42:48 -0700 (PDT) MIME-Version: 1.0 References: <20200428144314.24533-2-vaibhavgupta40@gmail.com> <20200428171928.GA170516@google.com> In-Reply-To: From: Vaibhav Gupta Date: Wed, 29 Apr 2020 20:11:45 +0530 Message-ID: Subject: Re: [Linux-kernel-mentees] [PATCH v2 1/2] realtek/8139too: Remove Legacy Power Management To: Bjorn Helgaas Cc: Vaibhav Gupta , Shannon Nelson , Jakub Kicinski , Heiner Kallweit , Martin Habets , netdev@vger.kernel.org, bjorn@helgaas.com, linux-kernel-mentees@lists.linuxfoundation.org, "Rafael J. Wysocki" , Linux Kernel Mailing List , linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org > > > > Uncapitalize "legacy power management" in subject. I'd say "convert", > > not "remove", to make it clear that the driver will still do power > > management afterwards. Sure! > > > > I think your to: and cc: list came from the get_maintainer.pl script, yeah. > > but you can trim it a bit by omitting people who have just made > > occasional random fixups. These drivers are really unmaintained, so > > Dave M, netdev, Rafael, linux-pm, linux-pci, and maybe LKML are > > probably enough. I will keep this in mind next time. > > > > On Tue, Apr 28, 2020 at 08:13:13PM +0530, Vaibhav Gupta wrote: > > > Upgrade power management from legacy to generic using dev_pm_ops. > > > > Instead of the paragraphs below, which cover the stuff that's fairly > > obvious, I think it would be more useful to include hints about where > > the things you removed will be done now. That helps reviewers verify > > that this doesn't break anything. E.g., > > > > In the legacy PM model, drivers save and restore PCI state and set > > the device power state directly. In the generic model, this is all > > done by the PCI core in .suspend_noirq() (pci_pm_suspend_noirq()) > > and .resume_noirq() (pci_pm_resume_noirq()). > > > > This sort of thing could go in each commit log. The cover letter > > doesn't normally go in the commit log, so you have to assume it will > > be lost. Okay. I will send v3 patch-series with changes. Thanks for acknowledging :) --Vaibhav Gupta > > > > > Remove "struct pci_driver.suspend" and "struct pci_driver.resume" > > > bindings, and add "struct pci_driver.driver.pm" . > > >