linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peifeng Qiu <linux@qiupf.dev>
To: bhelgaas@google.com, linux-pci@vger.kernel.org
Subject: Missing sriov_numvfs after removal of EfiMemoryMappedIO from E820 map
Date: Sun, 15 Jan 2023 18:21:39 +0900	[thread overview]
Message-ID: <CAPH51bc1ZoP2ukJJh8nfrNY1FCp1nk7AP0jGGCvoskq2XbmAoA@mail.gmail.com> (raw)

Hi.

I'm using a dual Xeon system with Intel e810 25G network card and make use
of SRIOV feature heavily. I have a script to setup the NIC the first step is
echo $VFS > /sys/class/net/$DEVNAME/device/sriov_numvfs

After switching from v6.1 to v6.2-rc1 "sriov_numvfs" is no longer present. If I
switch back to v6.1 it's back. Command line parameters are the same so it's
most likely kernel changes. I did git bisect and found the culprit to be
07eab0901ed(efi/x86: Remove EfiMemoryMappedIO from E820 map)

I tested v6.2-rc3 and it's the same. I reverted this commit on top of v6.2-rc3
then sriov_numvfs is back again. Comparing the dmesg output, I found that
with commit 07eab0901ed these lines are present:
[    0.000000] efi: Remove mem94: MMIO range=[0x80000000-0x8fffffff]
(256MB) from e820 map
[    0.000000] e820: remove [mem 0x80000000-0x8fffffff] reserved
[    0.000000] efi: Remove mem95: MMIO range=[0xfd000000-0xfe7fffff]
(24MB) from e820 map
[    0.000000] e820: remove [mem 0xfd000000-0xfe7fffff] reserved
[    0.000000] efi: Not removing mem96: MMIO
range=[0xfed20000-0xfed44fff] (148KB) from e820 map
[    0.000000] efi: Remove mem97: MMIO range=[0xff000000-0xffffffff]
(16MB) from e820 map
[    0.000000] e820: remove [mem 0xff000000-0xffffffff] reserved
[    0.000000] efi: Remove mem99: MMIO
range=[0x1ffc00000000-0x1fffffffffff] (16384MB) from e820 map
[    0.000000] e820: remove [mem 0x1ffc00000000-0x1fffffffffff] reserved

I think that's what the commit actually does. But the following are missing:
[    2.516119] pci 0000:ca:00.0: reg 0x184: [mem
0x208ffd000000-0x208ffd01ffff 64bit pref]
[    2.516121] pci 0000:ca:00.0: VF(n) BAR0 space: [mem
0x208ffd000000-0x208ffdffffff 64bit pref] (contains BAR0 for 128 VFs)
[    2.516134] pci 0000:ca:00.0: reg 0x190: [mem
0x208ffe220000-0x208ffe223fff 64bit pref]
[    2.516136] pci 0000:ca:00.0: VF(n) BAR3 space: [mem
0x208ffe220000-0x208ffe41ffff 64bit pref] (contains BAR3 for 128 VFs)

Not sure whether this is a driver issue specific to Intel e810(module ice) or
a more general one. Any thoughts on this issue?

Best regards,
Peifeng Qiu

             reply	other threads:[~2023-01-15  9:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-15  9:21 Peifeng Qiu [this message]
2023-01-15 14:21 ` Missing sriov_numvfs after removal of EfiMemoryMappedIO from E820 map Linux kernel regression tracking (Thorsten Leemhuis)
2023-01-15 15:41   ` Linux kernel regression tracking (Thorsten Leemhuis)
2023-01-16 10:14     ` Peifeng Qiu
2023-01-27 11:32       ` Linux kernel regression tracking (#update)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPH51bc1ZoP2ukJJh8nfrNY1FCp1nk7AP0jGGCvoskq2XbmAoA@mail.gmail.com \
    --to=linux@qiupf.dev \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).