From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CECFC31E45 for ; Thu, 13 Jun 2019 20:15:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E71D520B7C for ; Thu, 13 Jun 2019 20:15:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="HiQM8Oj8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727529AbfFMUP0 (ORCPT ); Thu, 13 Jun 2019 16:15:26 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:43305 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727505AbfFMUP0 (ORCPT ); Thu, 13 Jun 2019 16:15:26 -0400 Received: by mail-oi1-f196.google.com with SMTP id w79so289138oif.10 for ; Thu, 13 Jun 2019 13:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gYvi3JENt5xjT7/oQoCCDRRyhuGQKrPeHYLl1e4tUxo=; b=HiQM8Oj8L+VS1a8Hidw0xr9iYYaQmKDaapqQQLP3xBSAjW2G7zF8GCiMqjGr/ym+Mo M+OqlxjvRB4nsYJvbsbx5Z3ifuAo0JozSHiAbNq39t8D2waMsSabG6FDy40WGT4oYy8V L96EPmLmkBZ66RnBr04w7xeY6utWIJLm5CrypM9lYrEcqa9F/Z5nPa4IShCeMmTv0t0L gS2NRGRi4wYn5eA9ZuBqSXqoz8gXypGTSbll9Wp2Y8UNYHgTyBR1qyLVx2ig9t9lcYmD HVaPJZLwJOeNsVJ9c9ozc803Mh/zRF+OxcMsrpFkoEYk0fk+301QRIAXIyrgvI3K0bkW VbzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gYvi3JENt5xjT7/oQoCCDRRyhuGQKrPeHYLl1e4tUxo=; b=eFFhyHj/c3xVCkNWAggyDnw+1724txDYoJzsIy69OEAY1f3qrr2bY6JRAiWmDT/ygj 0SNTEQ/HxPQaQD8HA3BnqRgnFxMcanhM3DXQ7CAjJ7Zzg47S8ei5AKENvBb+5E/p5I/A UuY0XEildj54L92J47tSXrIGJlLBzFKRipibI099JXCMlC0hRS5OWsCmngdQ1+sFxQoU 1xmUpTLKqTfAXPH3du/gVaUgxhUTMWMEdBk4Vas+ri1DIQZcMncsWsfjrv0NK8y1f1Ml f93qAs9G94n1pRhXrv88/eQeWvYzJX7Tnjoivn6PFn+PmlEpmAohST5UWthpOBUlZLBS A5sQ== X-Gm-Message-State: APjAAAXvReEUjWUPmV1mrtl0NQNQavVm/y4p3vnBFXWoKtKMZ/76ccY+ vzjDmCm6CTeUGf7Sq6kK67rTKCUXHGPIPykZxdjkHg== X-Google-Smtp-Source: APXvYqyS333Lp+D4vjCDNGXf2txUSus++eUTfldGM7ZmElD6Qov2BJs1+/5zSo9qFUO6PniS7TXRoikGBTwqET2Ahjo= X-Received: by 2002:aca:ec82:: with SMTP id k124mr4014371oih.73.1560456925540; Thu, 13 Jun 2019 13:15:25 -0700 (PDT) MIME-Version: 1.0 References: <20190613094326.24093-1-hch@lst.de> <20190613094326.24093-9-hch@lst.de> In-Reply-To: From: Dan Williams Date: Thu, 13 Jun 2019 13:15:14 -0700 Message-ID: Subject: Re: [PATCH 08/22] memremap: pass a struct dev_pagemap to ->kill To: Logan Gunthorpe Cc: Christoph Hellwig , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Ben Skeggs , linux-nvdimm , linux-pci@vger.kernel.org, Linux Kernel Mailing List , Maling list - DRI developers , Linux MM , nouveau@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Jun 13, 2019 at 1:12 PM Logan Gunthorpe wrote: > > > > On 2019-06-13 3:43 a.m., Christoph Hellwig wrote: > > Passing the actual typed structure leads to more understandable code > > vs the actual references. > > Ha, ok, I originally suggested this to Dan when he introduced the > callback[1]. > > Reviewed-by: Logan Gunthorpe Reviewed-by: Dan Williams Reported-by: Logan Gunthorpe :) > > Logan > > [1] > https://lore.kernel.org/lkml/8f0cae82-130f-8a64-cfbd-fda5fd76bb79@deltatee.com/T/#u >