From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7765C48BD6 for ; Wed, 26 Jun 2019 16:01:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BED80218D9 for ; Wed, 26 Jun 2019 16:01:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="FEqk4Ayq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726373AbfFZQA7 (ORCPT ); Wed, 26 Jun 2019 12:00:59 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:33718 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726354AbfFZQA7 (ORCPT ); Wed, 26 Jun 2019 12:00:59 -0400 Received: by mail-oi1-f195.google.com with SMTP id f80so2358421oib.0 for ; Wed, 26 Jun 2019 09:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r/963AMc32TjFW8pz2sb81LGtvemWumKWmOSWi/w+uo=; b=FEqk4AyqvI2SzCotbI6w47r7lIg1pbMai4XViymaBkOSAtj0NfKwJKshzu/N8BPJFi PPN0xns9/GQ3UjW0F9OUD+lLQxT0bLvpRO6rEeExsKdp48k3oiJcMS1RfpUHWI3YgQSe P3swXsvQ9fmeXBT6oobBozcpVgRGWN23FavhhN4cCEGhqIdsUZ+QWbmxpT1xgQhmYaLI wRlJBZOCxG1HxsggNiXJVMbdqx15uDTKnIMPx8OZYBLCprh9CGs/eCgDPe7/TAMtVU5d oafpIZj3xnh4RTWYjvBCXah4DbVlLssHna403/2Qrtq8aZqQJ+EBDW0IKrQkvHB1zCgf +PXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r/963AMc32TjFW8pz2sb81LGtvemWumKWmOSWi/w+uo=; b=EcqHkAyOVocgZLV3bPHkxVbcdBxmNXaaiLIMeqIPFzS/e49tcwfVq+YWI68zn3s25y xsL+VdX90UkFVQim9yAejC+iICW5uvzrK/y0yyds8XI0D4I7bSP6LNXR+LsiH/AM6OjN v7Xf6DolVmT36zOMtHfN4cNOB18xoJKg8zgCZv01whqPRLnhr8AzZKu/LbmOA74p1e6B EU31cpoo8pg44T9LPrz2lCnRx81LuZ1bvFp54NNvPJ6W1FvYF/Yo4+u4c9y/cNLrM4bH 23Hr8VeZEq0E7m/1AEhAxi5xrFMhyvmgEYGbOC2CAq/ZDoqxvYVDeSJjQ6+DF/WtzAUz cExw== X-Gm-Message-State: APjAAAWhR0O+Q/g5F1+pFepCUY8ZI3iJSSnAlXooKa+Rcqs3kZQjHMrs yj4d+xPhpzeaDjVb9X3k5KID6C3z8ajQgEWERpdfFw== X-Google-Smtp-Source: APXvYqw+HKEk3o1E4qvsumKbcYL8DeGoSSUg6kQouoUdfkWJuiZCSiMJzuF3+UevbQqRwbob+TxTsET5oJi5oxrpxxs= X-Received: by 2002:aca:fc50:: with SMTP id a77mr2276731oii.0.1561564858765; Wed, 26 Jun 2019 09:00:58 -0700 (PDT) MIME-Version: 1.0 References: <20190626122724.13313-1-hch@lst.de> <20190626122724.13313-5-hch@lst.de> In-Reply-To: <20190626122724.13313-5-hch@lst.de> From: Dan Williams Date: Wed, 26 Jun 2019 09:00:47 -0700 Message-ID: Subject: Re: [PATCH 04/25] mm: remove MEMORY_DEVICE_PUBLIC support To: Christoph Hellwig Cc: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Ben Skeggs , Linux MM , nouveau@lists.freedesktop.org, Maling list - DRI developers , linux-nvdimm , linux-pci@vger.kernel.org, Linux Kernel Mailing List , Michal Hocko , "Weiny, Ira" Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org [ add Ira ] On Wed, Jun 26, 2019 at 5:27 AM Christoph Hellwig wrote: > > The code hasn't been used since it was added to the tree, and doesn't > appear to actually be usable. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Jason Gunthorpe > Acked-by: Michal Hocko [..] > diff --git a/mm/swap.c b/mm/swap.c > index 7ede3eddc12a..83107410d29f 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -740,17 +740,6 @@ void release_pages(struct page **pages, int nr) > if (is_huge_zero_page(page)) > continue; > > - /* Device public page can not be huge page */ > - if (is_device_public_page(page)) { > - if (locked_pgdat) { > - spin_unlock_irqrestore(&locked_pgdat->lru_lock, > - flags); > - locked_pgdat = NULL; > - } > - put_devmap_managed_page(page); > - continue; > - } > - This collides with Ira's bug fix [1]. The MEMORY_DEVICE_FSDAX case needs this to be converted to be independent of "public" pages. Perhaps it should be pulled out of -mm and incorporated in this series. [1]: https://lore.kernel.org/lkml/20190605214922.17684-1-ira.weiny@intel.com/