From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 225ACC433F5 for ; Tue, 1 Feb 2022 22:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239944AbiBAWY6 (ORCPT ); Tue, 1 Feb 2022 17:24:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239569AbiBAWY6 (ORCPT ); Tue, 1 Feb 2022 17:24:58 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85D6CC061714 for ; Tue, 1 Feb 2022 14:24:58 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id v3so16698428pgc.1 for ; Tue, 01 Feb 2022 14:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u2EiycHzHs1b2F0/iUOQ5xWejurFd89dED1f6mm35uU=; b=Y0sGYPzdHJHWs/JbjpkQqTUt5gZlw5M1EoAw2VCHVnpy4C8y8DiEYyXlYCBQdlxmSu adcAvLvEfHcEoTBXYXNvloavzagYMZp8M6InndBAYrNCgogFr2RlS4bq9bUYqwcQMAW8 McrP08GZRkUZm0ZyBltFlqcHvImGOojGi8MBpz4622WPOyXvkN8JM3bZ0q9O+QBx9dZW Wf3aBKhd2/E9HgPnIuFon6fdVkHIpctaeUgWs2UF/N55V+Ot0GqKd8EvHILBGPiNaqlI a1ccCsnmFN2MTcFf5QsNTrave0mukNCYHR7wvvoqLrNa1+4xbkjWYlhQYukUAt+A3r10 8W7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u2EiycHzHs1b2F0/iUOQ5xWejurFd89dED1f6mm35uU=; b=KE1u4lpz31QcrcmHuHMJZt1pWYGN1rb1GSr8+DKp7oikWq5WjDxGCs3QN1o1hnZhIA Ca3mRN/4kR2DLgoIhy5/JzIK55R3h+xqWDN5Y4rNO+0Bkq9LzAQfWGPTU8iuBlBb8dMP vt0XlCALiWY0sA9XqmQmxmQ84IKu3XfKOj0LUET2rK/PftjLMQy9KJR2JSkutWnQU5i5 PKVPAIN2uRXXY3o7bumgjlUalxgSFjocl6x5T6PDu+xtndC/mbFGN5gAYmyO2P61JzS1 w1KvBnODIt+Uf4WxF9b7Rv8wpUyc41iG1aLEuwivfqtKV1oNnRJakOz8yep0rrlQlqjQ HhMw== X-Gm-Message-State: AOAM533dRs8BRvnc/d0gHf/ondLak3XMHvflIVyr3yCH4tPuphp5KC9n gZip2qoE1e5NbqHGSnFRIL65BkFR8DlGXYr55ZvkcQ== X-Google-Smtp-Source: ABdhPJwTDsUmAvr06z8oPX9E1R3lrXOzRtesNHE2KuqBx7W0JHyBi+Kv07nLiKYh4+e2w4FdOlqvPRpyYYDAbwHQN1g= X-Received: by 2002:a63:550f:: with SMTP id j15mr22088163pgb.40.1643754298047; Tue, 01 Feb 2022 14:24:58 -0800 (PST) MIME-Version: 1.0 References: <164298411792.3018233.7493009997525360044.stgit@dwillia2-desk3.amr.corp.intel.com> <164298426273.3018233.9302136088649279124.stgit@dwillia2-desk3.amr.corp.intel.com> <20220131181924.00006c57@Huawei.com> <20220201152410.36jvdmmpcqi3lhdw@intel.com> <20220201221114.25ivh5ubptd7kauk@intel.com> <20220201222042.hv2xipmuous7s7qh@intel.com> In-Reply-To: <20220201222042.hv2xipmuous7s7qh@intel.com> From: Dan Williams Date: Tue, 1 Feb 2022 14:24:51 -0800 Message-ID: Subject: Re: [PATCH v3 27/40] cxl/pci: Cache device DVSEC offset To: Ben Widawsky Cc: Jonathan Cameron , linux-cxl@vger.kernel.org, Linux PCI , Linux NVDIMM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Feb 1, 2022 at 2:20 PM Ben Widawsky wrote: > > On 22-02-01 14:15:22, Dan Williams wrote: > > On Tue, Feb 1, 2022 at 2:11 PM Ben Widawsky wrote: > > > > > > On 22-02-01 13:41:50, Dan Williams wrote: > > > > On Tue, Feb 1, 2022 at 7:24 AM Ben Widawsky wrote: > > > > > > > > > > On 22-01-31 18:19:24, Jonathan Cameron wrote: > > > > > > On Sun, 23 Jan 2022 16:31:02 -0800 > > > > > > Dan Williams wrote: > > > > > > > > > > > > > From: Ben Widawsky > > > > > > > > > > > > > > The PCIe device DVSEC, defined in the CXL 2.0 spec, 8.1.3 is required to > > > > > > > be implemented by CXL 2.0 endpoint devices. Since the information > > > > > > > contained within this DVSEC will be critically important, it makes sense > > > > > > > to find the value early, and error out if it cannot be found. > > > > > > > > > > > > > > Signed-off-by: Ben Widawsky > > > > > > > Signed-off-by: Dan Williams > > > > > > Guess the logic makes sense about checking this early though my cynical > > > > > > mind says, that if someone is putting in devices that claim to be > > > > > > CXL ones and this isn't there it is there own problem if they > > > > > > kernel wastes effort bringing the driver up only to find later > > > > > > it can't finish doing so... > > > > > > > > > > I don't remember if Dan and I discussed actually failing to bind this early if > > > > > the DVSEC isn't there. > > > > > > > > On second look, the error message does not make sense because there is > > > > "no functionality" not "limited functionality" as a result of this > > > > failure because the cxl_pci driver just gives up. This failure should > > > > be limited to cxl_mem, not cxl_pci as there might still be value in > > > > accessing the mailbox on this device. > > > > > > > > > I think the concern is less about wasted effort and more > > > > > about the inability to determine if the device is actively decoding something > > > > > and then having the kernel driver tear that out when it takes over the decoder > > > > > resources. This was specifically targeted toward the DVSEC range registers > > > > > (obviously things would fail later if we couldn't find the MMIO). > > > > > > > > If there is no CXL DVSEC then cxl_mem should fail, that's it. > > > > > > > > > > If there is no CXL DVSEC we have no way to find the device's MMIO. You need the > > > register locator dvsec. Not sure how you intend to do anything with the device > > > at that point, but if you see something I don't, then by all means, change it. > > > > I see: > > > > pci_find_dvsec_capability(pdev, PCI_DVSEC_VENDOR_ID_CXL, CXL_DVSEC_PCIE_DEVICE); > > > > ...and: > > > > pci_find_dvsec_capability(pdev, PCI_DVSEC_VENDOR_ID_CXL, CXL_DVSEC_REG_LOCATOR); > > > > ...aren't they independent? > > My mistake. I was thinking of a different patch, "cxl/pci: Retrieve CXL DVSEC > memory info". You're correct, they are independent (both mandatory for type 3 > devices). > > However, Jonathan was the one who originally suggested it. I had it as a warn > originally. > https://lore.kernel.org/linux-cxl/20211122223430.gvkwj3yeckriffes@intel.com/ At least to the concern of "nothing" working without the base CXL DVSEC the cxl_mem driver failing to attach catches that case. Otherwise a device that only implements the mailbox seems not outside the realm of possibility. Jonathan?