From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF8E8C433EF for ; Fri, 4 Feb 2022 21:18:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242215AbiBDVSx (ORCPT ); Fri, 4 Feb 2022 16:18:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242249AbiBDVRl (ORCPT ); Fri, 4 Feb 2022 16:17:41 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3929C061794 for ; Fri, 4 Feb 2022 13:17:00 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id g15-20020a17090a67cf00b001b7d5b6bedaso7231255pjm.4 for ; Fri, 04 Feb 2022 13:17:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kDEtWBF+FkzY2NKHxDg+IP2BBNRMiosO3bx2fXdN2Zs=; b=r42ec818szqLkxWoZYqBAhS9cGcDXcv2mRyuvEfw3F7D16kltjOkJRitiddd3N3+Hj JeVRC4RpR1rK8a9E2eMyTEVdh1UQfw8q0ERznMg96qWADTVMDBDsXgRXRrEugON6ECZK oKt6+q4iTGJOgzo4xKt1URjxHjbctHnOfnYaXSyL+C5Ts8eRJ6vhStKrEd+gFkRVX6e8 8zi2NFXX3iz3yR/XwjUeNPXx/642wvWCVAgTpgbBqczj8wdK8Sk+fr43NrNV8m40fgVd bGoMDfJC4pFqB4bGrUUZlJaS//ElOsdCn7W6CJs2GlfrNedawjQaPvM+pP9dLzfabw1m G3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kDEtWBF+FkzY2NKHxDg+IP2BBNRMiosO3bx2fXdN2Zs=; b=1sJwcMv8Hh+PeNHx+VFOEnskdVM3YetG7qNAwNYewXb0kzLv99oBmKaevV6BV7ENY6 BsRoOtivV4Zq6BDFNcdKaqXr36kZuo2AHdCuc8OhCxKKjji2Plqtf1g50eULhxs0qEva jmZ1gMRP3+x0oEYSI6qt4Y6MiTDR3cf1ISzKlkkqf6TAMfZ1zlhjAuvEpINQPapFdkX3 LLyjeLxidFFGvYxuuHLHbSKYyplQ6igqlO1GQK4nwgL7TVkC6UtjlUQPKNWhszIXWexG e79HWir/OnVLQhkX+l6SiIasMju3bvx8p2fprdL6vjB+s1sd7r4az+xbiICkSI+Pk/cK 3hAA== X-Gm-Message-State: AOAM533zxS77bmcBS74HWIPJjZbcvYR+ngCl5vdFpQr+JOMqRstGiLH6 khRX9V5xEE59e+zy+scFQ70q/zpWTilJsKXwshBW0A== X-Google-Smtp-Source: ABdhPJyYTHXd2SrC9SGFxE2ktHk2dl3UoJFNcRrSZVbTvz8JWMKwrHE3BqN2e3RkLP538tVK3yIoU7ZN4ib1cUV+/Cw= X-Received: by 2002:a17:902:d705:: with SMTP id w5mr5259433ply.34.1644009420472; Fri, 04 Feb 2022 13:17:00 -0800 (PST) MIME-Version: 1.0 References: <20220201071952.900068-1-ira.weiny@intel.com> <20220201071952.900068-3-ira.weiny@intel.com> In-Reply-To: <20220201071952.900068-3-ira.weiny@intel.com> From: Dan Williams Date: Fri, 4 Feb 2022 13:16:49 -0800 Message-ID: Subject: Re: [PATCH V6 02/10] PCI: Replace magic constant for PCI Sig Vendor ID To: "Weiny, Ira" Cc: Jonathan Cameron , Bjorn Helgaas , Alison Schofield , Vishal Verma , Ben Widawsky , Linux Kernel Mailing List , linux-cxl@vger.kernel.org, Linux PCI Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Jan 31, 2022 at 11:20 PM wrote: > > From: Ira Weiny > > Based on Bjorn's suggestion[1], now that the PCI Sig Vendor ID is > defined the define should be used in pci_bus_crs_vendor_id() rather than > the hard coded magic value. > > Replace the magic value in pci_bus_crs_vendor_id() with > PCI_VENDOR_ID_PCI_SIG. > > [1] https://lore.kernel.org/linux-cxl/20211117215044.GA1777828@bhelgaas/ > > Suggested-by: Bjorn Helgaas > Signed-off-by: Ira Weiny > --- > drivers/pci/probe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 087d3658f75c..d92dbb136fc9 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -2318,7 +2318,7 @@ EXPORT_SYMBOL(pci_alloc_dev); > > static bool pci_bus_crs_vendor_id(u32 l) > { > - return (l & 0xffff) == 0x0001; > + return (l & 0xffff) == PCI_VENDOR_ID_PCI_SIG; > } Looks good to me: Reviewed-by: Dan Williams