From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A1DC31E5B for ; Mon, 17 Jun 2019 21:09:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 143C220861 for ; Mon, 17 Jun 2019 21:09:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="1CPoHsv8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726724AbfFQVJg (ORCPT ); Mon, 17 Jun 2019 17:09:36 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:35544 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726741AbfFQVJg (ORCPT ); Mon, 17 Jun 2019 17:09:36 -0400 Received: by mail-ot1-f66.google.com with SMTP id j19so11210304otq.2 for ; Mon, 17 Jun 2019 14:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WJY8mRWNKYbMrxiqtcC6On1cSl2WUj/ZIwS4ootoQak=; b=1CPoHsv8eJYyjii0r2v+tpwEGCkSWwSYtZacx/AqtzGMRs3fZPgZrV7RbEeA45KDwP lsJvq7QgmiqEwVzp5wdQHibzWroOdc9btguH5MJ/BTdcEtQKRrkY2A644oJ5v1entk28 jQX1i10dz7Bzaag9WMXeIi4g9aL/drgYMGhz0EwOOdHkXNcNmVY9Lux9aw2TbX6HsoFA rgd+c/SR//qS9xH7huYep7vdqcSElSiqUL7CnczUCly0wMqqGAQdyboSJvis9joomSOv KyK08LiIatM0igaxt5Yo3ksIlA7sTKvevIo1tgB6DFbvKhgZgBfO8B1hLUl5bdDehAB/ 2KGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WJY8mRWNKYbMrxiqtcC6On1cSl2WUj/ZIwS4ootoQak=; b=qKgQFyJjkTLup1of6EGXxgOvAroaNnAU8sfNLN8napu3M2MRaZcEkDZU0c4tJJSInT RtjL6ZXIfh2oz0yQ786MV9/bDJQQKLXRS6I5PoHofW894mXajSTV/tK2nZl+5S4/wpG2 A9ClyRcOsJkzr7qg8mWwkSQa3K85EOwPLzLJjRoMSqJXJSTKUbXVNlYCQ0pxL9aUu1TI i1uc++Lau1jeF4F7ojg4TKewl+sDZ8aKvfzLfMS6ZdwAc3aMG1eMP0h7tkS+RvB3vPXJ fiOEG/xCu3HYeg36wh5M4JOzUBIEbNy+hG9j1Y/n+6aAYDlMcX9BG9yTNhdkuCdLudqg Sjcw== X-Gm-Message-State: APjAAAUiEvEVEt0pcO6V8OTWz099MToa6WbgaNuWhAsHgM5fJTCydEOJ xP7gHeGXT6AOXeFuUkd5Wgm1/4p1ErL3mYGEC3fjjQ== X-Google-Smtp-Source: APXvYqyAU1TcMvPiGYVYhBbyC0eVXwwhkAqKTWqXoLyuFCBz8f0kthsk9jFJXToSNfs33gSFBQCmV/94ID8R2le9oJQ= X-Received: by 2002:a9d:7a8b:: with SMTP id l11mr55835238otn.247.1560805775819; Mon, 17 Jun 2019 14:09:35 -0700 (PDT) MIME-Version: 1.0 References: <20190617122733.22432-1-hch@lst.de> <20190617122733.22432-9-hch@lst.de> <20190617195526.GB20275@lst.de> In-Reply-To: <20190617195526.GB20275@lst.de> From: Dan Williams Date: Mon, 17 Jun 2019 14:09:24 -0700 Message-ID: Subject: Re: [PATCH 08/25] memremap: move dev_pagemap callbacks into a separate structure To: Christoph Hellwig Cc: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Ben Skeggs , Linux MM , nouveau@lists.freedesktop.org, Maling list - DRI developers , linux-nvdimm , linux-pci@vger.kernel.org, Linux Kernel Mailing List , Logan Gunthorpe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Jun 17, 2019 at 12:59 PM Christoph Hellwig wrote: > > On Mon, Jun 17, 2019 at 10:51:35AM -0700, Dan Williams wrote: > > > - struct dev_pagemap *pgmap =3D _pgmap; > > > > Whoops, needed to keep this line to avoid: > > > > tools/testing/nvdimm/test/iomap.c:109:11: error: =E2=80=98pgmap=E2=80= =99 undeclared > > (first use in this function); did you mean =E2=80=98_pgmap=E2=80=99? > > So I really shouldn't be tripping over this anymore, but can we somehow > this mess? > > - at least add it to the normal build system and kconfig deps instead > of stashing it away so that things like buildbot can build it? > - at least allow building it (under COMPILE_TEST) if needed even when > pmem.ko and friends are built in the kernel? Done: https://patchwork.kernel.org/patch/11000477/