From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D51C433E0 for ; Thu, 4 Feb 2021 21:02:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0B0164F10 for ; Thu, 4 Feb 2021 21:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbhBDVCX (ORCPT ); Thu, 4 Feb 2021 16:02:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229876AbhBDVCR (ORCPT ); Thu, 4 Feb 2021 16:02:17 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27B45C061788 for ; Thu, 4 Feb 2021 13:01:37 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id i8so7916136ejc.7 for ; Thu, 04 Feb 2021 13:01:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3s/yIzssAJEogX8QL3PckAQf7VpPhtvWTp1CrCg9cJI=; b=LVKt1Jlg3viOJCnY9KgBaZrpObq3g8tFou+0PefdJnZLo6tvXDeCkMkUhDvJZ07B3g lTidacUKRZ1vCypk6VTJ5SuTfea3fUaMCdK9Bv8rmr6R/sOHmhRwtZrtxrUoWAo4absE m9RM2D02QLapaVpgAI6iyiLk48DoxHPiWNys7RIl+4fPi1YAqxCWWyoaOecXPrIHAXZ5 hDIRSUEeOz0OSO+pSEfJ1sf+M5TKBhUA6UHdbSMVd+l+GXCRHLNVE3q7aTpK8zJkluMT hfc+Jgi+5RjaJX8OAeCcCvAxwMeDCMboKnHsWrWkYRtZq15chxB+vgbbT3QWMcyKsf6M lkKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3s/yIzssAJEogX8QL3PckAQf7VpPhtvWTp1CrCg9cJI=; b=fEv2ux6S0vlk+xHUMm//25/UL69xARHiabfMNXPgYHnTefvSdDX6eCMwt8KwBZduwU l/nwIvqqJyT7RDq6jubBVJ69wFzyjxS5f9iNqYzdD7JuL1DXuTfuwpZReLYl4sBaTvCO zoyV3aKCPE8+6bMaK4GFqBi9rbRszB15gjDL4rCMKLOOjdtK2mFRHaw73Liih4TL5MEU xD7vOs2SiO5YymjY0GTVjxRP2GrglBGpbDqN1Npxao9Mq3A46SCGdZ/NArZiyqXrudru kJIuuw1IhzdI7MFUYoqrMviCxh7qmhZylAiU0KXxXrEKSrSjqVK+0Wmqjncl6NFRye2Z JmdA== X-Gm-Message-State: AOAM530AIvDYH+BYxLsn9U5KlaIkAcG7W1aLlZDkswxxEteuszEHUS25 LpVBc4Zj3J12XZVy1eRTngppwkQBIQpRRRSdmOnQ+A== X-Google-Smtp-Source: ABdhPJyHp/zY/gWK0OHwxd1OKIX/x+WfdHoU/hR/Dv5qm54B4zuu4eKGOX6BEyUFFddG59yitMp3iDRQpdDKA7E6P3w= X-Received: by 2002:a17:906:d8a1:: with SMTP id qc1mr920058ejb.523.1612472495097; Thu, 04 Feb 2021 13:01:35 -0800 (PST) MIME-Version: 1.0 References: <20210130002438.1872527-1-ben.widawsky@intel.com> <20210130002438.1872527-14-ben.widawsky@intel.com> <20210201182848.GL197521@fedora> <20210202235103.v36v3znh5tsi4g5x@intel.com> <20210203171610.2y2x4krijol5dvkk@intel.com> <20210204185540.oxwurggwd7a37a2o@intel.com> In-Reply-To: <20210204185540.oxwurggwd7a37a2o@intel.com> From: Dan Williams Date: Thu, 4 Feb 2021 13:01:35 -0800 Message-ID: Subject: Re: [PATCH 13/14] cxl/mem: Add limited Get Log command (0401h) To: Ben Widawsky Cc: Konrad Rzeszutek Wilk , linux-cxl@vger.kernel.org, Linux ACPI , Linux Kernel Mailing List , linux-nvdimm , Linux PCI , Bjorn Helgaas , Chris Browy , Christoph Hellwig , Ira Weiny , Jon Masters , Jonathan Cameron , Rafael Wysocki , Randy Dunlap , Vishal Verma , daniel.lll@alibaba-inc.com, "John Groves (jgroves)" , "Kelley, Sean V" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Feb 4, 2021 at 10:56 AM Ben Widawsky wrote: [..] > It actually got pushed into cxl_mem_raw_command_allowed() > > static bool cxl_mem_raw_command_allowed(u16 opcode) > { > int i; > > if (!IS_ENABLED(CONFIG_CXL_MEM_RAW_COMMANDS)) > return false; > > if (security_locked_down(LOCKDOWN_NONE)) > return false; > > if (raw_allow_all) > return true; > > if (is_security_command(opcode)) > return false; > > for (i = 0; i < ARRAY_SIZE(disabled_raw_commands); i++) > if (disabled_raw_commands[i] == opcode) > return false; > > return true; > } > > That work for you? Looks good to me.