From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F71313B5A6 for ; Wed, 24 Apr 2024 04:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713932915; cv=none; b=U7i3zFfJlWG45Agy7eQv6UlavtpNZyLD73yZCEifNEYtwje6WFAFl6NMlhNiwgLyBYroaa5b9ePg3X3hMNLkDV7HxAV812TSRh9LBv3xRSjs7IrDCntD4mSqtOEY5ocdKdJAuEanhpy5GT8AH/YNr85jfNVXmoeiASSsvcYd874= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713932915; c=relaxed/simple; bh=SVlBsh+OtGzs8Wz8fbFQpOEK85w5Obn5WGl0/vqVgpE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=IqGgATx6/Jh+HdCKhwe2bcumMhVrWPM1M+CCQVbGSXwBrflI1jmDTTh+wg+xNGi4I71opNugW6xwker1K63PkjL/6r8/KcAFOwoGjQOxik1uiU60mqNAkxM4ITrhPiRg+HAJnD2wblP0ekBG7b3b5019rYkMP2fSkRy06uv1WWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=endlessos.org; spf=pass smtp.mailfrom=endlessos.org; dkim=pass (2048-bit key) header.d=endlessos.org header.i=@endlessos.org header.b=t7FgfskB; arc=none smtp.client-ip=209.85.219.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=endlessos.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=endlessos.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=endlessos.org header.i=@endlessos.org header.b="t7FgfskB" Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-dcc6fc978ddso500706276.0 for ; Tue, 23 Apr 2024 21:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessos.org; s=google; t=1713932913; x=1714537713; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MvX5ZYnBGyHu2whyk5II8GGcdhq7ix0Hf+Bdyx6MY/I=; b=t7FgfskBYzOs7VRYTqgQgkWKMmCAJ04cv0dCJNem+2vSGrb0UQnJLu1yypQmkJ5rob bMNU+UrCzIhzmBb9b5REd1BEVgGnW0u8dwmtHdREZ/uudX7EpT61VS1n96xIwrna7Xg0 1dEe9vw+pKtf6in0+lNXZ6mx/ga0ZuDYfm6Ae8xpK3COEz4pogeLuHVudumSHKliV8Xv n82dDR5SUraRm+1DmnXjK261P3FDCWAl+aarjbMlEUWmz0S79aeokbxX8lHe7oXbuVNy 1CL5XV1cfBxq+tU8W82v6CyuE1l/jhYXEZXOx39SS7OFZb60ZK2+eJ1JzW50XYcItYTt jT8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713932913; x=1714537713; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MvX5ZYnBGyHu2whyk5II8GGcdhq7ix0Hf+Bdyx6MY/I=; b=VxT2+tgZrlWw3dpNSx86VUVbopY1K3T5HOIis4L/CkWjitmbbmMwKDZ+hKGLV5+AoA ZvCLdWNJWTLQTWsR3vDCP84x7jTJLij66GUMjci/MqItIUGN22zw4f1qy5k5OVDtOAjm /iJWOAMeZAZ6XEB6jwWvU2vgS67o/FWRO4k3gK9nzRGMDt/9kb0rtw+EgQh9HgAcfo8i JH0BzKYhhC/qVzFxBv9P1TOwv3+egxMmSDcG1695gGnGPB5a2nS0dXem3a58GRJHeHhY +dzNbNHRX257W+GhciLED8oTTVwKAOLh4U3ypw6TByA5vsup6WbV2D6plEwUxbOL0Tbf lDAA== X-Forwarded-Encrypted: i=1; AJvYcCX7PatgwAzFojVp0x5HaRqjvCmv0uD2KJxR88Cv9WemSL2kB8kB41ISdmckkWR/4PjAh2X/fVgSjAI87v0fdxuykqbbvHb3DgP6 X-Gm-Message-State: AOJu0YxSD8KVBmC9EMN8lYa2rZT9uLVYtFHpnqpyscX+nvlpKTYsc8/G ixlLnc/z8uDVNH2UipxKKwBqWrKbGYFdvdufm1LKXyTk7cp9/+dBSAdRn8aqZiQpwCD4IptI0P+ QNj/EggTsw+SB+rZUUWCwUpJh/tTeFaIFqAudcw== X-Google-Smtp-Source: AGHT+IEgApdXc0FTtI/Xj8zQmgelnm3yr/jZQQiEnnLxc8JkipkVIQosbx1ZbD1ANvA85SasBfj8sm5x8fx4Ig2fyKk= X-Received: by 2002:a25:fc22:0:b0:dc7:421d:bcc0 with SMTP id v34-20020a25fc22000000b00dc7421dbcc0mr968151ybd.32.1713932913048; Tue, 23 Apr 2024 21:28:33 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240216062642.247504-3-jhp@endlessos.org> <20240301214117.GA408641@bhelgaas> In-Reply-To: <20240301214117.GA408641@bhelgaas> From: Jian-Hong Pan Date: Wed, 24 Apr 2024 12:27:57 +0800 Message-ID: Subject: Re: [PATCH v4 3/3] PCI/ASPM: Fix L1.2 parameters when enable link state To: Bjorn Helgaas Cc: Johan Hovold , David Box , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Kuppuswamy Sathyanarayanan , Mika Westerberg , Damien Le Moal , Nirmal Patel , Jonathan Derrick , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux@endlessos.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Bjorn Helgaas =E6=96=BC 2024=E5=B9=B43=E6=9C=882=E6=97= =A5 =E9=80=B1=E5=85=AD =E4=B8=8A=E5=8D=885:41=E5=AF=AB=E9=81=93=EF=BC=9A > > In subject: > > PCI/ASPM: Fix L1.2 parameters before enabling L1.2 > > > + if (state & link->aspm_capable & ASPM_STATE_L1_2_MASK) { > > + parent_l1ss_cap =3D aspm_get_l1ss_cap(parent); > > + child_l1ss_cap =3D aspm_get_l1ss_cap(child); > > + aspm_calc_l12_info(link, parent_l1ss_cap, child_l1ss_cap)= ; > > Why doesn't this happen already via normal enumeration? It looks like > this path should do it even without this patch: > > pcie_aspm_init_link_state > pcie_aspm_cap_init > aspm_l1ss_init I watch the VMD remapped PCI devices' power states during this path. Their power states stay at "unknown" until someone sets their power state to "D0". And, because their power states stay at "unknown", the L1.2 of the link between VMD remapped PCIe Root Port and NVMe gets wrong configs when system goes through this path. So, system has to calculate the L1.2 information again after set PCI devices' power state to D0. Sorry for the late reply. Got my laptop back recently. Jian-Hong Pan > > + } > > pcie_config_aspm_link(link, policy_to_aspm_state(link)); > > > > link->clkpm_default =3D (state & PCIE_LINK_STATE_CLKPM) ? 1 : 0; > > -- > > 2.43.2 > >