From: Bharat Kumar Gogada <bharatku@xilinx.com>
To: "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Ravikiran Gummaluri <rgummal@xilinx.com>
Subject: RE: [PATCH v4] PCI: xilinx-nwl: Fix Multi MSI data programming
Date: Tue, 18 Jun 2019 12:28:02 +0000 [thread overview]
Message-ID: <CH2PR02MB6453032A01A540F5E9C58402A5EA0@CH2PR02MB6453.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20190617092108.GA18020@e121166-lin.cambridge.arm.com>
>
> On Wed, Jun 12, 2019 at 03:47:59PM +0530, Bharat Kumar Gogada wrote:
> > The current Multi MSI data programming fails if multiple end points
> > requesting MSI and multi MSI are connected with switch, i.e the
> > current multi MSI data being given is not considering the number of
> > vectors being requested in case of multi MSI.
> > Ex: Two EP's connected via switch, EP1 requesting single MSI first,
> > EP2 requesting Multi MSI of count four. The current code gives MSI
> > data 0x0 to EP1 and 0x1 to EP2, but EP2 can modify lower two bits due
> > to which EP2 also sends interrupt with MSI data 0x0 which results in
> > always invoking virq of EP1 due to which EP2 MSI interrupt never gets
> > handled.
> >
> > Fix Multi MSI data programming with required alignment by using number
> > of vectors being requested.
> >
> > Fixes: ab597d35ef11 ("PCI: xilinx-nwl: Add support for Xilinx NWL PCIe
> > Host Controller")
> >
> > Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
> > ---
> > V4:
> > - Using a different bitmap registration API whcih serves single and multi
> > MSI requests.
> > ---
> > drivers/pci/controller/pcie-xilinx-nwl.c | 11 +++++------
> > 1 file changed, 5 insertions(+), 6 deletions(-)
>
> Applied to pci/xilinx for v5.3, please have a look and check if the commit log
> I wrote provides a clear description of the issue.
>
> Lorenzo
Thanks Lorenzo and Marc.
Lorenzo, can you please point to link for above commit.
Regards,
Bharat
> > diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c
> > b/drivers/pci/controller/pcie-xilinx-nwl.c
> > index 81538d7..a9e07b8 100644
> > --- a/drivers/pci/controller/pcie-xilinx-nwl.c
> > +++ b/drivers/pci/controller/pcie-xilinx-nwl.c
> > @@ -483,15 +483,13 @@ static int nwl_irq_domain_alloc(struct
> irq_domain *domain, unsigned int virq,
> > int i;
> >
> > mutex_lock(&msi->lock);
> > - bit = bitmap_find_next_zero_area(msi->bitmap, INT_PCI_MSI_NR, 0,
> > - nr_irqs, 0);
> > - if (bit >= INT_PCI_MSI_NR) {
> > + bit = bitmap_find_free_region(msi->bitmap, INT_PCI_MSI_NR,
> > + get_count_order(nr_irqs));
> > + if (bit < 0) {
> > mutex_unlock(&msi->lock);
> > return -ENOSPC;
> > }
> >
> > - bitmap_set(msi->bitmap, bit, nr_irqs);
> > -
> > for (i = 0; i < nr_irqs; i++) {
> > irq_domain_set_info(domain, virq + i, bit + i, &nwl_irq_chip,
> > domain->host_data, handle_simple_irq, @@
> -509,7 +507,8 @@ static
> > void nwl_irq_domain_free(struct irq_domain *domain, unsigned int virq,
> > struct nwl_msi *msi = &pcie->msi;
> >
> > mutex_lock(&msi->lock);
> > - bitmap_clear(msi->bitmap, data->hwirq, nr_irqs);
> > + bitmap_release_region(msi->bitmap, data->hwirq,
> > + get_count_order(nr_irqs));
> > mutex_unlock(&msi->lock);
> > }
> >
> > --
> > 2.7.4
> >
next prev parent reply other threads:[~2019-06-18 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 10:17 [PATCH v4] PCI: xilinx-nwl: Fix Multi MSI data programming Bharat Kumar Gogada
2019-06-12 13:01 ` Marc Zyngier
2019-06-12 16:31 ` Lorenzo Pieralisi
2019-06-17 9:21 ` Lorenzo Pieralisi
2019-06-18 12:28 ` Bharat Kumar Gogada [this message]
2019-06-18 13:03 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR02MB6453032A01A540F5E9C58402A5EA0@CH2PR02MB6453.namprd02.prod.outlook.com \
--to=bharatku@xilinx.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=rgummal@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).