From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D07C5519F for ; Wed, 25 Nov 2020 11:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E934206E5 for ; Wed, 25 Nov 2020 11:02:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=emerson.onmicrosoft.com header.i=@emerson.onmicrosoft.com header.b="aqSR/0pd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726060AbgKYLCV (ORCPT ); Wed, 25 Nov 2020 06:02:21 -0500 Received: from mx0b-00300601.pphosted.com ([148.163.142.35]:15862 "EHLO mx0b-00300601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbgKYLCV (ORCPT ); Wed, 25 Nov 2020 06:02:21 -0500 X-Greylist: delayed 6358 seconds by postgrey-1.27 at vger.kernel.org; Wed, 25 Nov 2020 06:02:16 EST Received: from pps.filterd (m0144092.ppops.net [127.0.0.1]) by mx0b-00300601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0AP9E9ph088366; Wed, 25 Nov 2020 09:16:10 GMT Received: from nam04-bn3-obe.outbound.protection.outlook.com (mail-bn3nam04lp2050.outbound.protection.outlook.com [104.47.46.50]) by mx0b-00300601.pphosted.com with ESMTP id 351e4mcg6e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Nov 2020 09:16:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E4gekNCheX0QSiJT1yxZbU2BDTPhUK5y73Icstvdu76wvONiHiyGmCTJ0mdWMAmTQMbxog0fmwCZOi3oZ8WfCB+Ah+igEc4tr9Y0ojJ28J5I3o9cKrs6UMYwQwfMGUDYgGqW4HBTFG/dsBbs4e6GlRJsk9io9vdRM5uZX4h+a4+ojAmQ1TxFNByw3Xx0Fzthr+ne84I1d8w3amHXn86lht3PNZE/LXjEl3nUPIGXWwzKLYEQTHm6WeO/EWnYDG6CAkGKyhTBZ5641lVa6gYI5GhzT6BkDSHRTTtyYw1cfbrlLWgmmvkMBB6YempAklwHBc9LYhOztGPVZZ6rlyZmiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z0DaMUocztlFAGrTNZPdxR0XutkZtlufmJrNP0tngqI=; b=e7Qj6mhl0JNmhgUnN+WvBeNAUsBrfy76vFptPO1rCaWbB8FqDYhROb9W/uw38RjDVowEv+JR1suQMzQrhf38cpid/SMr31oRfZIYBz6TZ2E46BGa4wfyLWucmq6hVChTqtS4ZQ0SJgXeSx4atUb4ZiKTUObNqblBGws8/lo/RqnUWeidreXKXJ81dyd9MHSPY8FIw4zc2lLelxO27y20y9FKZNwrmRBK4ikpy6CASJjYckVoGtQhqEXdHh0klgbBgOR6/e+oC0GDsaltVYCg3cDmQmC4oLdixpn2OFlaT/hLb9p4YZLBkVmDlL1cZuKDhIKww5rcnn+hDVj5gLJCDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=emerson.com; dmarc=pass action=none header.from=emerson.com; dkim=pass header.d=emerson.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emerson.onmicrosoft.com; s=selector2-emerson-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z0DaMUocztlFAGrTNZPdxR0XutkZtlufmJrNP0tngqI=; b=aqSR/0pdIUAsou+DOdo6h+axagWK0UzV7x0/053TnvlOdnks2jWzJWzWav3z2rTSUl+lcLPwdndj5BmTFvL+8Ul7LRqMCATaC2Vp2HPn1crfk8QONo5BOFj4uljXrwBP2/T5zRfDuPuiXfoBkDK8Tp3ZM6DbhaFBcEZ1+Oj5YO0= Received: from CY4PR10MB1302.namprd10.prod.outlook.com (2603:10b6:903:27::20) by CY4PR1001MB2136.namprd10.prod.outlook.com (2603:10b6:910:44::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Wed, 25 Nov 2020 09:16:08 +0000 Received: from CY4PR10MB1302.namprd10.prod.outlook.com ([fe80::cc0f:603d:d66b:110e]) by CY4PR10MB1302.namprd10.prod.outlook.com ([fe80::cc0f:603d:d66b:110e%8]) with mapi id 15.20.3589.030; Wed, 25 Nov 2020 09:16:08 +0000 From: "Merger, Edgar [AUTOSOL/MAS/AUGS]" To: "Deucher, Alexander" , "Huang, Ray" , "Kuehling, Felix" CC: Will Deacon , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Bjorn Helgaas , Joerg Roedel , "Zhu, Changfeng" Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as broken Thread-Topic: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as broken Thread-Index: AQHWwdw3n5VLcueYHUSP0T6AMdoDgKnWTbwAgAAE0oCAAIPUgIAACwGQgACBfgCAAPBvUIAAPe5g Date: Wed, 25 Nov 2020 09:16:07 +0000 Message-ID: References: <20201123134410.10648-1-will@kernel.org> <20201123223356.GC12069@willie-the-truck> <218017ab-defd-c77d-9055-286bf49bee86@amd.com> <20201124064301.GA536919@hr-amd> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-11-24T15:01:54Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=de2f7a10-55c4-48b3-9a56-00005e730a8e; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=emerson.com; x-originating-ip: [194.140.114.18] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 977bb077-65c4-4d54-f1f0-08d89122be4a x-ms-traffictypediagnostic: CY4PR1001MB2136: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p8N7KARXF/imybPe2K5DTw91OQAbQomyjm8thkypfRa05n0J6Dx7fJs6zidhoPghtGSHHuPlVEC8VK4rhLTysbFZ1jEqnd5L5DgVY6nPlilwH0jdPY1NFL8nZbEfG4LAEla9T3i0ND/bK2mYSs2J76qga5Et/InBbzMTppFeK/GFOkH6+gsb+dFP+wuTb6HB9U/O8cQUaEhioxHbvbDnk6PtNPL/TwAWGapd/s5/LYAPfb8j2luWIHAQX2mqAJ9WBkutDYP3AMnlN7VbACzaxORTIOvp65era4xUJ83wBb0lzH8aOw7d1pP99QjCvyZDaVa+1IXBsMkD1UsN3nKbmoh5GZFY7qfYUK5Kqu4TCcT2VoQfet6zmiPcq8FwQlHQGjb200YfzrueDn9wgzZL7d3TayLeQH2SjVGuxLTBM4daipoNKzIt666pKuv8JqRAhRkuyRDDdFblKOyuEJ8kFA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR10MB1302.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(346002)(396003)(39860400002)(376002)(136003)(2906002)(6506007)(53546011)(9686003)(86362001)(83380400001)(4326008)(478600001)(8936002)(26005)(45080400002)(316002)(4001150100001)(30864003)(7696005)(7416002)(71200400001)(66946007)(8676002)(76116006)(186003)(66446008)(54906003)(55016002)(52536014)(66556008)(5660300002)(966005)(110136005)(33656002)(64756008)(66476007)(19627235002)(505234006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?Mwpr/cqj2VzP/RlyXj3BT0bNQfvQcNyWp5og6I670JgdlAiiGm1f2QqPlG?= =?iso-8859-1?Q?rL6l8YiwfPVztGFcpG0LThjnze8kaWt/s9J6aRLvWtfv/tz+h2+N07YJEg?= =?iso-8859-1?Q?del8p7QU3tEorEW9/lqblafWhwiXrFuLAqyjH6yo3YdxFym84XkWAoPDQa?= =?iso-8859-1?Q?Htd3zjaxFTqgBmAQyU7WIjbuqMRjyjz3Nb3v2QCVd7krIYY0li/q/PGkAL?= =?iso-8859-1?Q?GL75y/2FYD5VZGfmOD7EOp6E+7K9Z83cG9LWUlWbKGgQw4/R3WYdexQ/Sd?= =?iso-8859-1?Q?YreazRgQH0EYM7R7nnxlsmwGydaH95wAac3DYkbGJoj2RnZUsTxZzyjNC3?= =?iso-8859-1?Q?Vm55cxp5OTEvRECPxdiSTXNUTHuRDZFTlYFcz4Xr2oLPJl3U3CAuuLpTuA?= =?iso-8859-1?Q?QHsfIwKn6LXp11GNN+wMzZ0bnKqlUMaxDVTRxupwhiokdOyiBn+I0EYfgm?= =?iso-8859-1?Q?+rUGUwv2AyEYKg/7k2zz7TLHBbXPSLILX5De4HOmrYBD1OHLfuS94EZfUQ?= =?iso-8859-1?Q?Huheu3ZIOYDhg85F0rwD+HS4OwSyxIfIms5X3FN54X4eV89A4p3CCEwBGP?= =?iso-8859-1?Q?F2aBM9K1ENFu73d7BPxVJirIcwrRGWnEae1DfAZrhnfzHxIa/uIAHA1R19?= =?iso-8859-1?Q?jJXRXaZ7cObN3i8ZN/DhYqNA/zcXHvEhXLak0kF/sMxlo/NW70RMK6EgPw?= =?iso-8859-1?Q?M/lLLv/crNqPg8k3MIVfEK31CoY5KJfW0JIqcUbP6QtuNWmMF0gRm24tEg?= =?iso-8859-1?Q?JQndB5ouOASOb4GtDTfHLJuh4CoIp/HF5Z4v3/YVgpujVCQP6Kw3b6l7AK?= =?iso-8859-1?Q?9Mr2WlrNSIWjv84e7NnCq1/5eoLioizpqMhKUing2eDBDj97U4Zl7q5FYa?= =?iso-8859-1?Q?xsfxWQZ2PrsWVnNyZJkkd+vB6De9Lc/wyu/tgqVUUSbG6G6hTb/275BSaw?= =?iso-8859-1?Q?cTRkUbwtWvCqUUxKduJlBhNSCSyOoHhg836QYXBCwU7OGyROkq8nnjimRO?= =?iso-8859-1?Q?yIUGWgqdRmVj0qHQU=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Emerson.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR10MB1302.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 977bb077-65c4-4d54-f1f0-08d89122be4a X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2020 09:16:07.9343 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: eb06985d-06ca-4a17-81da-629ab99f6505 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6Lo6hUbWzhuQXp57KZzt24NefcxJHbVus82Ph37rDk05uvPiVQse049Xo+SWR638sIXjlk+NKrxovtJPTdWhK7ahsdOAX7Ycx47ZWxn/VCQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2136 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-25_04:2020-11-25,2020-11-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011250056 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Remark:=20 Systems with R1305G APU (which show the issue) have the following VGA-Contr= oller: 0b:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] P= icasso (rev cf) Systems with V1404I APU (which do not show the issue) have the following VG= A-Controller: 0b:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] R= aven Ridge [Radeon Vega Series / Radeon Vega Mobile Series] (rev 83) "rev cf" vs. "ref 83" is probably what you where referring to with PCI Revi= sion ID. -----Original Message----- From: Merger, Edgar [AUTOSOL/MAS/AUGS]=20 Sent: Mittwoch, 25. November 2020 07:05 To: 'Deucher, Alexander' ; Huang, Ray ; Kuehling, Felix Cc: Will Deacon ; linux-kernel@vger.kernel.org; linux-pci@= vger.kernel.org; iommu@lists.linux-foundation.org; Bjorn Helgaas ; Joerg Roedel ; Zhu, Changfeng Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as broken I see that problem only on systems that use a R1305G APU sudo cat /sys/kernel/debug/dri/0/amdgpu_firmware_info shows VCE feature version: 0, firmware version: 0x00000000 UVD feature version: 0= , firmware version: 0x00000000 MC feature version: 0, firmware version: 0x0= 0000000 ME feature version: 50, firmware version: 0x000000a3 PFP feature ve= rsion: 50, firmware version: 0x000000bb CE feature version: 50, firmware ve= rsion: 0x0000004f RLC feature version: 1, firmware version: 0x00000049 RLC = SRLC feature version: 1, firmware version: 0x00000001 RLC SRLG feature vers= ion: 1, firmware version: 0x00000001 RLC SRLS feature version: 1, firmware = version: 0x00000001 MEC feature version: 50, firmware version: 0x000001b5 MEC2 feature version: 50, firmware version: 0x000001b5 SOS feature version:= 0, firmware version: 0x00000000 ASD feature version: 0, firmware version: = 0x21000030 TA XGMI feature version: 0, firmware version: 0x00000000 TA RAS = feature version: 0, firmware version: 0x00000000 SMC feature version: 0, fi= rmware version: 0x00002527 SDMA0 feature version: 41, firmware version: 0x000000a9 VCN feature version= : 0, firmware version: 0x0110901c DMCU feature version: 0, firmware version= : 0x00000001 VBIOS version: 113-RAVEN2-117 We are also using V1404I APU on the same boards and I haven=B4t seen the is= sue on those boards These boards give me slightly different info: sudo cat /sys/kernel/debug/dr= i/0/amdgpu_firmware_info =20 VCE feature version: 0, firmware version: 0x00000000 UVD feature version: 0= , firmware version: 0x00000000 MC feature version: 0, firmware version: 0x0= 0000000 ME feature version: 47, firmware version: 0x000000a2 PFP feature ve= rsion: 47, firmware version: 0x000000b9 CE feature version: 47, firmware ve= rsion: 0x0000004e RLC feature version: 1, firmware version: 0x00000213 RLC = SRLC feature version: 1, firmware version: 0x00000001 RLC SRLG feature vers= ion: 1, firmware version: 0x00000001 RLC SRLS feature version: 1, firmware = version: 0x00000001 MEC feature version: 47, firmware version: 0x000001ab MEC2 feature version: 47, firmware version: 0x000001ab SOS feature version:= 0, firmware version: 0x00000000 ASD feature version: 0, firmware version: = 0x21000013 TA XGMI feature version: 0, firmware version: 0x00000000 TA RAS = feature version: 0, firmware version: 0x00000000 SMC feature version: 0, fi= rmware version: 0x00001e5b SDMA0 feature version: 41, firmware version: 0x000000a9 VCN feature version= : 0, firmware version: 0x0110901c DMCU feature version: 0, firmware version= : 0x00000000 VBIOS version: 113-RAVEN-116 00:00.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Root C= omplex 00:00.2 IOMMU: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 IOMMU 00:01.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 17h (Models = 00h-1fh) PCIe Dummy Host Bridge 00:01.1 PCI bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 PCIe GP= P Bridge [6:0] 00:01.2 PCI bridge: Advanced Micro Devices, Inc. [AMD] Zeppelin Switch Upst= ream (PCIE SW.US) 00:01.4 PCI bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 PCIe GP= P Bridge [6:0] 00:01.5 PCI bridge: Advanced Micro Devices, Inc. [AMD] Zeppelin Switch Upst= ream (PCIE SW.US) 00:08.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 17h (Models = 00h-1fh) PCIe Dummy Host Bridge 00:08.1 PCI bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Interna= l PCIe GPP Bridge 0 to Bus A 00:08.2 PCI bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Interna= l PCIe GPP Bridge 0 to Bus B 00:14.0 SMBus: Advanced Micro Devices, Inc. [AMD] FCH SMBus Controller (rev= 61) 00:14.3 ISA bridge: Advanced Micro Devices, Inc. [AMD] FCH LPC Bridge (rev = 51) 00:18.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Device= 24: Function 0 00:18.1 Host bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Device= 24: Function 1 00:18.2 Host bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Device= 24: Function 2 00:18.3 Host bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Device= 24: Function 3 00:18.4 Host bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Device= 24: Function 4 00:18.5 Host bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Device= 24: Function 5 00:18.6 Host bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Device= 24: Function 6 00:18.7 Host bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Device= 24: Function 7 01:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8= 411 PCI Express Gigabit Ethernet Controller (rev 0e) 01:00.1 Serial controller: Realtek Semiconductor Co., Ltd. Device 816a (rev= 0e) 01:00.2 Serial controller: Realtek Semiconductor Co., Ltd. Device 816b (rev= 0e) 01:00.3 IPMI Interface: Realtek Semiconductor Co., Ltd. Device 816c (rev 0e= ) 01:00.4 USB controller: Realtek Semiconductor Co., Ltd. Device 816d (rev 0e= ) 02:00.0 Ethernet controller: Intel Corporation I210 Gigabit Network Connect= ion (rev 03) 03:00.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 6-Port/8-Lane= Packet Switch 04:01.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 6-Port/8-Lane= Packet Switch 04:02.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 6-Port/8-Lane= Packet Switch 04:03.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 6-Port/8-Lane= Packet Switch 04:04.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 6-Port/8-Lane= Packet Switch 04:05.0 PCI bridge: Pericom Semiconductor PI7C9X2G608GP PCIe2 6-Port/8-Lane= Packet Switch 06:00.0 Serial controller: Asix Electronics Corporation Device 9100 06:00.1 Serial controller: Asix Electronics Corporation Device 9100 07:00.0 Ethernet controller: Intel Corporation I210 Gigabit Network Connect= ion (rev 03) 0a:00.0 Ethernet controller: Intel Corporation I210 Gigabit Network Connect= ion (rev 03) 0b:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] P= icasso (rev cf) 0b:00.1 Audio device: Advanced Micro Devices, Inc. [AMD/ATI] Raven/Raven2/F= enghuang HDMI/DP Audio Controller 0b:00.2 Encryption controller: Advanced Micro Devices, Inc. [AMD] Family 17= h (Models 10h-1fh) Platform Security Processor 0b:00.3 USB controller: Advanced Micro Devices, Inc. [AMD] Raven2 USB 3.1 0b:00.5 Multimedia controller: Advanced Micro Devices, Inc. [AMD] Raven/Rav= en2/FireFlight/Renoir Audio Processor 0b:00.7 Non-VGA unclassified device: Advanced Micro Devices, Inc. [AMD] Rav= en/Raven2/Renoir Non-Sensor Fusion Hub KMDF driver 0c:00.0 SATA controller: Advanced Micro Devices, Inc. [AMD] FCH SATA Contro= ller [AHCI mode] (rev 61) PCI Revision ID is 06 I believe. Got that from this lspci -xx 00:01.2 PCI bridge: Advanced Micro Devices, Inc. [AMD] Zeppelin Switch Upst= ream (PCIE SW.US) 00: 22 10 5d 14 07 04 10 00 00 00 04 06 10 00 81 00 10: 00 00 00 00 00 00 00 00 00 02 02 00 f1 01 00 00 20: e0 fc e0 fc f1 ff 01 00 00 00 00 00 00 00 00 00 30: 00 00 00 00 50 00 00 00 00 00 00 00 ff 00 12 00 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 50: 01 58 03 c8 00 00 00 00 10 a0 42 01 22 80 00 00 60: 1f 29 00 00 13 38 73 03 42 00 11 30 00 00 04 00 70: 00 00 40 01 18 00 01 00 00 00 00 00 bf 01 70 00 80: 06 00 00 00 0e 00 00 00 03 00 01 00 00 00 00 00 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 a0: 05 c0 81 00 00 00 e0 fe 00 00 00 00 00 00 00 00 b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 c0: 0d c8 00 00 22 10 34 12 08 00 03 a8 00 00 00 00 d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 e0: 00 00 00 00 4c 8a 05 00 00 00 00 00 00 00 00 00 f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -----Original Message----- From: Deucher, Alexander Sent: Dienstag, 24. November 2020 16:06 To: Merger, Edgar [AUTOSOL/MAS/AUGS] ; Huang, Ray= ; Kuehling, Felix Cc: Will Deacon ; linux-kernel@vger.kernel.org; linux-pci@= vger.kernel.org; iommu@lists.linux-foundation.org; Bjorn Helgaas ; Joerg Roedel ; Zhu, Changfeng Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as broken [AMD Public Use] > -----Original Message----- > From: Merger, Edgar [AUTOSOL/MAS/AUGS] > Sent: Tuesday, November 24, 2020 2:29 AM > To: Huang, Ray ; Kuehling, Felix=20 > > Cc: Will Deacon ; Deucher, Alexander=20 > ; linux-kernel@vger.kernel.org; linux-=20 > pci@vger.kernel.org; iommu@lists.linux-foundation.org; Bjorn Helgaas=20 > ; Joerg Roedel ; Zhu, Changfeng=20 > > Subject: RE: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as=20 > broken >=20 > Module Version : PiccasoCpu 10 > AGESA Version : PiccasoPI 100A >=20 > I did not try to enter the system in any other way (like via ssh) than=20 > via Desktop. You can get this information from the amdgpu driver. E.g., sudo cat /sys/k= ernel/debug/dri/0/amdgpu_firmware_info . Also what is the PCI revision id = of your chip (from lspci)? Also are you just seeing this on specific versi= ons of the sbios? Thanks, Alex >=20 > -----Original Message----- > From: Huang Rui > Sent: Dienstag, 24. November 2020 07:43 > To: Kuehling, Felix > Cc: Will Deacon ; Deucher, Alexander=20 > ; linux-kernel@vger.kernel.org; linux-=20 > pci@vger.kernel.org; iommu@lists.linux-foundation.org; Bjorn Helgaas=20 > ; Merger, Edgar [AUTOSOL/MAS/AUGS]=20 > ; Joerg Roedel ; Changfeng=20 > Zhu > Subject: [EXTERNAL] Re: [PATCH] PCI: Mark AMD Raven iGPU ATS as broken >=20 > On Tue, Nov 24, 2020 at 06:51:11AM +0800, Kuehling, Felix wrote: > > On 2020-11-23 5:33 p.m., Will Deacon wrote: > > > On Mon, Nov 23, 2020 at 09:04:14PM +0000, Deucher, Alexander wrote: > > >> [AMD Public Use] > > >> > > >>> -----Original Message----- > > >>> From: Will Deacon > > >>> Sent: Monday, November 23, 2020 8:44 AM > > >>> To: linux-kernel@vger.kernel.org > > >>> Cc: linux-pci@vger.kernel.org; iommu@lists.linux-foundation.org;=20 > > >>> Will Deacon ; Bjorn Helgaas=20 > > >>> ; Deucher, Alexander=20 > > >>> ; Edgar Merger=20 > > >>> ; Joerg Roedel > > >>> Subject: [PATCH] PCI: Mark AMD Raven iGPU ATS as broken > > >>> > > >>> Edgar Merger reports that the AMD Raven GPU does not work=20 > > >>> reliably on his system when the IOMMU is enabled: > > >>> > > >>> | [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx=20 > > >>> timeout, signaled seq=3D1, emitted seq=3D3 > > >>> | [...] > > >>> | amdgpu 0000:0b:00.0: GPU reset begin! > > >>> | AMD-Vi: Completion-Wait loop timed out > > >>> | iommu ivhd0: AMD-Vi: Event logged [IOTLB_INV_TIMEOUT > > >>> device=3D0b:00.0 address=3D0x38edc0970] > > >>> > > >>> This is indicative of a hardware/platform configuration issue=20 > > >>> so, since disabling ATS has been shown to resolve the problem,=20 > > >>> add a quirk to match this particular device while Edgar=20 > > >>> follows-up with AMD > for more information. > > >>> > > >>> Cc: Bjorn Helgaas > > >>> Cc: Alex Deucher > > >>> Reported-by: Edgar Merger > > >>> Suggested-by: Joerg Roedel > > >>> Link: > > >>> > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__nam11.safelinks.p > rotection.outlook.com_-3Furl-3Dhttps-253A-252F-252Furld&d=3DDwIFAw&c=3DjO= U > RTkCZzT8tVB5xPEYIm3YJGoxoTaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_-862rdSP1 > 3_P6LVp7j_9l1xmg&m=3DMMI_EgCqeOX4EvIftpL7agRxJ-udp1CLokf2QWuzFgE&s=3DZLdz= 6 > OgavzNn2vSzsgyL1IB6MbK7hPKavOYwbLhyTPU&e=3D > efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > 3A__lore%26d%3DDwIDAw%26c%3DjOURTkCZzT8tVB5xPEYIm3YJGoxoTaQs > QPzPKJGaWbo%26r%3DBJxhacqqa4K1PJGm6_- > 862rdSP13_P6LVp7j_9l1xmg%26m%3DlNXu2xwvyxEZ3PzoVmXMBXXS55jsmf > DicuQFJqkIOH4%26s%3D_5VDNCRQdA7AhsvvZ3TJJtQZ2iBp9c9tFHIleTYT_ZM > %26e%3D&data=3D04%7C01%7CAlexander.Deucher%40amd.com%7C6d5f > a241f9634692c03908d8904a942c%7C3dd8961fe4884e608e11a82d994e183d%7 > C0%7C0%7C637417997272974427%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi > MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C100 > 0&sdata=3DOEgYlw%2F1YP0C%2FnWBRQUxwBH56mGOJxYMWSQ%2Fj1Y > 9f6Q%3D&reserved=3D0 . > > >>> kernel.org/linux- > > >>> > iommu/MWHPR10MB1310F042A30661D4158520B589FC0@MWHPR10M > > >>> B1310.namprd10.prod.outlook.com > > >>> > her%40amd.com%7C1a883fe14d0c408e7d9508d88fb5df4e%7C3dd8961fe488 > > >>> > 4e608e11a82d994e183d%7C0%7C0%7C637417358593629699%7CUnknown%7 > > >>> > CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi > > >>> > LCJXVCI6Mn0%3D%7C1000&sdata=3DTMgKldWzsX8XZ0l7q3%2BszDWXQJJ > > >>> LOUfX5oGaoLN8n%2B8%3D&reserved=3D0 > > >>> Signed-off-by: Will Deacon > > >>> --- > > >>> > > >>> Hi all, > > >>> > > >>> Since Joerg is away at the moment, I'm posting this to try to=20 > > >>> make some progress with the thread in the Link: tag. > > >> + Felix > > >> > > >> What system is this? Can you provide more details? Does a sbios=20 > > >> update fix this? Disabling ATS for all Ravens will break GPU=20 > > >> compute for a lot of people. I'd prefer to just black list this=20 > > >> particular system (e.g., just SSIDs or revision) if possible. > > > > +Ray > > > > There are already many systems where the IOMMU is disabled in the=20 > > BIOS, or the CRAT table reporting the APU compute capabilities is=20 > > broken. Ray has been working on a fallback to make APUs behave like=20 > > dGPUs on such systems. That should also cover this case where ATS is=20 > > blacklisted. That said, it affects the programming model, because we=20 > > don't support the unified and coherent memory model on dGPUs like we=20 > > do on APUs with IOMMUv2. So it would be good to make the conditions=20 > > for this workaround as narrow as possible. >=20 > Yes, besides the comments from Alex and Felix, may we get your=20 > firmware version (SMC firmware which is from SBIOS) and device id? >=20 > > >>> | [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx=20 > > >>> timeout, signaled seq=3D1, emitted seq=3D3 >=20 > It looks only gfx ib test passed, and fails to lanuch desktop, am I right= ? >=20 > We would like to see whether it is Raven, Raven kicker (new Raven), or=20 > Picasso. In our side, per the internal test result, we didn't see the=20 > similiar issue on Raven kicker and Picasso platform. >=20 > Thanks, > Ray >=20 > > > > These are the relevant changes in KFD and Thunk for reference: > > > > ### KFD ### > > > > commit 914913ab04dfbcd0226ecb6bc99d276832ea2908 > > Author: Huang Rui > > Date:=A0=A0 Tue Aug 18 14:54:23 2020 +0800 > > > > =A0=A0=A0 drm/amdkfd: implement the dGPU fallback path for apu (v6) > > > > =A0=A0=A0 We still have a few iommu issues which need to address, so=20 > > force raven > > =A0=A0=A0 as "dgpu" path for the moment. > > > > =A0=A0=A0 This is to add the fallback path to bypass IOMMU if IOMMU v2= is=20 > > disabled > > =A0=A0=A0 or ACPI CRAT table not correct. > > > > =A0=A0=A0 v2: Use ignore_crat parameter to decide whether it will go w= ith=20 > > IOMMUv2. > > =A0=A0=A0 v3: Align with existed thunk, don't change the way of raven,= =20 > > only renoir > > =A0=A0=A0=A0=A0=A0=A0 will use "dgpu" path by default. > > =A0=A0=A0 v4: don't update global ignore_crat in the driver, and revis= e=20 > > fallback > > =A0=A0=A0=A0=A0=A0=A0 function if CRAT is broken. > > =A0=A0=A0 v5: refine acpi crat good but no iommu support case, and ren= ame=20 > > the > > =A0=A0=A0=A0=A0=A0=A0 title. > > =A0=A0=A0 v6: fix the issue of dGPU initialized firstly, just modify t= he=20 > > report > > =A0=A0=A0=A0=A0=A0=A0 value in the node_show(). > > > > =A0=A0=A0 Signed-off-by: Huang Rui > > =A0=A0=A0 Reviewed-by: Felix Kuehling > > =A0=A0=A0 Signed-off-by: Alex Deucher > > > > ### Thunk ### > > > > commit e32482fa4b9ca398c8bdc303920abfd672592764 > > Author: Huang Rui > > Date:=A0=A0 Tue Aug 18 18:54:05 2020 +0800 > > > > =A0=A0=A0 libhsakmt: remove is_dgpu flag in the hsa_gfxip_table > > > > =A0=A0=A0 Whether use dgpu path will check the props which exposed fro= m kernel. > > =A0=A0=A0 We won't need hard code in the ASIC table. > > > > =A0=A0=A0 Signed-off-by: Huang Rui > > =A0=A0=A0 Change-Id: I0c018a26b219914a41197ff36dbec7a75945d452 > > > > commit 7c60f6d912034aa67ed27b47a29221422423f5cc > > Author: Huang Rui > > Date:=A0=A0 Thu Jul 30 10:22:23 2020 +0800 > > > > =A0=A0=A0 libhsakmt: implement the method that using flag which expose= d=20 > > by kfd to configure is_dgpu > > > > =A0=A0=A0 KFD already implemented the fallback path for APU. Thunk wil= l=20 > > use flag > > =A0=A0=A0 which exposed by kfd to configure is_dgpu instead of hardcod= e before. > > > > =A0=A0=A0 Signed-off-by: Huang Rui > > =A0=A0=A0 Change-Id: I445f6cf668f9484dd06cd9ae1bb3cfe7428ec7eb > > > > Regards, > > =A0 Felix > > > > > > > Cheers, Alex. I'll have to defer to Edgar for the details, as my=20 > > > understanding from the original thread over at: > > > > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__nam11.safelinks.p > rotection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fur&d=3DDwIFAw&c=3DjOUR= T > kCZzT8tVB5xPEYIm3YJGoxoTaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_-862rdSP13_ > P6LVp7j_9l1xmg&m=3DMMI_EgCqeOX4EvIftpL7agRxJ-udp1CLokf2QWuzFgE&s=3DIPZRol= k > y3TYlbWPsOkY37MbDdzwhc1b_LaE6JkaOkOo&e=3D > > > ldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps- > 3A__lore.kernel.org&a > > > > mp;data=3D04%7C01%7CAlexander.Deucher%40amd.com%7C6d5fa241f963469 > 2c039 > > > > 08d8904a942c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63741 > 79972 > > > > 72974427%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi > V2luMzI > > > > iLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DiKTPucGQqcRXET > QZiQz > > > j90WdJeCYDytdZHJ1ZiUyR%2FM%3D&reserved=3D0 > > > _linux-2Diommu_MWHPR10MB1310CDB6829DDCF5EA84A14689150- > 40MWHPR10MB131 > > > > 0.namprd10.prod.outlook.com_&d=3DDwIDAw&c=3DjOURTkCZzT8tVB5xPEYIm3Y > JGoxo > > > TaQsQPzPKJGaWbo&r=3DBJxhacqqa4K1PJGm6_- > 862rdSP13_P6LVp7j_9l1xmg&m=3DlNXu > > > > 2xwvyxEZ3PzoVmXMBXXS55jsmfDicuQFJqkIOH4&s=3DdsAVVJbD7gJIj3ctZpnnU > 60y21 > > > ijWZmZ8xmOK1cO_O0&e=3D > > > > > > is that this is a board developed by his company. > > > > > > Edgar -- please can you answer Alex's questions? > > > > > > Will