From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Jake Oshins To: Greg KH CC: KY Srinivasan , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "vkuznets@redhat.com" , "bhelgaas@google.com" , "linux-pci@vger.kernel.org" , "pebolle@tiscali.nl" , Haiyang Zhang , Mike Ebersol Subject: RE: [PATCH v2 4/6] drivers:hv: Export a function that maps Linux proc num onto Hyper-V proc num Date: Mon, 15 Jun 2015 21:23:50 +0000 Message-ID: References: <1434387999-1885-1-git-send-email-jakeo@microsoft.com> <1434387999-1885-5-git-send-email-jakeo@microsoft.com> <20150615195216.GB5257@kroah.com> In-Reply-To: <20150615195216.GB5257@kroah.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Monday, June 15, 2015 12:52 PM > To: Jake Oshins > Cc: KY Srinivasan; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; > vkuznets@redhat.com; bhelgaas@google.com; linux-pci@vger.kernel.org; > pebolle@tiscali.nl; Haiyang Zhang; Mike Ebersol > Subject: Re: [PATCH v2 4/6] drivers:hv: Export a function that maps Linux > proc num onto Hyper-V proc num > > > +/** > > + * This function returns the mapping between the Linux processor > > + * number and > > + * the hypervisor's virtual processor number, useful in making > > + * hypercalls and such that talk about specific processors. > > + * > > + * @param procnum - in Linux terms > > What kind of comment structure is this? It's not kernel doc :( > > And "procnum" sounds like "process number", why not "cpu_number"? Thanks. I'll wait a little while to see if any other feedback comes in and then I'll fix these and resend. -- Jake Oshins