From: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: RE: [PATCH v2 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC
Date: Wed, 3 Feb 2021 09:11:03 +0000 [thread overview]
Message-ID: <DM5PR12MB183576159AF458EE007149D1DAB49@DM5PR12MB1835.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210203075103.GA18742@wunner.de>
On Wed, Feb 3, 2021 at 7:51:3, Lukas Wunner <lukas@wunner.de> wrote:
> On Wed, Feb 03, 2021 at 01:54:49AM +0000, Gustavo Pimentel wrote:
> > On Tue, Feb 2, 2021 at 18:8:55, Lukas Wunner <lukas@wunner.de> wrote:
> > > As the name implies, the capability is "vendor-specific", so it is
> > > perfectly possible that two vendors use the same VSEC ID for different
> > > things.
> > >
> > > To make sure you're looking for the right capability, you need to pass
> > > a u16 vendor into this function and bail out if dev->vendor is different.
> >
> > This function will be called by the driver that will pass the correct
> > device which will be already pointing to the config space associated with
> > the endpoint for instance. Because the driver is already attached to the
> > endpoint through the vendor ID and device ID specified, there is no need
> > to do that validation, it will be redundant.
>
> Okay. Please amend the kernel-doc to make it explicit that it's the
> caller's responsibility to check the vendor ID.
I don't think that would be necessary, as I said, the 'struct pci_dev *'
already points exclusively for the device' config space, which contains
all the capabilities for that particular device by his turn will be
attached to a specific driver by the Vendor and Device IDs to a specific
driver, that will know, firstly search for the specific device vendor ID,
and then secondly how to decode it, and thirdly to do something with it.
>
> Thanks,
>
> Lukas
next prev parent reply other threads:[~2021-02-03 9:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 12:40 [PATCH v2 00/15] dmaengine: dw-edma: HDMA support Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 01/15] dmaengine: dw-edma: Add writeq() and readq() for 64 bits architectures Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 02/15] dmaengine: dw-edma: Fix comments offset characters' alignment Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 03/15] dmaengine: dw-edma: Add support for the HDMA feature Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC Gustavo Pimentel
2021-02-02 18:08 ` Lukas Wunner
2021-02-03 1:54 ` Gustavo Pimentel
2021-02-03 7:51 ` Lukas Wunner
2021-02-03 9:11 ` Gustavo Pimentel [this message]
2021-02-03 9:36 ` Lukas Wunner
2021-02-03 9:58 ` Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval support Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 06/15] dmaengine: dw-edma: Add device_prep_interleave_dma() support Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 07/15] dmaengine: dw-edma: Improve number of channels check Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 08/15] dmaengine: dw-edma: Reorder variables to keep consistency Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 09/15] dmaengine: dw-edma: Improve the linked list and data blocks definition Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 10/15] dmaengine: dw-edma: Change linked list and data blocks offset and sizes Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 11/15] dmaengine: dw-edma: Move struct dentry variable from static definition into dw_edma struct Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 13/15] dmaengine: dw-edma: Change DMA abreviation from lower into upper case Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 14/15] dmaengine: dw-edma: Revert fix scatter-gather address calculation Gustavo Pimentel
2021-02-02 12:40 ` [PATCH v2 15/15] dmaengine: dw-edma: Add pcim_iomap_table return checker Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR12MB183576159AF458EE007149D1DAB49@DM5PR12MB1835.namprd12.prod.outlook.com \
--to=gustavo.pimentel@synopsys.com \
--cc=bhelgaas@google.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).