From: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Derek Kiernan" <derek.kiernan@xilinx.com>,
"Dragan Cvetic" <dragan.cvetic@xilinx.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>
Subject: RE: [PATCH v2 1/2] Documentation: misc-devices: Fix indentation, formatting, and update outdated info
Date: Wed, 7 Apr 2021 15:57:31 +0000 [thread overview]
Message-ID: <DM5PR12MB183598B5F93D4DBC515F61B1DA759@DM5PR12MB1835.namprd12.prod.outlook.com> (raw)
In-Reply-To: <YG1OaKU7slMHfweX@kroah.com>
On Wed, Apr 7, 2021 at 7:17:12, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Apr 06, 2021 at 11:17:48PM +0200, Gustavo Pimentel wrote:
> > Fixes indentation issues reported by doing *make htmldocs* as well some
> > text formatting.
> >
> > Besides these fixes, there was some outdated information related to stop
> > file interface in sysfs.
>
> You are not doing this for all "misc-devices", you are doing this only
> for one specific driver file.
>
> Please look at the example I provided for how to name this and fix up.
Sorry Greg, I didn't see an example provided. Perhaps you forgot it?
>
> >
> > Fixes: e1181b5bbc3c ("Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver")
> > Link: https://urldefense.com/v3/__https://lore.kernel.org/linux-next/20210406214615.40cf3493@canb.auug.org.au/__;!!A4F2R9G_pg!MeIXpmOYi4yJTBq19JEADll7-g6cYBmmwG92EWipqsBiPzeubfMGVllrpMt8FpwvW5ZemHY$
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> > ---
> > Documentation/misc-devices/dw-xdata-pcie.rst | 62 +++++++++++++++++++---------
> > 1 file changed, 43 insertions(+), 19 deletions(-)
>
> What changed from v1? Always put that below the --- line.
I've considered the V1 the 2 patches sent wrongly separately, based on
your feedback I've generated a v2 to include the cover letter and the
reported-by, link, and fixes tags.
Was this wrong?
I also placed the change list on the cover letter. Or do you prefer on
each patch?
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2021-04-07 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 21:17 [PATCH v2 0/2] Documentation: misc-devices: Fix documentation issues (indentation, text format, toc) and outdated information Gustavo Pimentel
2021-04-06 21:17 ` [PATCH v2 1/2] Documentation: misc-devices: Fix indentation, formatting, and update outdated info Gustavo Pimentel
2021-04-07 6:17 ` Greg Kroah-Hartman
2021-04-07 15:57 ` Gustavo Pimentel [this message]
2021-04-07 17:35 ` Greg Kroah-Hartman
2021-04-07 20:34 ` Gustavo Pimentel
2021-04-06 21:17 ` [PATCH v2 2/2] Documentation: misc-devices: Add missing entry on the table of content related to dw-xdata-pcie Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR12MB183598B5F93D4DBC515F61B1DA759@DM5PR12MB1835.namprd12.prod.outlook.com \
--to=gustavo.pimentel@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).