linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Derek Kiernan <derek.kiernan@xilinx.com>,
	Dragan Cvetic <dragan.cvetic@xilinx.com>,
	Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver
Date: Tue, 2 Feb 2021 17:25:37 +0000	[thread overview]
Message-ID: <DM5PR12MB1835EDF370312360F147913BDAB59@DM5PR12MB1835.namprd12.prod.outlook.com> (raw)
In-Reply-To: <YBmHBaevmWRmyUTq@kroah.com>

On Tue, Feb 2, 2021 at 17:8:21, Greg Kroah-Hartman 
<gregkh@linuxfoundation.org> wrote:

> On Tue, Feb 02, 2021 at 04:58:50PM +0000, Gustavo Pimentel wrote:
> > On Tue, Feb 2, 2021 at 10:43:3, Greg Kroah-Hartman 
> > <gregkh@linuxfoundation.org> wrote:
> > 
> > > On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote:
> > > > On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman 
> > > > <gregkh@linuxfoundation.org> wrote:
> > > > 
> > > > > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > > > > > Just a kindly reminder.
> > > > > 
> > > > > reminder of what?
> > > > 
> > > > To review the patch set. I've done the requested modifications, but I 
> > > > didn't get any feedback if this patch series is fine or it needs 
> > > > something more to have an ACK.
> > > 
> > > I do not knwo, I don't see anything my my review queue, sorry.
> > 
> > I've resend the patch series. Let's see if appears now 😊
> > 
> > > 
> > > > If some feedback was provided, please accept my apologies. My email 
> > > > account was having some issues some time ago and I might not have 
> > > > received some emails.
> > > 
> > > Check the archives please, that's what they are there for :)
> > 
> > I have just checked, there isn't any feedback besides yours and Arnd 
> > Bergmann.
> 
> Did you incorporate our review?

Yes, I did. The driver initially was using the modules parameters, and 
based on your feedback I changed to sysfs using other drivers' 
implementation as a reference. I also the driver structure changed to use 
macros instead of bitfields.

> 
> greg k-h



      reply	other threads:[~2021-02-02 17:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19  9:19 [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver Gustavo Pimentel
2020-11-19  9:19 ` [PATCH v3 1/5] misc: " Gustavo Pimentel
2020-11-19  9:19 ` [PATCH v3 4/5] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver Gustavo Pimentel
2021-02-02  8:51 ` [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver Gustavo Pimentel
2021-02-02 10:11   ` Greg Kroah-Hartman
2021-02-02 10:38     ` Gustavo Pimentel
2021-02-02 10:43       ` Greg Kroah-Hartman
2021-02-02 16:58         ` Gustavo Pimentel
2021-02-02 17:08           ` Greg Kroah-Hartman
2021-02-02 17:25             ` Gustavo Pimentel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR12MB1835EDF370312360F147913BDAB59@DM5PR12MB1835.namprd12.prod.outlook.com \
    --to=gustavo.pimentel@synopsys.com \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=derek.kiernan@xilinx.com \
    --cc=dragan.cvetic@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).