From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D8EC76188 for ; Fri, 19 Jul 2019 08:55:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C2B72184E for ; Fri, 19 Jul 2019 08:55:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="UHk9lJIt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=synopsys.onmicrosoft.com header.i=@synopsys.onmicrosoft.com header.b="JV1yemz+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725798AbfGSIzk (ORCPT ); Fri, 19 Jul 2019 04:55:40 -0400 Received: from dc8-smtprelay2.synopsys.com ([198.182.47.102]:55640 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbfGSIzk (ORCPT ); Fri, 19 Jul 2019 04:55:40 -0400 Received: from mailhost.synopsys.com (dc2-mailhost2.synopsys.com [10.12.135.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 440C0C1C27; Fri, 19 Jul 2019 08:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1563526538; bh=FrLF1DnA722Nl9EP2ENin9USbSPfQxdBWd27eIPQR6A=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=UHk9lJItJoJQsJkIvFo5zM/2GhXBRXA5KyPjjCWiZ7YGupxand1SYafSv3/DyF4lq IlIO1Ar3NO3grn8wZ80M0UQuXv/NjzgXlc1QSw/nyeKz4K466s61EcItVNwK0JkZze yeHUctf9u4YZMqPxOprNOTQPxzgS4sIwe0HpYZT6GzBj1bZJ7dqCiQMI5r+E5YaHRa ZU50YP7azNWHvzGcBaQFbPLdUwncLT/qfAzTgf6zCDgkszKMkAfpWM//W2vFuAbjWi MZsfDe/p1Z8FNKTOrulZxlRcY8/42Q+Zh4M9YtSNr9BtlIuoWOXGWgG/0kGNXnlSOm 5x6KBUOnTNfbQ== Received: from US01WEHTC2.internal.synopsys.com (us01wehtc2.internal.synopsys.com [10.12.239.237]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id C3FF4A009A; Fri, 19 Jul 2019 08:55:37 +0000 (UTC) Received: from US01HYBRID2.internal.synopsys.com (10.15.246.24) by US01WEHTC2.internal.synopsys.com (10.12.239.237) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 19 Jul 2019 01:55:26 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (10.13.134.195) by mrs.synopsys.com (10.15.246.24) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 19 Jul 2019 01:55:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cIyuXcEcrqXrahWmdlHVTGbAJ9/wzzubeNgW1pNYhbKBLiAllkYOkynxTIwsjGaXwEEvAMWvV/JU31Zj2i/PxS8PANuDWr3e98oItD8getn12EpiQNLjDacyapf6xv+VX8JYB4HpMoN/b3kcwipEkEivUU4CIFqNBRAcGEftqi3RoHgvGG6sv6VfLyPKbxlCHNkiJWa6SqHeG5S4dPZ38zvxbmTaB3IGstPiR+NsurMfNk/XpTwtrS574yTuLTdW0f+12dBwyW9JzylXGR5Wy2wVIy+EuLRhYC+AZ79Iss9gyEstTe/jsOeEGi51UJx4DRCbFiPqyxMeJ5QfP61VkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lc79Tw7oRQKnw7Z8lzSPA+p1Meizn4oVBsERxvODpqo=; b=E7L/JWsgpM7gME3NYPnBYm8wTmN5V4+u9bYzO8Y7kG8ZFAnANRWkLKhszaETi7t15KC28jZILStumWcsVb4aG2VYC8SiySIo7NsdOe6sv7Jto5lAi+Q4hzmxCyqeLfwThzhNgtNMNQI4zTMnthipMC7MtG+8iE9wnVKnXVWHO9zQK7BntWY4SmDdDlAmz27e3jdjLJ/btH6lqIAEd+YhHq64F+vucALHZTHhJgMeEorZPfCtWSiVqv7rrI6mkpoMrpBiP1/2ck2CBhkDUP6gWO5HXBlJ74XlcWqzw4It4tFntWetQYk35GG3CbzQAO84uJLDt8aBXtyR9pg94VCXXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=synopsys.com;dmarc=pass action=none header.from=synopsys.com;dkim=pass header.d=synopsys.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=synopsys.onmicrosoft.com; s=selector1-synopsys-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lc79Tw7oRQKnw7Z8lzSPA+p1Meizn4oVBsERxvODpqo=; b=JV1yemz+YXtS2klEYgS5j3vA7SNsKi5Lq1o18klKsTnSVgcbWADQcmyNWojNKTC1a38A00a4Qi1nkxiOFxISodYtRVPapXE5NjM77KsWLAebGKPUfJuP+UHMxSgGowNHE4Kfa0cUjexXVsdKl3Vfqv4taKm2eIXBrv/JOc3Ici0= Received: from DM6PR12MB4010.namprd12.prod.outlook.com (10.255.175.83) by DM6PR12MB3817.namprd12.prod.outlook.com (10.255.173.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Fri, 19 Jul 2019 08:55:24 +0000 Received: from DM6PR12MB4010.namprd12.prod.outlook.com ([fe80::2dc8:6bc4:3d9d:9203]) by DM6PR12MB4010.namprd12.prod.outlook.com ([fe80::2dc8:6bc4:3d9d:9203%4]) with mapi id 15.20.2073.012; Fri, 19 Jul 2019 08:55:24 +0000 From: Gustavo Pimentel To: Jonathan Chocron , "lorenzo.pieralisi@arm.com" , "bhelgaas@google.com" , "jingoohan1@gmail.com" , "gustavo.pimentel@synopsys.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" CC: "dwmw@amazon.co.uk" , "benh@kernel.crashing.org" , "alisaidi@amazon.com" , "ronenk@amazon.com" , "barakw@amazon.com" , "talel@amazon.com" , "hanochu@amazon.com" , "hhhawa@amazon.com" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: RE: [PATCH v2 6/8] PCI: al: Add support for DW based driver type Thread-Topic: [PATCH v2 6/8] PCI: al: Add support for DW based driver type Thread-Index: AQHVPU38Gx2aU4zmJUS3O2B8XJh8IKbRnP4g Date: Fri, 19 Jul 2019 08:55:24 +0000 Message-ID: References: <20190718094531.21423-1-jonnyc@amazon.com> <20190718094718.25083-2-jonnyc@amazon.com> In-Reply-To: <20190718094718.25083-2-jonnyc@amazon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcZ3VzdGF2b1xh?= =?us-ascii?Q?cHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJh?= =?us-ascii?Q?MjllMzViXG1zZ3NcbXNnLWVlZjkwNDhjLWFhMDItMTFlOS05ODhjLWY4OTRj?= =?us-ascii?Q?MjczODA0MlxhbWUtdGVzdFxlZWY5MDQ4ZC1hYTAyLTExZTktOTg4Yy1mODk0?= =?us-ascii?Q?YzI3MzgwNDJib2R5LnR4dCIgc3o9IjEzNDg0IiB0PSIxMzIwODAwMDEyMjA0?= =?us-ascii?Q?MzYyMzEiIGg9InlYektTY2dQU2JRTHZBdmdIZU5KaWVFYzc3TT0iIGlkPSIi?= =?us-ascii?Q?IGJsPSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQUJRSkFB?= =?us-ascii?Q?QUhZYTJ5RHo3VkFUcEhHTndvd09sck9rY1kzQ2pBNldzT0FBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFIQUFBQUNrQ0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFFQUFRQUJBQUFBRnRiQnB3QUFBQUFBQUFBQUFBQUFBSjRBQUFCbUFHa0Fi?= =?us-ascii?Q?Z0JoQUc0QVl3QmxBRjhBY0FCc0FHRUFiZ0J1QUdrQWJnQm5BRjhBZHdCaEFI?= =?us-ascii?Q?UUFaUUJ5QUcwQVlRQnlBR3NBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR1lBYndCMUFHNEFaQUJ5QUhrQVh3?= =?us-ascii?Q?QndBR0VBY2dCMEFHNEFaUUJ5QUhNQVh3Qm5BR1lBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FB?= =?us-ascii?Q?QUFBQUNlQUFBQVpnQnZBSFVBYmdCa0FISUFlUUJmQUhBQVlRQnlBSFFBYmdC?= =?us-ascii?Q?bEFISUFjd0JmQUhNQVlRQnRBSE1BZFFCdUFHY0FYd0JqQUc4QWJnQm1BQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJtQUc4?= =?us-ascii?Q?QWRRQnVBR1FBY2dCNUFGOEFjQUJoQUhJQWRBQnVBR1VBY2dCekFGOEFjd0Jo?= =?us-ascii?Q?QUcwQWN3QjFBRzRBWndCZkFISUFaUUJ6QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHWUFid0IxQUc0QVpBQnlBSGtB?= =?us-ascii?Q?WHdCd0FHRUFjZ0IwQUc0QVpRQnlBSE1BWHdCekFHMEFhUUJqQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFD?= =?us-ascii?Q?QUFBQUFBQ2VBQUFBWmdCdkFIVUFiZ0JrQUhJQWVRQmZBSEFBWVFCeUFIUUFi?= =?us-ascii?Q?Z0JsQUhJQWN3QmZBSE1BZEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQm1B?= =?us-ascii?Q?RzhBZFFCdUFHUUFjZ0I1QUY4QWNBQmhBSElBZEFCdUFHVUFjZ0J6QUY4QWRB?= =?us-ascii?Q?QnpBRzBBWXdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdZQWJ3QjFBRzRBWkFCeUFI?= =?us-ascii?Q?a0FYd0J3QUdFQWNnQjBBRzRBWlFCeUFITUFYd0IxQUcwQVl3QUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFDZUFBQUFad0IwQUhNQVh3QndBSElBYndCa0FIVUFZd0IwQUY4?= =?us-ascii?Q?QWRBQnlBR0VBYVFCdUFHa0FiZ0JuQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFC?= =?us-ascii?Q?ekFHRUFiQUJsQUhNQVh3QmhBR01BWXdCdkFIVUFiZ0IwQUY4QWNBQnNBR0VB?= =?us-ascii?Q?YmdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBSE1BWVFCc0FHVUFjd0Jm?= =?us-ascii?Q?QUhFQWRRQnZBSFFBWlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFB?= =?us-ascii?Q?QUFBQ0FBQUFBQUNlQUFBQWN3QnVBSEFBY3dCZkFHd0FhUUJqQUdVQWJnQnpB?= =?us-ascii?Q?R1VBWHdCMEFHVUFjZ0J0QUY4QU1RQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFB?= =?us-ascii?Q?QUJ6QUc0QWNBQnpBRjhBYkFCcEFHTUFaUUJ1QUhNQVpRQmZBSFFBWlFCeUFH?= =?us-ascii?Q?MEFYd0J6QUhRQWRRQmtBR1VBYmdCMEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFIWUFad0JmQUdzQVpR?= =?us-ascii?Q?QjVBSGNBYndCeUFHUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFB?= =?us-ascii?Q?QUFBQUFDQUFBQUFBQT0iLz48L21ldGE+?= authentication-results: spf=none (sender IP is ) smtp.mailfrom=gustavo@synopsys.com; x-originating-ip: [83.174.63.141] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 72d26ced-3677-4409-8bf1-08d70c26d6da x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR12MB3817; x-ms-traffictypediagnostic: DM6PR12MB3817: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-forefront-prvs: 01039C93E4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(346002)(39860400002)(376002)(136003)(189003)(199004)(71200400001)(8936002)(71190400001)(53936002)(476003)(7696005)(9686003)(66446008)(76176011)(66066001)(102836004)(186003)(8676002)(2201001)(14444005)(81156014)(2906002)(256004)(7416002)(6506007)(53546011)(6246003)(99286004)(52536014)(25786009)(316002)(30864003)(6436002)(486006)(14454004)(229853002)(110136005)(54906003)(74316002)(5660300002)(26005)(86362001)(7736002)(3846002)(55016002)(2501003)(11346002)(66476007)(68736007)(446003)(4326008)(81166006)(478600001)(33656002)(64756008)(6116002)(66556008)(305945005)(66946007)(76116006);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR12MB3817;H:DM6PR12MB4010.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: synopsys.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gqcvdDUYi95XdhWOFMbj2UJEISXV9jUiIe6rCwXqrgAvf8oYlEifmc2z8ppSY8N/yOIydQPaEMjiDjiyhNgQqh7HW+qVO3sSE3NSqL0LlsSSw/laRkF/UTVVq7wthBNdJgGZaTwQHoHPUAamSxDEXn+MsafkFdDkNzRSEapmuqMB9dkXgNXVTyW0yx8VqGAiDT+GPaUVO1D9fa2ltcmEIOheWKI7Bu6PLRqlOKH8qRNwMwmgQ28JcnQCgcbFWmmCxUmz9BjF5icbb37APTjWosXP7/Nmo4xLX0ilAFUkmtnmVoIsahSvDf8NSCVnkTJE9MeMQjJ3ys8D/DIylqKKN4RA3b1vBlHil728nooeEnAv2NO+T4R2VzLkv/D4buhelayq2Cip2TpKklztyEylyt7ht60FRtCKRRgFOzxRBGE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 72d26ced-3677-4409-8bf1-08d70c26d6da X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2019 08:55:24.7372 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gustavo@synopsys.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3817 X-OriginatorOrg: synopsys.com Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Jul 18, 2019 at 10:47:16, Jonathan Chocron =20 wrote: > This driver is DT based and utilizes the DesignWare APIs. > It allows using a smaller ECAM range for a larger bus range - > usually an entire bus uses 1MB of address space, but the driver > can use it for a larger number of buses. >=20 > All link initializations are handled by the boot FW. >=20 > Signed-off-by: Jonathan Chocron > --- > drivers/pci/controller/dwc/Kconfig | 12 + > drivers/pci/controller/dwc/pcie-al.c | 373 +++++++++++++++++++++++++++ > 2 files changed, 385 insertions(+) >=20 > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/= dwc/Kconfig > index 6ea778ae4877..3c6094cbcc3b 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -230,4 +230,16 @@ config PCIE_UNIPHIER > Say Y here if you want PCIe controller support on UniPhier SoCs. > This driver supports LD20 and PXs3 SoCs. > =20 > +config PCIE_AL > + bool "Amazon Annapurna Labs PCIe controller" > + depends on OF && (ARM64 || COMPILE_TEST) > + depends on PCI_MSI_IRQ_DOMAIN > + select PCIE_DW_HOST > + help > + Say Y here to enable support of the Amazon's Annapurna Labs PCIe > + controller IP on Amazon SoCs. The PCIe controller uses the DesignWare > + core plus Annapurna Labs proprietary hardware wrappers. This is > + required only for DT-based platforms. ACPI platforms with the > + Annapurna Labs PCIe controller don't need to enable this. > + > endmenu > diff --git a/drivers/pci/controller/dwc/pcie-al.c b/drivers/pci/controlle= r/dwc/pcie-al.c > index 3ab58f0584a8..40555532fb9a 100644 > --- a/drivers/pci/controller/dwc/pcie-al.c > +++ b/drivers/pci/controller/dwc/pcie-al.c > @@ -91,3 +91,376 @@ struct pci_ecam_ops al_pcie_ops =3D { > }; > =20 > #endif /* defined(CONFIG_ACPI) && defined(CONFIG_PCI_QUIRKS) */ > + > +#ifdef CONFIG_PCIE_AL > + > +#include > +#include "pcie-designware.h" > + > +#define AL_PCIE_REV_ID_2 2 > +#define AL_PCIE_REV_ID_3 3 > +#define AL_PCIE_REV_ID_4 4 > + > +#define AXI_BASE_OFFSET 0x0 > + > +#define DEVICE_ID_OFFSET 0x16c > + > +#define DEVICE_REV_ID 0x0 > +#define DEVICE_REV_ID_DEV_ID_MASK GENMASK(31, 16) > + > +#define DEVICE_REV_ID_DEV_ID_X4 0 > +#define DEVICE_REV_ID_DEV_ID_X8 2 > +#define DEVICE_REV_ID_DEV_ID_X16 4 > + > +#define OB_CTRL_REV1_2_OFFSET 0x0040 > +#define OB_CTRL_REV3_5_OFFSET 0x0030 > + > +#define CFG_TARGET_BUS 0x0 > +#define CFG_TARGET_BUS_MASK_MASK GENMASK(7, 0) > +#define CFG_TARGET_BUS_BUSNUM_MASK GENMASK(15, 8) > + > +#define CFG_CONTROL 0x4 > +#define CFG_CONTROL_SUBBUS_MASK GENMASK(15, 8) > +#define CFG_CONTROL_SEC_BUS_MASK GENMASK(23, 16) > + > +struct al_pcie_reg_offsets { > + unsigned int ob_ctrl; > +}; > + > +struct al_pcie_target_bus_cfg { > + u8 reg_val; > + u8 reg_mask; > + u8 ecam_mask; > +}; > + > +struct al_pcie { > + struct dw_pcie *pci; > + void __iomem *controller_base; /* base of PCIe unit (not DW core) */ > + struct device *dev; > + resource_size_t ecam_size; > + unsigned int controller_rev_id; > + struct al_pcie_reg_offsets reg_offsets; > + struct al_pcie_target_bus_cfg target_bus_cfg; > +}; > + > +#define PCIE_ECAM_DEVFN(x) (((x) & 0xff) << 12) > + > +#define to_al_pcie(x) dev_get_drvdata((x)->dev) > + > +static int al_pcie_rev_id_get(struct al_pcie *pcie, unsigned int *rev_id= ) > +{ > + void __iomem *dev_rev_id_addr; > + u32 dev_rev_id; > + > + dev_rev_id_addr =3D (void __iomem *)((uintptr_t)pcie->controller_base + > + AXI_BASE_OFFSET + DEVICE_ID_OFFSET + DEVICE_REV_ID); > + > + dev_rev_id =3D FIELD_GET(DEVICE_REV_ID_DEV_ID_MASK, > + readl(dev_rev_id_addr)); > + switch (dev_rev_id) { > + case DEVICE_REV_ID_DEV_ID_X4: > + *rev_id =3D AL_PCIE_REV_ID_2; > + break; > + case DEVICE_REV_ID_DEV_ID_X8: > + *rev_id =3D AL_PCIE_REV_ID_3; > + break; > + case DEVICE_REV_ID_DEV_ID_X16: > + *rev_id =3D AL_PCIE_REV_ID_4; > + break; > + default: > + dev_err(pcie->dev, "Unsupported dev_rev_id (0x%x)\n", > + dev_rev_id); > + return -EINVAL; > + } > + > + dev_dbg(pcie->dev, "dev_rev_id: 0x%x\n", dev_rev_id); Consider s/dev_dbg/pci_dbg/g > + > + return 0; > +} > + > +static int al_pcie_reg_offsets_set(struct al_pcie *pcie) > +{ > + switch (pcie->controller_rev_id) { > + case AL_PCIE_REV_ID_2: > + pcie->reg_offsets.ob_ctrl =3D OB_CTRL_REV1_2_OFFSET; > + break; > + case AL_PCIE_REV_ID_3: > + case AL_PCIE_REV_ID_4: > + pcie->reg_offsets.ob_ctrl =3D OB_CTRL_REV3_5_OFFSET; > + break; > + default: > + dev_err(pcie->dev, "Unsupported controller rev_id: 0x%x\n", > + pcie->controller_rev_id); Consider s/dev_err/pci_err/g > + return -EINVAL; > + } > + > + return 0; > +} > + > +static inline void al_pcie_target_bus_set(struct al_pcie *pcie, > + u8 target_bus, > + u8 mask_target_bus) > +{ > + void __iomem *cfg_control_addr; > + u32 reg; > + > + reg =3D FIELD_PREP(CFG_TARGET_BUS_MASK_MASK, mask_target_bus) | > + FIELD_PREP(CFG_TARGET_BUS_BUSNUM_MASK, target_bus); > + > + cfg_control_addr =3D (void __iomem *)((uintptr_t)pcie->controller_base = + > + AXI_BASE_OFFSET + pcie->reg_offsets.ob_ctrl + > + CFG_TARGET_BUS); > + > + writel(reg, cfg_control_addr); >From what I'm seeing you commonly use writel() and readl() with a common=20 base address, such as pcie->controller_base + AXI_BASE_OFFSET. I'd suggest to creating a writel and readl with that offset built-in. > +} > + > +static void __iomem *al_pcie_conf_addr_map(struct al_pcie *pcie, > + unsigned int busnr, > + unsigned int devfn) > +{ > + void __iomem *pci_base_addr; Consider passing this variable declaration to the bottom, following the=20 reverse tree order. > + struct pcie_port *pp =3D &pcie->pci->pp; > + struct al_pcie_target_bus_cfg *target_bus_cfg =3D &pcie->target_bus_cfg= ; > + unsigned int busnr_ecam =3D busnr & target_bus_cfg->ecam_mask; > + unsigned int busnr_reg =3D busnr & target_bus_cfg->reg_mask; > + > + pci_base_addr =3D (void __iomem *)((uintptr_t)pp->va_cfg0_base + > + (busnr_ecam << 20) + > + PCIE_ECAM_DEVFN(devfn)); > + > + if (busnr_reg !=3D target_bus_cfg->reg_val) { > + dev_dbg(pcie->pci->dev, "Changing target bus busnum val from 0x%x to 0= x%x\n", > + target_bus_cfg->reg_val, busnr_reg); > + target_bus_cfg->reg_val =3D busnr_reg; > + al_pcie_target_bus_set(pcie, > + target_bus_cfg->reg_val, > + target_bus_cfg->reg_mask); > + } > + > + return pci_base_addr; > +} > + > +static int al_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *b= us, > + unsigned int devfn, int where, int size, > + u32 *val) > +{ > + struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); > + struct al_pcie *pcie =3D to_al_pcie(pci); > + unsigned int busnr =3D bus->number; > + void __iomem *pci_addr; > + int rc; > + > + pci_addr =3D al_pcie_conf_addr_map(pcie, busnr, devfn); > + > + rc =3D dw_pcie_read(pci_addr + where, size, val); > + > + dev_dbg(pci->dev, "%d-byte config read from %04x:%02x:%02x.%d offset 0x= %x (pci_addr: 0x%px) - val:0x%x\n", > + size, pci_domain_nr(bus), bus->number, > + PCI_SLOT(devfn), PCI_FUNC(devfn), where, > + (pci_addr + where), *val); > + > + return rc; > +} > + > +static int al_pcie_wr_other_conf(struct pcie_port *pp, struct pci_bus *b= us, > + unsigned int devfn, int where, int size, > + u32 val) > +{ > + struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); > + struct al_pcie *pcie =3D to_al_pcie(pci); > + unsigned int busnr =3D bus->number; > + void __iomem *pci_addr; > + int rc; > + > + pci_addr =3D al_pcie_conf_addr_map(pcie, busnr, devfn); > + > + rc =3D dw_pcie_write(pci_addr + where, size, val); > + > + dev_err(pci->dev, "%d-byte config write to %04x:%02x:%02x.%d offset 0x%= x (pci_addr: 0x%px) - val:0x%x\n", > + size, pci_domain_nr(bus), bus->number, > + PCI_SLOT(devfn), PCI_FUNC(devfn), where, > + (pci_addr + where), val); > + > + return rc; > +} > + > +static int al_pcie_config_prepare(struct al_pcie *pcie) > +{ > + struct al_pcie_target_bus_cfg *target_bus_cfg; > + struct pcie_port *pp =3D &pcie->pci->pp; > + unsigned int ecam_bus_mask; > + u8 secondary_bus; > + u8 subordinate_bus; > + void __iomem *cfg_control_addr; > + u32 cfg_control; > + u32 reg; > + > + target_bus_cfg =3D &pcie->target_bus_cfg; > + > + ecam_bus_mask =3D (pcie->ecam_size >> 20) - 1; > + if (ecam_bus_mask > 255) { > + dev_warn(pcie->dev, "ECAM window size is larger than 256MB. Cutting of= f at 256\n"); > + ecam_bus_mask =3D 255; > + } > + > + /* This portion is taken from the transaction address */ > + target_bus_cfg->ecam_mask =3D ecam_bus_mask; > + /* This portion is taken from the cfg_target_bus reg */ > + target_bus_cfg->reg_mask =3D ~target_bus_cfg->ecam_mask; > + target_bus_cfg->reg_val =3D pp->busn->start & target_bus_cfg->reg_mask; > + > + al_pcie_target_bus_set(pcie, target_bus_cfg->reg_val, > + target_bus_cfg->reg_mask); > + > + secondary_bus =3D pp->busn->start + 1; > + subordinate_bus =3D pp->busn->end; > + > + /* Set the valid values of secondary and subordinate buses */ > + cfg_control_addr =3D pcie->controller_base + AXI_BASE_OFFSET + > + pcie->reg_offsets.ob_ctrl + CFG_CONTROL; > + > + cfg_control =3D readl(cfg_control_addr); > + > + reg =3D cfg_control & > + ~(CFG_CONTROL_SEC_BUS_MASK | CFG_CONTROL_SUBBUS_MASK); > + > + reg |=3D FIELD_PREP(CFG_CONTROL_SUBBUS_MASK, subordinate_bus) | > + FIELD_PREP(CFG_CONTROL_SEC_BUS_MASK, secondary_bus); > + > + writel(reg, cfg_control_addr); > + > + return 0; > +} > + > +static int al_pcie_host_init(struct pcie_port *pp) > +{ > + struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); > + struct al_pcie *pcie =3D to_al_pcie(pci); > + int link_up; > + int rc; > + > + link_up =3D dw_pcie_link_up(pci); > + if (!link_up) { > + dev_err(pci->dev, "link is not up!\n"); > + return -ENOLINK; > + } > + > + dev_info(pci->dev, "link is up\n"); Consider s/dev_info/pci_info/g > + > + rc =3D al_pcie_rev_id_get(pcie, &pcie->controller_rev_id); > + if (rc) > + return rc; > + > + rc =3D al_pcie_reg_offsets_set(pcie); > + if (rc) > + return rc; > + > + rc =3D al_pcie_config_prepare(pcie); > + if (rc) > + return rc; > + > + return 0; > +} > + > +static const struct dw_pcie_host_ops al_pcie_host_ops =3D { > + .rd_other_conf =3D al_pcie_rd_other_conf, > + .wr_other_conf =3D al_pcie_wr_other_conf, > + .host_init =3D al_pcie_host_init, > +}; > + > +static int al_add_pcie_port(struct pcie_port *pp, > + struct platform_device *pdev) > +{ > + struct device *dev =3D &pdev->dev; > + int ret; > + > + pp->ops =3D &al_pcie_host_ops; > + > + ret =3D dw_pcie_host_init(pp); > + if (ret) { > + dev_err(dev, "failed to initialize host\n"); > + return ret; > + } > + > + return 0; > +} > + > +static const struct dw_pcie_ops dw_pcie_ops =3D { > +}; > + > +static int al_pcie_probe(struct platform_device *pdev) > +{ > + struct device *dev =3D &pdev->dev; > + struct al_pcie *al_pcie; > + struct dw_pcie *pci; > + struct resource *dbi_res; > + struct resource *controller_res; > + struct resource *ecam_res; > + int ret; Please sort the variables following the reverse tree order. > + > + al_pcie =3D devm_kzalloc(dev, sizeof(*al_pcie), GFP_KERNEL); > + if (!al_pcie) > + return -ENOMEM; > + > + pci =3D devm_kzalloc(dev, sizeof(*pci), GFP_KERNEL); > + if (!pci) > + return -ENOMEM; > + > + pci->dev =3D dev; > + pci->ops =3D &dw_pcie_ops; > + > + al_pcie->pci =3D pci; > + al_pcie->dev =3D dev; > + > + dbi_res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi"); > + pci->dbi_base =3D devm_pci_remap_cfg_resource(dev, dbi_res); > + if (IS_ERR(pci->dbi_base)) { > + dev_err(dev, "couldn't remap dbi base %pR\n", dbi_res); > + return PTR_ERR(pci->dbi_base); > + } > + > + ecam_res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "config= "); > + if (!ecam_res) { > + dev_err(dev, "couldn't find 'config' reg in DT\n"); > + return -ENOENT; > + } > + al_pcie->ecam_size =3D resource_size(ecam_res); > + > + controller_res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, > + "controller"); > + al_pcie->controller_base =3D devm_ioremap_resource(dev, controller_res)= ; > + if (IS_ERR(al_pcie->controller_base)) { > + dev_err(dev, "couldn't remap controller base %pR\n", > + controller_res); > + return PTR_ERR(al_pcie->controller_base); > + } > + > + dev_dbg(dev, "From DT: dbi_base: %pR, controller_base: %pR\n", > + dbi_res, controller_res); > + > + platform_set_drvdata(pdev, al_pcie); > + > + ret =3D al_add_pcie_port(&pci->pp, pdev); > + if (ret) > + return ret; > + > + return 0; Those operations are redundant, aren't they? They can be replaced just=20 by: return ret; > +} > + > +static const struct of_device_id al_pcie_of_match[] =3D { > + { .compatible =3D "amazon,al-pcie", > + }, > + {}, > +}; > + > +static struct platform_driver al_pcie_driver =3D { > + .driver =3D { > + .name =3D "al-pcie", > + .of_match_table =3D al_pcie_of_match, > + .suppress_bind_attrs =3D true, > + }, > + .probe =3D al_pcie_probe, > +}; > +builtin_platform_driver(al_pcie_driver); > + > +#endif /* CONFIG_PCIE_AL*/ > --=20 > 2.17.1