From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-eopbgr20073.outbound.protection.outlook.com ([40.107.2.73]:13728 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751692AbeCVPFT (ORCPT ); Thu, 22 Mar 2018 11:05:19 -0400 From: Nipun Gupta To: Christoph Hellwig CC: "robin.murphy@arm.com" , "linux@armlinux.org.uk" , "gregkh@linuxfoundation.org" , "m.szyprowski@samsung.com" , "bhelgaas@google.com" , "zajec5@gmail.com" , "andy.gross@linaro.org" , "david.brown@linaro.org" , "dan.j.williams@intel.com" , "vinod.koul@intel.com" , "thierry.reding@gmail.com" , "robh+dt@kernel.org" , "frowand.list@gmail.com" , "jarkko.sakkinen@linux.intel.com" , "rafael.j.wysocki@intel.com" , "dmitry.torokhov@gmail.com" , "johan@kernel.org" , "msuchanek@suse.de" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linux-wireless@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-soc@vger.kernel.org" , "dmaengine@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-tegra@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , Bharat Bhushan , Leo Li Subject: RE: [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure Date: Thu, 22 Mar 2018 15:05:10 +0000 Message-ID: References: <1520868292-2479-1-git-send-email-nipun.gupta@nxp.com> <1521615323-4752-1-git-send-email-nipun.gupta@nxp.com> <20180322081530.GA29444@lst.de> In-Reply-To: <20180322081530.GA29444@lst.de> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Christoph Hellwig [mailto:hch@lst.de] > Sent: Thursday, March 22, 2018 13:46 > To: Nipun Gupta >=20 > > +static int amba_dma_configure(struct device *dev) > > +{ > > + return dma_common_configure(dev); > > +} >=20 > So it turns out we only end with two callers of dma_common_configure > after this series. Based ont hat I'm tempted with the suggestion > from Robin to just have amba call platform_dma_configure, and move > the code from dma_common_configure to platform_dma_configure. okay, that would be fine, trivial query - will it be okay to include 'linux/platform_device.h' in the AMBA bus? I am reluctant for this change because of including platform file. Thanks, Nipun