RE: [PATCH v6 2/2] PCI: keembay: Add support for Intel Keem Bay

["Thokala, Srikanth" <srikanth.thokala@intel.com>]

Hi Andy,

Thanks for the review.

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Friday, January 22, 2021 2:12 AM
> To: Bjorn Helgaas <helgaas@kernel.org>
> Cc: Thokala, Srikanth <srikanth.thokala@intel.com>; bhelgaas@google.com;
> robh+dt@kernel.org; lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org;
> devicetree@vger.kernel.org; mgross@linux.intel.com; Raja Subramanian,
> Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>; Sangannavar,
> Mallikarjunappa <mallikarjunappa.sangannavar@intel.com>
> Subject: Re: [PATCH v6 2/2] PCI: keembay: Add support for Intel Keem Bay
> 
> On Thu, Jan 21, 2021 at 01:52:06PM -0600, Bjorn Helgaas wrote:
> > On Fri, Jan 22, 2021 at 08:56:10AM +0530, srikanth.thokala@intel.com
> wrote:
> 
> > > Signed-off-by: Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad@intel.com>
> > > Signed-off-by: Srikanth Thokala <srikanth.thokala@intel.com>
> 
> This list seems strange. Shouldn't be your SoB last?

Sure, I will fix it.

> 
> ...
> 
> > <checks MAINTAINERS> ... yep, all previous entries are in alphabetical
> > order.  This new one just got dropped at the end.
> >
> > I feel like a broken record, but please, please, take a look at the
> > surrounding code/text/whatever, and MAKE YOUR NEW STUFF MATCH THE
> > EXISTING STYLE.  We want the whole thing to be reasonably consistent
> > so readers can make sense of it without being confused by the
> > idiosyncrasies of every contributor.
> 
> I guess even checkpatch.pl should complain about this these days.

Sorry I missed, but there are not any checkpatch warnings.  I will fix it
in my next version of the patch.

Thanks!
Srikanth

> 
> --
> With Best Regards,
> Andy Shevchenko
>