From: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Logan Gunthorpe <logang@deltatee.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Possible PCI Regression Linux 5.3-rc1
Date: Mon, 5 Aug 2019 14:09:19 +0000 [thread overview]
Message-ID: <SL2P216MB01876A10BD2E487294D525BF80DA0@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20190805123450.GM2640@lahna.fi.intel.com>
On Mon, Aug 05, 2019 at 03:34:50PM +0300, Mika Westerberg wrote:
> Hi,
>
> On Sun, Aug 04, 2019 at 08:47:43AM +0000, Nicholas Johnson wrote:
> > Reversing the following commit solves the issue:
> >
> > commit c2bf1fc212f7e6f25ace1af8f0b3ac061ea48ba5
> > Author: Mika Westerberg <mika.westerberg@linux.intel.com>
> > PCI: Add missing link delays required by the PCIe spec
> >
> > Mika, care to weigh in (assuming you are back from four weeks leave)?
>
> I'm back now.
>
> > Clearly this creates delays in "lspci -vt" in some Thunderbolt systems,
> > but not all - otherwise you would have caught it. You mentioned Ice Lake
> > in the commit log so perhaps it works fine on Ice Lake.
>
> I also tried it on other systems but it may be that something is
> missing. Can you add "pciepordrv.dyndbg" to the kernel command line (or
> change the dev_dbg() in wait_for_downstream_link() to dev_info() instead
> and attach the dmesg along with full 'sudo lspci -vv' output to the
> following bugzilla (as I think they are the same issue in the end):
>
> https://bugzilla.kernel.org/show_bug.cgi?id=204413
>
> Thanks!
next prev parent reply other threads:[~2019-08-05 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 12:54 Possible PCI Regression Linux 5.3-rc1 Nicholas Johnson
2019-07-24 13:38 ` Bjorn Helgaas
2019-07-24 15:48 ` Logan Gunthorpe
2019-07-25 13:21 ` Nicholas Johnson
2019-07-25 13:18 ` Nicholas Johnson
2019-07-25 15:50 ` Logan Gunthorpe
2019-08-04 8:47 ` Nicholas Johnson
2019-08-05 8:59 ` Nicholas Johnson
2019-08-05 12:34 ` Mika Westerberg
2019-08-05 14:09 ` Nicholas Johnson [this message]
2019-08-05 14:25 ` Nicholas Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SL2P216MB01876A10BD2E487294D525BF80DA0@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM \
--to=nicholas.johnson-opensource@outlook.com.au \
--cc=benh@kernel.crashing.org \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).