From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEA3EC2BB1D for ; Tue, 17 Mar 2020 07:31:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A51920724 for ; Tue, 17 Mar 2020 07:31:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=renesasgroup.onmicrosoft.com header.i=@renesasgroup.onmicrosoft.com header.b="B2fO/9Ke" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726112AbgCQHb3 (ORCPT ); Tue, 17 Mar 2020 03:31:29 -0400 Received: from mail-eopbgr1410135.outbound.protection.outlook.com ([40.107.141.135]:6170 "EHLO JPN01-OS2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725962AbgCQHb3 (ORCPT ); Tue, 17 Mar 2020 03:31:29 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J3WijfjHKXnm7peRdfXNelNkUVLkmnZNOexY1sYi19o98P5+Ebxkj3SSNUqg5vBTbR5HJ5Rkp7OkwXWf7NdG3aNcXCQQ6Lh2ZBZQx1gMo38Xb9wXA7Xnl2GbWAcWuewm1kVV3aDjdxlaBm+OICWx4z64uSMnw+EjwGSwFun6u9LJCV6u07cjqX5gGN4B4pM9UY4waNfJI1r3ZtSiVjYfflwmSPDyX0VT5j5vy0gev4ALuSP8v9bfJN2k8dS/QCemYHjpjavKbALSC6YzZBpWE0Af5XnE44Rl5+wphW9J4aBfJFdaG2DRw8VBG0FkAxQOUfxCpa/aDEjt48a0NYvKRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KZlu8doWsEAtzvwPUT6qKWOCHIjBTQpDhp2z+v4aUTQ=; b=TS9v0lTfPjHNNJkDwRzBMWpS5YD6eGKMXSE8NYGoueaVJpGTsaBmsoQMdnAfjY/cNdtWOXvN8jWrlma+CotglkPYdTwX+V9wdmCboyqZx1W8ShjjtNfoazGaTaFARuL1CHgfuvkID2MwlLer3Z6TldK7ivFF6Iz2ELJDwEHFjoCiljvGssbWV0i94cT7iusfWD1tYyqeaf9vQITyCyIfnYyjRNDEQZ5ZtsSY8sTT4T0ui29TxoU4XoT8inwBgtw1lO/ONEDXKCOBZQbC5/0MIysP03bh/nfa9jpGKxEmRrHoZUg1k3WaBebJ13o1KuLKOZxBVfsRhrLJuQYH4ZzpMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector2-renesasgroup-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KZlu8doWsEAtzvwPUT6qKWOCHIjBTQpDhp2z+v4aUTQ=; b=B2fO/9KeggWBRwbDX2ChAGrWY7UntMWGJoz+KD/9msTMif4OHRWYL/9mciXOCw8lRq4JFWGYPLvFAoZTX7poSnW44lvZd/GC+8M+Q1b5ta3wzjZjULfC+GFKBJmz6Y0MT/bwvcLkj+DXvWFQjQU+gh+U1ba3LetaPL6OYRJGMlI= Received: from TYAPR01MB4544.jpnprd01.prod.outlook.com (20.179.175.203) by TYAPR01MB2925.jpnprd01.prod.outlook.com (20.177.103.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.17; Tue, 17 Mar 2020 07:31:25 +0000 Received: from TYAPR01MB4544.jpnprd01.prod.outlook.com ([fe80::ed7f:1268:55a9:fc06]) by TYAPR01MB4544.jpnprd01.prod.outlook.com ([fe80::ed7f:1268:55a9:fc06%4]) with mapi id 15.20.2814.021; Tue, 17 Mar 2020 07:31:25 +0000 From: Yoshihiro Shimoda To: Lad Prabhakar CC: Andrew Murray , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-renesas-soc@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Prabhakar Mahadev Lad , Bjorn Helgaas , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kishon Vijay Abraham I , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Jingoo Han , Gustavo Pimentel , Marek Vasut , Shawn Lin , Heiko Stuebner Subject: RE: [PATCH v5 3/7] PCI: rcar: Fix calculating mask for PCIEPAMR register Thread-Topic: [PATCH v5 3/7] PCI: rcar: Fix calculating mask for PCIEPAMR register Thread-Index: AQHV7k2hxh1UWQe7gUC78mciysp7oahMfYuA Date: Tue, 17 Mar 2020 07:31:24 +0000 Message-ID: References: <20200228154122.14164-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200228154122.14164-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20200228154122.14164-4-prabhakar.mahadev-lad.rj@bp.renesas.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-originating-ip: [124.210.22.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c40bab91-4a24-4186-b97f-08d7ca4532d5 x-ms-traffictypediagnostic: TYAPR01MB2925:|TYAPR01MB2925: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0345CFD558 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(39860400002)(136003)(396003)(376002)(346002)(366004)(199004)(26005)(186003)(7696005)(55236004)(478600001)(33656002)(316002)(6916009)(4326008)(7416002)(71200400001)(8936002)(81166006)(81156014)(8676002)(54906003)(6506007)(86362001)(66556008)(76116006)(9686003)(52536014)(2906002)(66446008)(5660300002)(55016002)(64756008)(66476007)(66946007);DIR:OUT;SFP:1102;SCL:1;SRVR:TYAPR01MB2925;H:TYAPR01MB4544.jpnprd01.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1; received-spf: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QItKDRMGxxJk/LzRWxzMgXvpyNefoyeUESI3YRid/1Dqjw9RlnHHzXqC5rOgcHZQQkleKMgHRJEjf2a+m2oEkUzl5GoK2G0pleG8kStZDJuuJiUE/CkqIipJFg1VNJXj3A5qb+pTe8kfSxy41VQAIDMs/sgXsGSjBJMjX3dF8lnDnlOsudliMozoAF5N++RskZoMtZgG6i5SNvMH1Ru6V/5wVBGhU7yzc7KCZU22dB3W1XY3MhGh+g4jaUTtufvIu4LkAa3SMEgh/gssN83iRkx2D9itzXc6ECBivTXBks6V2vzbl9PW5OQGD+JWpNrxV7eQhAoteVayypCN1QFuqs8KpzU7JZYhXFPy/AbxHNWvouljPJsEjG9cT+Jtqz3w/yFMp2cbLP+sxPMHkImOhwut58nP8Zp31bm7kJyz9nDbS9jApJHknHqqAXD+Z9gq x-ms-exchange-antispam-messagedata: U6uhQRPXIFlJp0xF8xlzCnIMEhjQAhmwL71dXH2r1313wHMPfb2OtZajpmTiUqPvB/WRPEjD80RCc9EToVqyPJOK/VvRK+x4TI/BSUaJEIGmmeoJyVC+sVSPS/KxK5uo/PnzkdCZ5pJFFLcMMYLr2Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: c40bab91-4a24-4186-b97f-08d7ca4532d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2020 07:31:24.8647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NAYgwXmL1WkFsRrf5ujGtVCPSIsda+cvEvzlwFgc/4zzyLJudp3qP/5pKN9NUwHw63OXcO110dL6KIOUOrah547JL5sgdvWNQ6JmWv9mAGsBjC57aKfwmdW4gc35Ru84 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB2925 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Prabhakar-san, Thank you for the patch! > From: Lad Prabhakar, Sent: Saturday, February 29, 2020 12:41 AM >=20 > The mask value was calculated incorrectly for PCIEPAMR register if the > size was less than 128 bytes. Fix this issue by adding a check on size. >=20 > Signed-off-by: Lad Prabhakar > --- > drivers/pci/controller/pcie-rcar.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/= pcie-rcar.c > index 41275f9..90d47b21 100644 > --- a/drivers/pci/controller/pcie-rcar.c > +++ b/drivers/pci/controller/pcie-rcar.c > @@ -75,7 +75,10 @@ void rcar_pcie_set_outbound(int win, void __iomem *bas= e, > * keeps things pretty simple. > */ > size =3D resource_size(res); > - mask =3D (roundup_pow_of_two(size) / SZ_128) - 1; > + if (size > 128) > + mask =3D (roundup_pow_of_two(size) / SZ_128) - 1; > + else > + mask =3D 0x0; > rcar_pci_write_reg(base, mask << 7, PCIEPAMR(win)); This patch seems OK. I think rebasing is needed though. Anyway, Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda > if (res->flags & IORESOURCE_IO) > -- > 2.7.4