From: Richard Zhu <hongxing.zhu@nxp.com>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"stefan@agner.ch" <stefan@agner.ch>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3
Date: Fri, 26 Mar 2021 07:55:34 +0000 [thread overview]
Message-ID: <VI1PR04MB5853077653BBA73ACF58CF3F8C619@VI1PR04MB5853.eurprd04.prod.outlook.com> (raw)
> -----Original Message-----
> From: Krzysztof Wilczyński <kw@linux.com>
> Sent: Friday, March 26, 2021 3:46 PM
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: l.stach@pengutronix.de; andrew.smirnov@gmail.com;
> shawnguo@kernel.org; bhelgaas@google.com; stefan@agner.ch;
> lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph
> voltage is 3v3
> Hi,
>
> > + /*
> > + * Regarding to the datasheet, the PCIE_VPH is suggested
> > + * to be 1.8V. If the PCIE_VPH is supplied by 3.3V, the
> > + * VREG_BYPASS should be cleared to zero.
> > + */
> [...]
>
> A small nitpick here. What about the following:
>
> Regarding the data sheet, the PCIE_VPH is suggested to be 1.8V.
> If the PCIE_VPH is supplied with 3.3V, the VREG_BYPASS should be
> cleared to zero.
>
> What do you think?
[Richard Zhu] Hi Krzysztof:
Thanks for your comments. You're right.
It should be "Regarding something", not the "Regarding to something"
Thanks. 😊
Best Regards
Richard Zhu
>
> Krzysztof
reply other threads:[~2021-03-26 7:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB5853077653BBA73ACF58CF3F8C619@VI1PR04MB5853.eurprd04.prod.outlook.com \
--to=hongxing.zhu@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=bhelgaas@google.com \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).