linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* RE:  Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3
@ 2021-03-26  7:55 Richard Zhu
  0 siblings, 0 replies; only message in thread
From: Richard Zhu @ 2021-03-26  7:55 UTC (permalink / raw)
  To: Krzysztof Wilczyński
  Cc: l.stach, andrew.smirnov, shawnguo, bhelgaas, stefan,
	lorenzo.pieralisi, linux-pci, dl-linux-imx, linux-arm-kernel,
	linux-kernel, kernel

> -----Original Message-----
> From: Krzysztof Wilczyński <kw@linux.com>
> Sent: Friday, March 26, 2021 3:46 PM
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: l.stach@pengutronix.de; andrew.smirnov@gmail.com;
> shawnguo@kernel.org; bhelgaas@google.com; stefan@agner.ch;
> lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph
> voltage is 3v3
> Hi,
> 
> > +             /*
> > +              * Regarding to the datasheet, the PCIE_VPH is suggested
> > +              * to be 1.8V. If the PCIE_VPH is supplied by 3.3V, the
> > +              * VREG_BYPASS should be cleared to zero.
> > +              */
> [...]
> 
> A small nitpick here.  What about the following:
> 
>         Regarding the data sheet, the PCIE_VPH is suggested to be 1.8V.
>         If the PCIE_VPH is supplied with 3.3V, the VREG_BYPASS should be
>         cleared to zero.
> 
> What do you think?
[Richard Zhu] Hi Krzysztof:
Thanks for your comments. You're right.
It should be "Regarding something", not the "Regarding to something"
Thanks. 😊

Best Regards
Richard Zhu

> 
> Krzysztof

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-26  7:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26  7:55 Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3 Richard Zhu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).