linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Zhu <hongxing.zhu@nxp.com>
To: Zhen Lei <thunder.leizhen@huawei.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Rob Herring <robh@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	linux-pci <linux-pci@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 1/1] PCI: dwc/imx6: Remove redundant error printing in imx6_pcie_probe()
Date: Fri, 28 May 2021 07:54:07 +0000	[thread overview]
Message-ID: <VI1PR04MB5853D1AB73A5A1C308D3D60A8C229@VI1PR04MB5853.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210511114547.5601-1-thunder.leizhen@huawei.com>

Hi Zhen Lei:
Thanks.

> Subject: [PATCH 1/1] PCI: dwc/imx6: Remove redundant error printing in
> imx6_pcie_probe()
> 
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error information
> contains the device name, failure cause, and possibly resource information.
> 
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

Acked-by: Richard Zhu <hongxing.zhu@nxp.com>

Best Regards
Richard

> ---
>  drivers/pci/controller/dwc/pci-imx6.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> b/drivers/pci/controller/dwc/pci-imx6.c
> index 0cf1333c044032f..035fb622cafafcd 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1002,10 +1002,8 @@ static int imx6_pcie_probe(struct platform_device
> *pdev)
>  			return ret;
>  		}
>  		imx6_pcie->phy_base = devm_ioremap_resource(dev, &res);
> -		if (IS_ERR(imx6_pcie->phy_base)) {
> -			dev_err(dev, "Unable to map PCIe PHY\n");
> +		if (IS_ERR(imx6_pcie->phy_base))
>  			return PTR_ERR(imx6_pcie->phy_base);
> -		}
>  	}
> 
>  	dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> --
> 2.26.0.106.g9fadedd
> 


  parent reply	other threads:[~2021-05-28  7:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 11:45 [PATCH 1/1] PCI: dwc/imx6: Remove redundant error printing in imx6_pcie_probe() Zhen Lei
2021-05-14 12:51 ` Krzysztof Wilczyński
2021-05-28  7:54 ` Richard Zhu [this message]
2021-06-03 16:44 ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB5853D1AB73A5A1C308D3D60A8C229@VI1PR04MB5853.eurprd04.prod.outlook.com \
    --to=hongxing.zhu@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).