From: Richard Zhu <hongxing.zhu@nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [EXT] Re: [PATCH 1/2] ARM: dts: imx6qp-sabresd: enable pcie
Date: Wed, 22 Jul 2020 01:13:08 +0000 [thread overview]
Message-ID: <VI1PR04MB5853FE6C8680BD087C7C9B408C790@VI1PR04MB5853.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <d8760e851fdf8a934dca20a9440bced16bb39123.camel@pengutronix.de>
> -----Original Message-----
> From: Lucas Stach <l.stach@pengutronix.de>
> Sent: 2020年7月21日 16:16
> To: Richard Zhu <hongxing.zhu@nxp.com>; bhelgaas@google.com;
> shawnguo@kernel.org; festevam@gmail.com
> Cc: linux-pci@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel@pengutronix.de
> Subject: [EXT] Re: [PATCH 1/2] ARM: dts: imx6qp-sabresd: enable pcie
> Am Dienstag, den 21.07.2020, 15:44 +0800 schrieb Richard Zhu:
> > Add one regulator, used to power up the external oscillator, and
> > enable PCIe on iMX6QP SABRESD board.
>
> That's not the right thing to do. If there is an external oscillator, which
> requires a power supply then the oscillator should have its own clock DT
> node (it's a separate device after all) and this node needs to control the
> regulator.
>
> This has nothing to do with the PCIe controller, which only cares about the
> clock being provided.
>
Hi Lucas:
Thanks for your comments.
Okay, I would integrate the regulator into one clock node later.
Best Regards
Richard Zhu
> Regards,
> Lucas
>
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
> > arch/arm/boot/dts/imx6qp-sabresd.dts | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qp-sabresd.dts
> > b/arch/arm/boot/dts/imx6qp-sabresd.dts
> > index 480e73183f6b..cd8a1f610427 100644
> > --- a/arch/arm/boot/dts/imx6qp-sabresd.dts
> > +++ b/arch/arm/boot/dts/imx6qp-sabresd.dts
> > @@ -51,7 +51,8 @@
> > };
> >
> > &pcie {
> > - status = "disabled";
> > + vepdev-supply = <&vgen3_reg>;
> > + status = "okay";
> > };
> >
> > &sata {
prev parent reply other threads:[~2020-07-22 1:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 7:44 [PATCH 1/2] ARM: dts: imx6qp-sabresd: enable pcie Richard Zhu
2020-07-21 7:44 ` [PATCH 2/2] PCI: imx: add another regulator for imx pcie Richard Zhu
2020-07-21 8:16 ` [PATCH 1/2] ARM: dts: imx6qp-sabresd: enable pcie Lucas Stach
2020-07-22 1:13 ` Richard Zhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB5853FE6C8680BD087C7C9B408C790@VI1PR04MB5853.eurprd04.prod.outlook.com \
--to=hongxing.zhu@nxp.com \
--cc=bhelgaas@google.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).